From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932299AbdBGTv5 (ORCPT ); Tue, 7 Feb 2017 14:51:57 -0500 Received: from mout.web.de ([217.72.192.78]:49584 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752885AbdBGTvz (ORCPT ); Tue, 7 Feb 2017 14:51:55 -0500 Subject: [PATCH 09/18] HID: Return an error code only as a constant in hid_allocate_device() To: linux-input@vger.kernel.org, Benjamin Tissoires , =?UTF-8?Q?Bruno_Pr=c3=a9mont?= , Jiri Kosina References: Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <58187414-2ced-17cb-cb6a-0fe87d0e5fac@users.sourceforge.net> Date: Tue, 7 Feb 2017 20:51:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:8aSSDHnQ39BKMIPM6MrU9/Bl4k4mpz9JTVZh00LAX2nnfOLh6De B7efab5JXwhqNeVZdw0ZCgmdR4W+raFVLIWAcvIHb1UGiS6J5/9ewYASygo6CHgSuyLEZm+ tRRmR3A270OevwRwSYNZCoAsqzOXw4+RQGGyG3xxfkJ1zPeqfumcAY8RAmuytAESEbpPQiJ Hlgua0bytFeQVsf8+Wpmg== X-UI-Out-Filterresults: notjunk:1;V01:K0:hRXVCzrXfkI=:r89yaBsRgbhwWeFk8q3tHv qPkqbxRLuQIOqET8cjpFRVMPldVg9hDmaWAK9/rP8mOqpAmpNUJWN1Ufo1EwIOBy7MjNZ9VLY rpEYCtsaLvkWCXf8MgmHHFvY2Hdf6u6H2zVD4MIk5Qy40Wucg+MfOsxihDOkk9EsAGkMyGrqO 49Os4tpwpw0RPgVx5StKWByV+fP46GWB6SzczAFAzYta2Y4EUGxFb1wZ1aKcRchvh5i+3rr28 die6drRcDlynpXpGegpxY8pWoMqRKyVDEZI6IStdkGzkvopySJf7angF9iSw/R8wEXmnUy7tV ymu1AcvnD2C2WtGFJK7DfOB1CSsTe9Y+0JL8yt2yS9GnCiZrJsBuvmA0RcDcfi0H2BEZTB2NN JrMpuelo3BGdhHvPbyTMa9EGYdq0IxX219U1qtbNt6hZaSGxSOdVB2OVis8Up2zYfYNnlRyQF HqGSXofOPMjTn8rYADdAc410aETkRgR2djfxcek7NBGXGoThvNBkA4sBzBrvV7yKCfuQ4xJGq bz1yVV1JMrB1OzQDvCwkUf/tTNhxJKQITIkYtg03CvbZNjipSIRVdRa/kqtLgnM1T+3Trh6vK fXRQgnQqJUP2/gKny33tBPfFsFZRDyhBgbzCuop038j1E+tOhW31qaeceJzMYHmOfOCJK3gx0 a30U2xFP1Vm0ima150lco3T8eKbobo+wXFQBLAw4DZ74gQhxGjY3QeEt05QTYJZjCWVEX/5Sh 8c3wAy+58l2q82Acq+WpYdI9C3N4nbvWngYjYdfjUuwRBjoPtjL5kwKvk7rgy+h76UGekcrdt rG87DEx Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 7 Feb 2017 19:17:36 +0100 * Return an error code without storing it in an intermediate variable. * Delete the local variable "ret" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- drivers/hid/hid-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index f4ea3590954c..a5db000ed1c4 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -2716,11 +2716,10 @@ EXPORT_SYMBOL_GPL(hid_add_device); struct hid_device *hid_allocate_device(void) { struct hid_device *hdev; - int ret = -ENOMEM; hdev = kzalloc(sizeof(*hdev), GFP_KERNEL); if (!hdev) - return ERR_PTR(ret); + return ERR_PTR(-ENOMEM); device_initialize(&hdev->dev); hdev->dev.release = hid_device_release; -- 2.11.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 07 Feb 2017 19:51:37 +0000 Subject: [PATCH 09/18] HID: Return an error code only as a constant in hid_allocate_device() Message-Id: <58187414-2ced-17cb-cb6a-0fe87d0e5fac@users.sourceforge.net> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-input@vger.kernel.org, Benjamin Tissoires , =?UTF-8?Q?Bruno_Pr=c3=a9mont?= , Jiri Kosina Cc: LKML , kernel-janitors@vger.kernel.org From: Markus Elfring Date: Tue, 7 Feb 2017 19:17:36 +0100 * Return an error code without storing it in an intermediate variable. * Delete the local variable "ret" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- drivers/hid/hid-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index f4ea3590954c..a5db000ed1c4 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -2716,11 +2716,10 @@ EXPORT_SYMBOL_GPL(hid_add_device); struct hid_device *hid_allocate_device(void) { struct hid_device *hdev; - int ret = -ENOMEM; hdev = kzalloc(sizeof(*hdev), GFP_KERNEL); if (!hdev) - return ERR_PTR(ret); + return ERR_PTR(-ENOMEM); device_initialize(&hdev->dev); hdev->dev.release = hid_device_release; -- 2.11.1