From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Gonzalez Subject: Re: [PATCH v7 1/2] mtd: nand: add tango NFC dt bindings doc Date: Mon, 7 Nov 2016 10:26:48 +0100 Message-ID: <582048D8.3000000@sigmadesigns.com> References: <580F5AD2.9020909@sigmadesigns.com> <580F5B06.6030608@sigmadesigns.com> <1978954.SRtJpfOGp1@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1978954.SRtJpfOGp1@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org To: Arnd Bergmann Cc: Mark Rutland , Boris Brezillon , DT , Richard Weinberger , Mason , Rob Herring , linux-mtd , Sebastian Frias List-Id: devicetree@vger.kernel.org On 07/11/2016 10:18, Arnd Bergmann wrote: > On Tuesday, October 25, 2016 3:15:50 PM CET Marc Gonzalez wrote: >> Add the tango NAND Flash Controller dt bindings documentation. >> >> Signed-off-by: Marc Gonzalez >> --- >> Documentation/devicetree/bindings/mtd/tango-nand.txt | 38 ++++++++++++++++++++++++++++++ >> 1 file changed, 38 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mtd/tango-nand.txt b/Documentation/devicetree/bindings/mtd/tango-nand.txt >> new file mode 100644 >> index 000000000000..3cbf95d6595a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mtd/tango-nand.txt >> @@ -0,0 +1,38 @@ >> +Sigma Designs Tango4 NAND Flash Controller (NFC) >> + >> +Required properties: >> + >> +- compatible: "sigma,smp8758-nand" >> +- reg: address/size of nfc_reg, nfc_mem, and pbus_reg >> +- dmas: reference to the DMA channel used by the controller >> +- dma-names: "nfc_sbox" > > Drop the "nfc_" prefix here, it seems redundant. I don't think it's redundant; there are switch boxes for several different HW blocks; nfc_sbox is the first one to be exposed. >> +- clocks: reference to the system clock >> +- #address-cells: <1> >> +- #size-cells: <0> >> + >> +Children nodes represent the available NAND chips. >> +See Documentation/devicetree/bindings/mtd/nand.txt for generic bindings. >> + >> +Example: >> + >> + nand: nand@2c000 { >> + compatible = "sigma,smp8758-nand"; >> + reg = <0x2c000 0x30 0x2d000 0x800 0x20000 0x1000>; > > It would be nicer to write this as > > reg = <0x2c000 0x30>, <0x2d000 0x800>, <0x20000 0x1000>; > > which is identical in binary format. I didn't know that, thanks for pointing it out. Unfortunately, Boris already accepted the patch yesterday :-( Boris, do you fixup patches in your tree? Regards. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail1.bemta12.messagelabs.com ([216.82.251.8]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1c3gCx-0004cS-1T for linux-mtd@lists.infradead.org; Mon, 07 Nov 2016 09:27:43 +0000 Subject: Re: [PATCH v7 1/2] mtd: nand: add tango NFC dt bindings doc To: Arnd Bergmann CC: linux-mtd , Boris Brezillon , Richard Weinberger , DT , Rob Herring , Mark Rutland , Mason , Sebastian Frias References: <580F5AD2.9020909@sigmadesigns.com> <580F5B06.6030608@sigmadesigns.com> <1978954.SRtJpfOGp1@wuerfel> From: Marc Gonzalez Message-ID: <582048D8.3000000@sigmadesigns.com> Date: Mon, 7 Nov 2016 10:26:48 +0100 MIME-Version: 1.0 In-Reply-To: <1978954.SRtJpfOGp1@wuerfel> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 07/11/2016 10:18, Arnd Bergmann wrote: > On Tuesday, October 25, 2016 3:15:50 PM CET Marc Gonzalez wrote: >> Add the tango NAND Flash Controller dt bindings documentation. >> >> Signed-off-by: Marc Gonzalez >> --- >> Documentation/devicetree/bindings/mtd/tango-nand.txt | 38 ++++++++++++++++++++++++++++++ >> 1 file changed, 38 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mtd/tango-nand.txt b/Documentation/devicetree/bindings/mtd/tango-nand.txt >> new file mode 100644 >> index 000000000000..3cbf95d6595a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mtd/tango-nand.txt >> @@ -0,0 +1,38 @@ >> +Sigma Designs Tango4 NAND Flash Controller (NFC) >> + >> +Required properties: >> + >> +- compatible: "sigma,smp8758-nand" >> +- reg: address/size of nfc_reg, nfc_mem, and pbus_reg >> +- dmas: reference to the DMA channel used by the controller >> +- dma-names: "nfc_sbox" > > Drop the "nfc_" prefix here, it seems redundant. I don't think it's redundant; there are switch boxes for several different HW blocks; nfc_sbox is the first one to be exposed. >> +- clocks: reference to the system clock >> +- #address-cells: <1> >> +- #size-cells: <0> >> + >> +Children nodes represent the available NAND chips. >> +See Documentation/devicetree/bindings/mtd/nand.txt for generic bindings. >> + >> +Example: >> + >> + nand: nand@2c000 { >> + compatible = "sigma,smp8758-nand"; >> + reg = <0x2c000 0x30 0x2d000 0x800 0x20000 0x1000>; > > It would be nicer to write this as > > reg = <0x2c000 0x30>, <0x2d000 0x800>, <0x20000 0x1000>; > > which is identical in binary format. I didn't know that, thanks for pointing it out. Unfortunately, Boris already accepted the patch yesterday :-( Boris, do you fixup patches in your tree? Regards.