From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0706FC6FD1F for ; Thu, 21 Mar 2024 18:01:25 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B2AFD42DC3; Thu, 21 Mar 2024 19:01:24 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 347E142DC4 for ; Thu, 21 Mar 2024 19:01:23 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id A06F23200A0D; Thu, 21 Mar 2024 14:01:21 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 21 Mar 2024 14:01:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1711044081; x=1711130481; bh=WmdffVObk8RWcIZj6P6faxj9TQcodrEzeSmy4JvoeN4=; b= AXzWI/eo4nwaYkg1KxgolKmQSO/zMimvnzqwKKAtptXX/10pW8CXj4mUGU8t53rQ HqmO3P411Z+wd98uGi2hJKVhx9dMOYGUwrxB5s5l9B5SoTcHIcKuc7bEMOf+S1cV tjjG1VSvNb+3V6GB6tJqfKSIIeYvLwpOqcOXpClSeK93oWnlDHU1HLRmOUqu8a1T Er4xm7hVfar/ejzzCYKpyArLVlpbZ+0DOwijk6F6qy+PKBqkfB7za4wy8IGP0lcD FHDVi3oYvhrV2VMEj749P0xuPU+llFLM4MzJZmqTI44rUsGISX7sb46SfquncOZ/ SJoRms7P3WLRi54aq7LyWQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1711044081; x= 1711130481; bh=WmdffVObk8RWcIZj6P6faxj9TQcodrEzeSmy4JvoeN4=; b=l xEfdy4b78jo/kLcvKtDXZv5+WwE9KDXOdq7YtzdtEIEOsxlv6VCt5sIRPHfXe7OP sdVLCsjjBSFHd1Hll1ThDqE9g/Pt1ujO/M3A6jekp+shd9BidIBOuCCyvcAHLQUt /BKPeD40UW26rvTi1KdLx/3+he0hNumSnTHR6X7qUKMkgWmXUoVD37/dkRIgEFzw hYzEsLB/ibAme1WI9Q6uLbW/RsEIy8ygq7IO5VMUDi9ya4VkGIi070pwYol1RAB1 bTo2oauHnPYWCtbJ07/axTiifP/yf17/srjsrGqer/7sGcin+WYHDjMBpO0QuZdD Uzq9RWpTGB+++zZevXS6A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrleejgdegiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeuveejffejgedtgeegkefg vdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 21 Mar 2024 14:01:19 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org, Bruce Richardson , Jasvinder Singh , Konstantin Ananyev , david.marchand@redhat.com Subject: Re: [PATCH] net: stop using mmx intrinsics Date: Thu, 21 Mar 2024 19:01:17 +0100 Message-ID: <5822839.1B3tZ46Xf9@thomas> In-Reply-To: <20240321172707.GA1605@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1710969121-18503-1-git-send-email-roretzla@linux.microsoft.com> <13164815.EVyyLHbfrO@thomas> <20240321172707.GA1605@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 21/03/2024 18:27, Tyler Retzlaff: > On Thu, Mar 21, 2024 at 06:09:01PM +0100, Thomas Monjalon wrote: > > 20/03/2024 22:12, Tyler Retzlaff: > > > +#ifdef RTE_TOOLCHAIN_MSVC > > > +#include > > > +#else > > > #include > > > +#endif > > > > It is not the same include in MSVC? > > unfortunately intrin.h is vestigial in the monolithic approach. to use > any intrinsic you're supposed to include only the one and only true > header instead of vendor/arch feature specific headers. > > > Is it something we want to wrap in a DPDK header file? > > do you mean create a monolithic rte_intrinsic.h header that is > essentially > > #ifdef MSVC > #include > #else > #include > #include > #include > ... > #endif > > i assumed that doing something like this might be unpopular due to the > unnecessary namespace pollution. We already have such a file. It is rte_vect.h. I suppose we should just make sure it is included consistently instead of x86intrin.h or immintrin.h This command will show where changes are required: git grep intrin.h