From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S966022AbcKKCtH (ORCPT <rfc822;w@1wt.eu>);
        Thu, 10 Nov 2016 21:49:07 -0500
Received: from mga05.intel.com ([192.55.52.43]:2820 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S964951AbcKKCtF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Nov 2016 21:49:05 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,620,1473145200"; 
   d="scan'208";a="785128746"
Subject: Re: [PATCH v4 1/4] usb: dbc: early driver for xhci debug capability
To: Thomas Gleixner <tglx@linutronix.de>
References: <1477976354-13291-1-git-send-email-baolu.lu@linux.intel.com>
 <1477976354-13291-2-git-send-email-baolu.lu@linux.intel.com>
 <alpine.DEB.2.20.1611091030171.3501@nanos> <5823CB63.7090603@linux.intel.com>
 <alpine.DEB.2.20.1611100946190.3501@nanos> <58252BDB.1020005@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>, linux-usb@vger.kernel.org,
        x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
From: Lu Baolu <baolu.lu@linux.intel.com>
Message-ID: <582531A0.1080703@linux.intel.com>
Date: Fri, 11 Nov 2016 10:49:04 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <58252BDB.1020005@linux.intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 11/11/2016 10:24 AM, Lu Baolu wrote:
>> The only thing you can do to make this work is to prevent printing in NMI
>> > context:
>> >
>> > write()
>> > {
>> > 	if (in_nmi())
>> > 		return;
>> > 	
>> > 	raw_spinlock_irqsave(&lock, flags);
>> > 	....
>> >
>> > That fully serializes the writes and just ignores NMI context printks. Not
>> > optimal, but I fear that's all you can do.
> Yes. But I want to add a bit more.
>
> write()
> {
> 	if (in_nmi() && raw_spin_is_locked(&lock)) {
> 		trace("... ...");
> 		return;
> 	}
>
> 	raw_spinlock_irqsave(&lock, flags);
> 	....

Or...?

write()
{
	if (in_nmi() && raw_spin_is_locked(&lock)) {
		save_nmi_message_in_local_buf();
		set_nmi_message_pending_flag();
		return;
	}

	if (nmi_message_pending_flag_is_set()) {
		write_nmi_message();
		clear_nmi_message_pending_flag();
	}

	raw_spinlock_irqsave(&lock, flags);
	....


Best regards,
Lu Baolu