From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAC2FC433E1 for ; Fri, 3 Jul 2020 06:38:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B82D820772 for ; Fri, 3 Jul 2020 06:38:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TW3k/K6s" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726194AbgGCGiz (ORCPT ); Fri, 3 Jul 2020 02:38:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725779AbgGCGiy (ORCPT ); Fri, 3 Jul 2020 02:38:54 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE413C08C5DD for ; Thu, 2 Jul 2020 23:38:53 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id o2so32626864wmh.2 for ; Thu, 02 Jul 2020 23:38:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eorUmfUDMZcNbxM4Fi+PFLp5IkxH/y0wJ21yqWKUjto=; b=TW3k/K6sgcyOzEJs1rw4KfmOe6mN35kwzPQC2F/IgbreSFQA8LXxI7YB4jg768YPf/ qlg1GD44Sj2mlQxBQfGEjhGX+c1yfO9Z2Mc+s3nSyOkzpJAHcbxMv5x83AFf4RMl33Gm yETeAQpLmJArPgsTWZB5qQKZ8Av/jgJcSZrGjUH26ysjAUnp1x07PQ8p12XuVcqaQK5X GMh0+9HUQqJoYLlyJFUBhedpmjHLeeAZnlpCjwpSz8Hl1wDM4IBIpPuTU1aSgw+6hhf5 PQOMSuzQnnW914bYoIpCxkKUDZ3G876lD7uO8p49b0PgquhyTREZXOsoMzsDs/Eo5jcO p6mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eorUmfUDMZcNbxM4Fi+PFLp5IkxH/y0wJ21yqWKUjto=; b=YKea9iYGRcNlGCTkeCs2WxcJl4BvvPxROLqAU32qD6Nv7XQMwuq/c4wlByH6qSI2qL PISEkBvW6ieB2zMbazaIo7Ya3qoDGUG7mQuBkInfJhNFxepLf9hsYwYURieyiLlr+WBZ o/wQk740xA1q4Wh022mkJPiItT2rtUtziKp6WtMD9ETxLsYJBh3R/AG2uiGl+01GoLTV vlOHw11YnnUdWzHrfbUwoZZbHMv5v33iB+ujJJZfgH0HS6rQgO3iuphhRCt432Z664ke iGKtDv4bRyJpPjPYANTVNBf5s2Ha/9q4t5Ib44PUJHf3iHSsXFJnEH8mWHyIz9Sa4DKd P7iQ== X-Gm-Message-State: AOAM532TdIaJEBg9ung6PTJT3Q8WD6h4Y7X44oIjusdP10MwpQB7F3Bh B17oGghnySA7PPyHQ1RCP4FV2g== X-Google-Smtp-Source: ABdhPJwx/dU/vear+SglZ3FxU9XUXFqcn8iwzYeLZYSHOLOaUd4iFi5d4+vvIppL6IdFuFPEJc4a0g== X-Received: by 2002:a1c:7311:: with SMTP id d17mr24326224wmb.60.1593758332203; Thu, 02 Jul 2020 23:38:52 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:7019:4e9b:2970:f860? ([2a01:e34:ed2f:f020:7019:4e9b:2970:f860]) by smtp.googlemail.com with ESMTPSA id 65sm13709437wre.6.2020.07.02.23.38.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2020 23:38:51 -0700 (PDT) Subject: Re: [PATCH v7 00/11] Stop monitoring disabled devices To: Zhang Rui , Andrzej Pietrasiewicz , linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org Cc: "Rafael J . Wysocki" , Len Brown , Vishal Kulkarni , "David S . Miller" , Jiri Pirko , Ido Schimmel , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , Kalle Valo , Peter Kaestle , Darren Hart , Andy Shevchenko , Sebastian Reichel , Miquel Raynal , Amit Kucheria , Support Opensource , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Heiko Stuebner , Orson Zhai , Baolin Wang , Chunyan Zhang , Allison Randal , Enrico Weigelt , Gayatri Kammela , Thomas Gleixner , Bartlomiej Zolnierkiewicz , kernel@collabora.com References: <20200629122925.21729-1-andrzej.p@collabora.com> <3d03d1a2-ac06-b69b-93cb-e0203be62c10@collabora.com> <47111821-d691-e71d-d740-e4325e290fa4@linaro.org> <4353a939-3f5e-8369-5bc0-ad8162b5ffc7@linaro.org> <73942aea-ae79-753c-fe90-d4a99423d548@collabora.com> <374dddd9-b600-3a30-d6c3-8cfcefc944d9@linaro.org> <5a28deb7-f307-8b03-faad-ab05cb8095d1@collabora.com> <8aeb4f51-1813-63c1-165b-06640af5968f@linaro.org> <685ef627-e377-bbf1-da11-7f7556ca2dd7@collabora.com> <44c622dd7de8c7bf143c4435c0edd1b98d09a3d6.camel@intel.com> From: Daniel Lezcano Message-ID: <58265668-fc6d-729a-c126-0c73c2ea853b@linaro.org> Date: Fri, 3 Jul 2020 08:38:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <44c622dd7de8c7bf143c4435c0edd1b98d09a3d6.camel@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 03/07/2020 03:49, Zhang Rui wrote: > On Thu, 2020-07-02 at 19:49 +0200, Daniel Lezcano wrote: [ ... ] >>> So the reason is that ->get_temp() is called while the mutex is >>> held and >>> thermal_zone_device_is_enabled() wants to take the same mutex. >> >> Yes, that's correct. >> >>> Is adding a comment to thermal_zone_device_is_enabled() to never >>> call >>> it while the mutex is held and adding another version of it which >>> does >>> not take the mutex ok? >> >> The thermal_zone_device_is_enabled() is only used in two places, acpi >> and this imx driver, and given: >> >> 1. as soon as the mutex is released, there is no guarantee the >> thermal >> zone won't be changed right after, the lock is pointless, thus the >> information also. >> >> 2. from a design point of view, I don't see why a driver should know >> if >> a thermal zone is disabled or not >> >> It would make sense to end with this function and do not give the >> different drivers an opportunity to access this information. > > I agree. >> >> Why not add change_mode for the acpi in order to enable or disable >> the >> events > > thermal_zone_device_is_enabled() is invoked in acpi thermal driver > because we only want to do thermal_zone_device_update() when the acpi > thermal zone is enabled. > > As thermal_zone_device_update() can handle a disabled thermal zone now, > we can just remove the check. Ah yes, good point! -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH v7 00/11] Stop monitoring disabled devices Date: Fri, 3 Jul 2020 08:38:48 +0200 Message-ID: <58265668-fc6d-729a-c126-0c73c2ea853b@linaro.org> References: <20200629122925.21729-1-andrzej.p@collabora.com> <3d03d1a2-ac06-b69b-93cb-e0203be62c10@collabora.com> <47111821-d691-e71d-d740-e4325e290fa4@linaro.org> <4353a939-3f5e-8369-5bc0-ad8162b5ffc7@linaro.org> <73942aea-ae79-753c-fe90-d4a99423d548@collabora.com> <374dddd9-b600-3a30-d6c3-8cfcefc944d9@linaro.org> <5a28deb7-f307-8b03-faad-ab05cb8095d1@collabora.com> <8aeb4f51-1813-63c1-165b-06640af5968f@linaro.org> <685ef627-e377-bbf1-da11-7f7556ca2dd7@collabora.com> <44c622dd7de8c7bf143c4435c0edd1b98d09a3d6.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <44c622dd7de8c7bf143c4435c0edd1b98d09a3d6.camel@intel.com> Content-Language: en-US Sender: linux-renesas-soc-owner@vger.kernel.org To: Zhang Rui , Andrzej Pietrasiewicz , linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org Cc: "Rafael J . Wysocki" , Len Brown , Vishal Kulkarni , "David S . Miller" , Jiri Pirko , Ido Schimmel , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , Kalle Valo , Peter Kaestle , Darren Hart , Andy Shevchenko , Sebastian Reichel , Miquel Raynal , Amit Kucheria , Support Opensource , Shawn Guo List-Id: platform-driver-x86.vger.kernel.org On 03/07/2020 03:49, Zhang Rui wrote: > On Thu, 2020-07-02 at 19:49 +0200, Daniel Lezcano wrote: [ ... ] >>> So the reason is that ->get_temp() is called while the mutex is >>> held and >>> thermal_zone_device_is_enabled() wants to take the same mutex. >> >> Yes, that's correct. >> >>> Is adding a comment to thermal_zone_device_is_enabled() to never >>> call >>> it while the mutex is held and adding another version of it which >>> does >>> not take the mutex ok? >> >> The thermal_zone_device_is_enabled() is only used in two places, acpi >> and this imx driver, and given: >> >> 1. as soon as the mutex is released, there is no guarantee the >> thermal >> zone won't be changed right after, the lock is pointless, thus the >> information also. >> >> 2. from a design point of view, I don't see why a driver should know >> if >> a thermal zone is disabled or not >> >> It would make sense to end with this function and do not give the >> different drivers an opportunity to access this information. > > I agree. >> >> Why not add change_mode for the acpi in order to enable or disable >> the >> events > > thermal_zone_device_is_enabled() is invoked in acpi thermal driver > because we only want to do thermal_zone_device_update() when the acpi > thermal zone is enabled. > > As thermal_zone_device_update() can handle a disabled thermal zone now, > we can just remove the check. Ah yes, good point! -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A52DAC433E0 for ; Fri, 3 Jul 2020 06:40:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7249D20674 for ; Fri, 3 Jul 2020 06:40:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OJ7s20F/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TW3k/K6s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7249D20674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QAYQufb0qdNUqnYoY/eP5zdMWtQJS47iCpuvnpeoYj8=; b=OJ7s20F/q6nzfxLmsiccIzegv zAW6mZrV18rirwqoKtWhios1DOuTj0NyX8qf7e4D2Wl0QbwB2uc+TY7GrCFvL+ZhPfcucHmSECMk6 fH1yjqKHdMa9+WBAMQPGGo8mvB9jHr4DdpPNjN0irjlQUHjrWrU8f0b5zxKAItJXYOmQ4h4PjoDza gReo3EG1RtDLhjAGRIfgGOIOR7ktPHkUZTbKcjR+tsTRple8FtpNzLZRZeNSUE/BiED4YUwmR3ONj uCn2wK7V1L+j+3q0sqdBV9BlBPmCGBbkMTi0ulWLwX4IK9UV8xeLANXCEkEWvDj67Ax1eQkJXlbgj Iq5eICveA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrFLh-0006vA-MC; Fri, 03 Jul 2020 06:39:01 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrFLZ-0006tI-Ej for linux-arm-kernel@lists.infradead.org; Fri, 03 Jul 2020 06:38:55 +0000 Received: by mail-wm1-x344.google.com with SMTP id o8so30813061wmh.4 for ; Thu, 02 Jul 2020 23:38:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eorUmfUDMZcNbxM4Fi+PFLp5IkxH/y0wJ21yqWKUjto=; b=TW3k/K6sgcyOzEJs1rw4KfmOe6mN35kwzPQC2F/IgbreSFQA8LXxI7YB4jg768YPf/ qlg1GD44Sj2mlQxBQfGEjhGX+c1yfO9Z2Mc+s3nSyOkzpJAHcbxMv5x83AFf4RMl33Gm yETeAQpLmJArPgsTWZB5qQKZ8Av/jgJcSZrGjUH26ysjAUnp1x07PQ8p12XuVcqaQK5X GMh0+9HUQqJoYLlyJFUBhedpmjHLeeAZnlpCjwpSz8Hl1wDM4IBIpPuTU1aSgw+6hhf5 PQOMSuzQnnW914bYoIpCxkKUDZ3G876lD7uO8p49b0PgquhyTREZXOsoMzsDs/Eo5jcO p6mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eorUmfUDMZcNbxM4Fi+PFLp5IkxH/y0wJ21yqWKUjto=; b=OQFnOSz9k0DtcZGwM4kkP5rB/c5v4ecOp3dH79Zl7KJZe0oU6CMymFiflYm9/fKXTY uZvhw2fQXgsulMe7l4R7YK6jxlC1Y3kTyqUoTGxC0YXewoeuDNYaT4Y+5mRmhG70wGu4 bF66IzVB7J4wFqqNmwA5MvYSZdqgWmFr/IqYfMwHkXojPhFW8O9or09ywDG/a420+F0H jqQ4e0KnRlHW0jvUb0U7PWUKifCDtx2X/9hsV2Eat5KYex42hh/Mo0rnDYIOLLBC/EVD IeVvEcTixAMDAKY/M7wXbTeEdW1Urw7hwaByrkwK5D7+FSEoNpIlpH71m1wQ79rYyNZh LPoA== X-Gm-Message-State: AOAM533Jx7k+xqckc82ejcAAo1mRdhFQ3IQGj9gGZu4m+5Iu163jGxI6 SsTa3cVXPBFsm3AivjeKRC4ABQ== X-Google-Smtp-Source: ABdhPJwx/dU/vear+SglZ3FxU9XUXFqcn8iwzYeLZYSHOLOaUd4iFi5d4+vvIppL6IdFuFPEJc4a0g== X-Received: by 2002:a1c:7311:: with SMTP id d17mr24326224wmb.60.1593758332203; Thu, 02 Jul 2020 23:38:52 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:7019:4e9b:2970:f860? ([2a01:e34:ed2f:f020:7019:4e9b:2970:f860]) by smtp.googlemail.com with ESMTPSA id 65sm13709437wre.6.2020.07.02.23.38.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2020 23:38:51 -0700 (PDT) Subject: Re: [PATCH v7 00/11] Stop monitoring disabled devices To: Zhang Rui , Andrzej Pietrasiewicz , linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20200629122925.21729-1-andrzej.p@collabora.com> <3d03d1a2-ac06-b69b-93cb-e0203be62c10@collabora.com> <47111821-d691-e71d-d740-e4325e290fa4@linaro.org> <4353a939-3f5e-8369-5bc0-ad8162b5ffc7@linaro.org> <73942aea-ae79-753c-fe90-d4a99423d548@collabora.com> <374dddd9-b600-3a30-d6c3-8cfcefc944d9@linaro.org> <5a28deb7-f307-8b03-faad-ab05cb8095d1@collabora.com> <8aeb4f51-1813-63c1-165b-06640af5968f@linaro.org> <685ef627-e377-bbf1-da11-7f7556ca2dd7@collabora.com> <44c622dd7de8c7bf143c4435c0edd1b98d09a3d6.camel@intel.com> From: Daniel Lezcano Message-ID: <58265668-fc6d-729a-c126-0c73c2ea853b@linaro.org> Date: Fri, 3 Jul 2020 08:38:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <44c622dd7de8c7bf143c4435c0edd1b98d09a3d6.camel@intel.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200703_023853_841995_DD018A2F X-CRM114-Status: GOOD ( 20.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emmanuel Grumbach , Heiko Stuebner , "Rafael J . Wysocki" , Vishal Kulkarni , Luca Coelho , Miquel Raynal , kernel@collabora.com, Fabio Estevam , Amit Kucheria , Chunyan Zhang , Bartlomiej Zolnierkiewicz , Allison Randal , NXP Linux Team , Darren Hart , Gayatri Kammela , Len Brown , Johannes Berg , Intel Linux Wireless , Sascha Hauer , Ido Schimmel , Baolin Wang , Jiri Pirko , Orson Zhai , Thomas Gleixner , Kalle Valo , Support Opensource , Enrico Weigelt , Peter Kaestle , Sebastian Reichel , Pengutronix Kernel Team , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Shawn Guo , "David S . Miller" , Andy Shevchenko Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMDMvMDcvMjAyMCAwMzo0OSwgWmhhbmcgUnVpIHdyb3RlOgo+IE9uIFRodSwgMjAyMC0wNy0w MiBhdCAxOTo0OSArMDIwMCwgRGFuaWVsIExlemNhbm8gd3JvdGU6CgpbIC4uLiBdCgo+Pj4gU28g dGhlIHJlYXNvbiBpcyB0aGF0IC0+Z2V0X3RlbXAoKSBpcyBjYWxsZWQgd2hpbGUgdGhlIG11dGV4 IGlzCj4+PiBoZWxkIGFuZAo+Pj4gdGhlcm1hbF96b25lX2RldmljZV9pc19lbmFibGVkKCkgd2Fu dHMgdG8gdGFrZSB0aGUgc2FtZSBtdXRleC4KPj4KPj4gWWVzLCB0aGF0J3MgY29ycmVjdC4KPj4K Pj4+IElzIGFkZGluZyBhIGNvbW1lbnQgdG8gdGhlcm1hbF96b25lX2RldmljZV9pc19lbmFibGVk KCkgdG8gbmV2ZXIKPj4+IGNhbGwKPj4+IGl0IHdoaWxlIHRoZSBtdXRleCBpcyBoZWxkIGFuZCBh ZGRpbmcgYW5vdGhlciB2ZXJzaW9uIG9mIGl0IHdoaWNoCj4+PiBkb2VzCj4+PiBub3QgdGFrZSB0 aGUgbXV0ZXggb2s/Cj4+Cj4+IFRoZSB0aGVybWFsX3pvbmVfZGV2aWNlX2lzX2VuYWJsZWQoKSBp cyBvbmx5IHVzZWQgaW4gdHdvIHBsYWNlcywgYWNwaQo+PiBhbmQgdGhpcyBpbXggZHJpdmVyLCBh bmQgZ2l2ZW46Cj4+Cj4+IDEuIGFzIHNvb24gYXMgdGhlIG11dGV4IGlzIHJlbGVhc2VkLCB0aGVy ZSBpcyBubyBndWFyYW50ZWUgdGhlCj4+IHRoZXJtYWwKPj4gem9uZSB3b24ndCBiZSBjaGFuZ2Vk IHJpZ2h0IGFmdGVyLCB0aGUgbG9jayBpcyBwb2ludGxlc3MsIHRodXMgdGhlCj4+IGluZm9ybWF0 aW9uIGFsc28uCj4+Cj4+IDIuIGZyb20gYSBkZXNpZ24gcG9pbnQgb2YgdmlldywgSSBkb24ndCBz ZWUgd2h5IGEgZHJpdmVyIHNob3VsZCBrbm93Cj4+IGlmCj4+IGEgdGhlcm1hbCB6b25lIGlzIGRp c2FibGVkIG9yIG5vdAo+Pgo+PiBJdCB3b3VsZCBtYWtlIHNlbnNlIHRvIGVuZCB3aXRoIHRoaXMg ZnVuY3Rpb24gYW5kIGRvIG5vdCBnaXZlIHRoZQo+PiBkaWZmZXJlbnQgZHJpdmVycyBhbiBvcHBv cnR1bml0eSB0byBhY2Nlc3MgdGhpcyBpbmZvcm1hdGlvbi4KPiAKPiBJIGFncmVlLgo+Pgo+PiBX aHkgbm90IGFkZCBjaGFuZ2VfbW9kZSBmb3IgdGhlIGFjcGkgaW4gb3JkZXIgdG8gZW5hYmxlIG9y IGRpc2FibGUKPj4gdGhlCj4+IGV2ZW50cwo+IAo+IHRoZXJtYWxfem9uZV9kZXZpY2VfaXNfZW5h YmxlZCgpIGlzIGludm9rZWQgaW4gYWNwaSB0aGVybWFsIGRyaXZlcgo+IGJlY2F1c2Ugd2Ugb25s eSB3YW50IHRvIGRvIHRoZXJtYWxfem9uZV9kZXZpY2VfdXBkYXRlKCkgd2hlbiB0aGUgYWNwaQo+ IHRoZXJtYWwgem9uZSBpcyBlbmFibGVkLgo+IAo+IEFzIHRoZXJtYWxfem9uZV9kZXZpY2VfdXBk YXRlKCkgY2FuIGhhbmRsZSBhIGRpc2FibGVkIHRoZXJtYWwgem9uZSBub3csCj4gd2UgY2FuIGp1 c3QgcmVtb3ZlIHRoZSBjaGVjay4KCkFoIHllcywgZ29vZCBwb2ludCEKCgoKLS0gCjxodHRwOi8v d3d3LmxpbmFyby5vcmcvPiBMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3Ig QVJNIFNvQ3MKCkZvbGxvdyBMaW5hcm86ICA8aHR0cDovL3d3dy5mYWNlYm9vay5jb20vcGFnZXMv TGluYXJvPiBGYWNlYm9vayB8CjxodHRwOi8vdHdpdHRlci5jb20vIyEvbGluYXJvb3JnPiBUd2l0 dGVyIHwKPGh0dHA6Ly93d3cubGluYXJvLm9yZy9saW5hcm8tYmxvZy8+IEJsb2cKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK