From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBA5AC432BE for ; Fri, 30 Jul 2021 16:05:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9517660EBC for ; Fri, 30 Jul 2021 16:05:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229479AbhG3QFz (ORCPT ); Fri, 30 Jul 2021 12:05:55 -0400 Received: from smtp-relay-canonical-1.canonical.com ([185.125.188.121]:38674 "EHLO smtp-relay-canonical-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbhG3QFy (ORCPT ); Fri, 30 Jul 2021 12:05:54 -0400 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id 444D13F23E for ; Fri, 30 Jul 2021 16:05:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1627661148; bh=ckOz90kE72EEodkfysirBp4bfPPhomkbsSq4zFCD8p4=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=ivOSwVeQ0XHeXJBn214ExMBSMaX2KvjrEqvC+7lTcxGxtfWL13XYfOQpgoFMqebyL lKFXypmXXtKLme757tve6gpoWOI7zOxyYNZgqjALJxUvxOtTabZIWt4GCV8pH9pGNr uH5TNdRyTINpmfX10QPA19OX2vYHPuTv2CtnFEes1iwLWMSsQiahHYyvamYA6K9VkG JCF73vvZFCBmbl3EWPkbfzNPMXxtMj5mOxerhiQyBn4IsPLzPQ1lDzlub4DfgPLPZr gv6YGzFsgOfDfMMAKTIXQdBY4PqKp7vH4tAPYitmmTgV5nXROYHrlFZ7jdbzpufSZT jbATtbenVqPVg== Received: by mail-ed1-f69.google.com with SMTP id x1-20020a05640218c1b02903bc7f97f858so3229929edy.2 for ; Fri, 30 Jul 2021 09:05:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ckOz90kE72EEodkfysirBp4bfPPhomkbsSq4zFCD8p4=; b=WZD2nNcanPgikB9YCnz6YySNDuvvTh0qctenk7B9M2YZxrAyPIgmBgtEepl9kfnzHj 5sLQQ9CIAB/dZEcBdWN0U4xsuxi82ZBph+CpPpiRLc8enzEI/Fdx38JtqW32hE5FgC/z KYvDvHjQuKFzU1ufLmtHYVH/RFztJPTLCzH1QKhF/C1oTXMktLQLYmb33O7fnXIuelOv Qqd0an76gB0agOt8M2plAvBqhgsbqwmWcz/E9Tbx//r4/BB1/TOvlnTXNl+xHWI7/pxv s5M/bxvvA39klirekEWb2WO5QT+KMLA/HXMpKh6IBCzfo8b+hxGUqHd8/tcaNYLkHcr7 UHcA== X-Gm-Message-State: AOAM532A4PB4XTvdphuXeIYKfIw62osi1ncr0TL725NSf3xddQOHA9sS jjksMnUz02itnz/YQe7KY671VJNXHlHQdCCgHXfNWSmiG5FOU7K+fpk51TnyD2pK7TfZ+5JwaAz 17MJvyyp6OVZBsqN4RN3n/eTTSg6p0ZKx7Z5t1Yc= X-Received: by 2002:a17:906:c0cd:: with SMTP id bn13mr3270809ejb.251.1627661145662; Fri, 30 Jul 2021 09:05:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7c3uXOvkRzFd+EjfGwOi9GkfnP6xyPWeV21oXtz+M8LxzO4q9ZXaaXNPEO6I0wjp44bYNLA== X-Received: by 2002:a17:906:c0cd:: with SMTP id bn13mr3270781ejb.251.1627661145512; Fri, 30 Jul 2021 09:05:45 -0700 (PDT) Received: from [192.168.8.102] ([86.32.47.9]) by smtp.gmail.com with ESMTPSA id b3sm697246ejb.7.2021.07.30.09.05.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jul 2021 09:05:45 -0700 (PDT) Subject: Re: [PATCH 06/12] tty: serial: samsung: Add Exynos850 SoC data To: Sam Protsenko , Sylwester Nawrocki , Chanwoo Choi , Linus Walleij , Tomasz Figa Cc: Rob Herring , Stephen Boyd , Michael Turquette , Jiri Slaby , Greg Kroah-Hartman , Charles Keepax , Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org References: <20210730144922.29111-1-semen.protsenko@linaro.org> <20210730144922.29111-7-semen.protsenko@linaro.org> From: Krzysztof Kozlowski Message-ID: <5826bc3e-e9e8-a9bb-4541-21c1b944a60e@canonical.com> Date: Fri, 30 Jul 2021 18:05:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210730144922.29111-7-semen.protsenko@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 30/07/2021 16:49, Sam Protsenko wrote: > Add serial driver data for Exynos850 SoC. This driver data is basically > reusing EXYNOS_COMMON_SERIAL_DRV_DATA, which is common for all Exynos > chips, but also enables USI init, which was added in previous commit: > "tty: serial: samsung: Init USI to keep clocks running". > > Signed-off-by: Sam Protsenko > --- > drivers/tty/serial/samsung_tty.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > index 75ccbb08df4a..d059b516a0f4 100644 > --- a/drivers/tty/serial/samsung_tty.c > +++ b/drivers/tty/serial/samsung_tty.c > @@ -2814,11 +2814,19 @@ static struct s3c24xx_serial_drv_data exynos5433_serial_drv_data = { > .fifosize = { 64, 256, 16, 256 }, > }; > > +static struct s3c24xx_serial_drv_data exynos850_serial_drv_data = { > + EXYNOS_COMMON_SERIAL_DRV_DATA_USI(1), > + .fifosize = { 0, }, This does not look correct. You rely on samsung,uart-fifosize property but it is optional. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7539BC4338F for ; Fri, 30 Jul 2021 16:07:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4883160EE6 for ; Fri, 30 Jul 2021 16:07:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4883160EE6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=f8csodEz1k14mZbk4MqX+Se7fSQYxDDDJR0nhfS8PGM=; b=TD5Wq7g4Qj/JKUEHDcNOJidkPt FsjCP7wfVTOY/ZMWz7Hgw/tCVAaLJHLHf/v7GWWUGsgpsZsfaWFuwOl4CVQr/2js6KmH51rtydiiJ J0wF9vP+Gy1wSKhNsndD5mQGGALebOtEfmUtTG3aaW1hLaXijLL0/mjUw/Q4nqGSdmqrgQo0JQYw2 Akjhf59Jt/N3x0bTnJcq9rU96UOXRJQm+Fi8NF7W6y4DfOjbyIwDJCH1yQdiDjsBZXS+5+pV1aDdn 06PId609CwH3cV0B+2s5V8/jrExI1Ts13ivuklom9qKmQ/bJy3zpL5beyt75zZLh3xomvi8WjzcKL qtuw5GWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9V1D-009RuD-4W; Fri, 30 Jul 2021 16:05:51 +0000 Received: from smtp-relay-canonical-0.canonical.com ([185.125.188.120]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9V19-009RtM-7f for linux-arm-kernel@lists.infradead.org; Fri, 30 Jul 2021 16:05:48 +0000 Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPS id E02913F09F for ; Fri, 30 Jul 2021 16:05:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1627661145; bh=ckOz90kE72EEodkfysirBp4bfPPhomkbsSq4zFCD8p4=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=YeafcFk5Rpcbsiitge9MBhm8FBX8bRSwWJwIVe+zwoy+alWj9gDjRIm+tFQDcmw7o WhkSpWJkfauP6GE7pPycyw7WQaN3SGq8EQSlkoYs51Qc/teYd4l8sCJg0ZBFoDFzHp L/iBxpXBVQ9z+YGFPK86hQfPZbLrZrfdzIRVTHYnN5X9i7e9naiADVTvPCFohJNfjs Eet8p6N3ANVeWMcp+OZhWiPnwL0ZWvBlbVLRO8khz1tFJDeLNNe3BxK65iHvoJswHC icFyRTHxWGrgLRiCP0C8Lu8B8aXNT8bA3Po1m9gBc0QdoMKGHEQYfyd03WKq5Xo46u T125kHGsSXxsQ== Received: by mail-ej1-f71.google.com with SMTP id ci25-20020a1709072679b029058e79f6c38aso2942487ejc.13 for ; Fri, 30 Jul 2021 09:05:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ckOz90kE72EEodkfysirBp4bfPPhomkbsSq4zFCD8p4=; b=mMRVXZTThgxRsCPX34JdncE2LNCcQdgcadCgacqHOhlkwi59Uvf88LSmRt/cTSuy7Y +JTY7Ue2YK42WWs1httqMoufmZf4D+GiZKSK7DYHJz7lK1duhg2CQhw+REMsCdYclASM EHsQr2FWHks//m/A5L9grrssj26ETuKpgZeTMLn2PZVM/TeP6wWZXIDbKUYKWJywT6+r eCtcjePdbVKpHSPk7gypUz8sq8L3Xe1cZxneRUGelcwulgSZAy8HyAULJP75jFJI8VDd GY8vgnVBJhgzlh9ZzIkI5pcrtW8P4mzk0HplXbqhBLqHLiNZV9hvp2l490gAQayXAXmD xhMQ== X-Gm-Message-State: AOAM531owabmGl69HQoOEoHLAHsTrB1bKw11s/FDM2XedLAfJUGIEmqS 47+JF0avdVDot/8QVwScwtIsIJ1RxUi0BbUGsy1PKEKfVajUUemrZX1+MTGr2OlnyVdvO8gHGZ2 brCuHG1z3hsVVjJKZu1J5pyoDPlzprPCg8PWuFWzS69PLa2oGSXKK X-Received: by 2002:a17:906:c0cd:: with SMTP id bn13mr3270798ejb.251.1627661145660; Fri, 30 Jul 2021 09:05:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7c3uXOvkRzFd+EjfGwOi9GkfnP6xyPWeV21oXtz+M8LxzO4q9ZXaaXNPEO6I0wjp44bYNLA== X-Received: by 2002:a17:906:c0cd:: with SMTP id bn13mr3270781ejb.251.1627661145512; Fri, 30 Jul 2021 09:05:45 -0700 (PDT) Received: from [192.168.8.102] ([86.32.47.9]) by smtp.gmail.com with ESMTPSA id b3sm697246ejb.7.2021.07.30.09.05.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jul 2021 09:05:45 -0700 (PDT) Subject: Re: [PATCH 06/12] tty: serial: samsung: Add Exynos850 SoC data To: Sam Protsenko , Sylwester Nawrocki , Chanwoo Choi , Linus Walleij , Tomasz Figa Cc: Rob Herring , Stephen Boyd , Michael Turquette , Jiri Slaby , Greg Kroah-Hartman , Charles Keepax , Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org References: <20210730144922.29111-1-semen.protsenko@linaro.org> <20210730144922.29111-7-semen.protsenko@linaro.org> From: Krzysztof Kozlowski Message-ID: <5826bc3e-e9e8-a9bb-4541-21c1b944a60e@canonical.com> Date: Fri, 30 Jul 2021 18:05:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210730144922.29111-7-semen.protsenko@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210730_090547_588137_567DF0B4 X-CRM114-Status: GOOD ( 19.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30/07/2021 16:49, Sam Protsenko wrote: > Add serial driver data for Exynos850 SoC. This driver data is basically > reusing EXYNOS_COMMON_SERIAL_DRV_DATA, which is common for all Exynos > chips, but also enables USI init, which was added in previous commit: > "tty: serial: samsung: Init USI to keep clocks running". > > Signed-off-by: Sam Protsenko > --- > drivers/tty/serial/samsung_tty.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > index 75ccbb08df4a..d059b516a0f4 100644 > --- a/drivers/tty/serial/samsung_tty.c > +++ b/drivers/tty/serial/samsung_tty.c > @@ -2814,11 +2814,19 @@ static struct s3c24xx_serial_drv_data exynos5433_serial_drv_data = { > .fifosize = { 64, 256, 16, 256 }, > }; > > +static struct s3c24xx_serial_drv_data exynos850_serial_drv_data = { > + EXYNOS_COMMON_SERIAL_DRV_DATA_USI(1), > + .fifosize = { 0, }, This does not look correct. You rely on samsung,uart-fifosize property but it is optional. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel