From: Jacob Keller <jacob.e.keller@intel.com>
To: Michael Chan <michael.chan@broadcom.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: Vasundhara Volam <vasundhara-v.volam@broadcom.com>,
David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v3 net-next 1/5] devlink: Add macro for "fw.api" to info_get cb.
Date: Thu, 26 Mar 2020 16:39:31 -0700 [thread overview]
Message-ID: <582ed17d-8776-2f83-413c-37cf132c5e59@intel.com> (raw)
In-Reply-To: <CACKFLimJORgp2kmRLgZHWLY9E1DsbD8CSf+=9A-_DQhQG8kbqg@mail.gmail.com>
On 3/26/2020 4:09 PM, Michael Chan wrote:
> On Thu, Mar 26, 2020 at 1:40 PM Jakub Kicinski <kuba@kernel.org> wrote:
>>
>> On Thu, 26 Mar 2020 17:32:34 +0530 Vasundhara Volam wrote:
>>> Add definition and documentation for the new generic info "fw.api".
>>> "fw.api" specifies the version of the software interfaces between
>>> driver and overall firmware.
>>>
>>> Cc: Jakub Kicinski <kuba@kernel.org>
>>> Cc: Jacob Keller <jacob.e.keller@intel.com>
>>> Reviewed-by: Jiri Pirko <jiri@mellanox.com>
>>> Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
>>> Signed-off-by: Michael Chan <michael.chan@broadcom.com>
>>> ---
>>> v1->v2: Rename macro to "fw.api" from "drv.spec".
>>
>> I suggested "fw.mgmt.api", like Intel has. What else those this API
>> number covers beyond management? Do you negotiated descriptor formats
>> for the datapath?
>
> To us, "management" firmware usually means firmware such as IPMI that
> interfaces with the BMC. Here, we're trying to convey the API between
> the driver and the main firmware. Yes, this main firmware also
> "manages" things such as rings, MAC, the physical port, etc. But
> again, we want to distinguish it from the platform management type of
> firmware.
>
Documentation for "fw.mgmt":
fw.mgmt
-------
Control unit firmware version. This firmware is responsible for house
keeping tasks, PHY control etc. but not the packet-by-packet data path
operation.
To me, platform management would need a new name, as the term "fw.mgmt"
has already been used by multiple drivers.
Thanks,
Jake
next prev parent reply other threads:[~2020-03-26 23:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 12:02 [PATCH v3 net-next 0/5] bnxt_en: Updates to devlink info_get cb Vasundhara Volam
2020-03-26 12:02 ` [PATCH v3 net-next 1/5] devlink: Add macro for "fw.api" to " Vasundhara Volam
2020-03-26 20:40 ` Jakub Kicinski
2020-03-26 23:09 ` Michael Chan
2020-03-26 23:39 ` Jacob Keller [this message]
2020-03-26 23:51 ` Jakub Kicinski
2020-03-26 12:02 ` [PATCH v3 net-next 2/5] bnxt_en: Add fw.api version to devlink " Vasundhara Volam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=582ed17d-8776-2f83-413c-37cf132c5e59@intel.com \
--to=jacob.e.keller@intel.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vasundhara-v.volam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.