From: "Jan Beulich" <JBeulich@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: wei.liu2@citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
Paul Durrant <paul.durrant@citrix.com>,
roger.pau@citrix.com
Subject: Re: [PATCH v3 02/11] acpi: Define ACPI IO registers for PVH guests
Date: Tue, 22 Nov 2016 03:37:39 -0700 [thread overview]
Message-ID: <58342E030200007800120975@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1479762047-29431-3-git-send-email-boris.ostrovsky@oracle.com>
>>> On 21.11.16 at 22:00, <boris.ostrovsky@oracle.com> wrote:
> @@ -119,11 +122,33 @@ typedef struct buffered_iopage buffered_iopage_t;
>
> /* Compatibility definitions for the default location (version 0). */
> #define ACPI_PM1A_EVT_BLK_ADDRESS ACPI_PM1A_EVT_BLK_ADDRESS_V0
> +#define ACPI_PM1A_EVT_BLK_LEN 0x04
> +#define ACPI_PM1A_EVT_BLK_BIT_OFFSET 0x00
> #define ACPI_PM1A_CNT_BLK_ADDRESS ACPI_PM1A_CNT_BLK_ADDRESS_V0
> +#define ACPI_PM1A_CNT_BLK_LEN 0x02
> +#define ACPI_PM1A_CNT_BLK_BIT_OFFSET 0x00
> #define ACPI_PM_TMR_BLK_ADDRESS ACPI_PM_TMR_BLK_ADDRESS_V0
> +#define ACPI_PM_TMR_BLK_LEN 0x04
> +#define ACPI_PM_TMR_BLK_BIT_OFFSET 0x00
> #define ACPI_GPE0_BLK_ADDRESS ACPI_GPE0_BLK_ADDRESS_V0
> #define ACPI_GPE0_BLK_LEN ACPI_GPE0_BLK_LEN_V0
>
> +#if __XEN_INTERFACE_VERSION__ >= 0x00040800
> +#if defined(__XEN__) || defined(__XEN_TOOLS__)
> +
> +/* Location of online VCPU bitmap. */
> +#define XEN_ACPI_CPU_MAP 0xaf00
> +#define XEN_ACPI_CPU_MAP_LEN ((HVM_MAX_VCPUS + 7) / 8)
> +
> +#if XEN_ACPI_CPU_MAP + XEN_ACPI_CPU_MAP_LEN >= ACPI_GPE0_BLK_ADDRESS_V1
> +#error "XEN_ACPI_CPU_MAP is too big"
> +#endif
> +
> +/* GPE0 bit set during CPU hotplug */
> +#define XEN_GPE0_CPUHP_BIT 2
> +
> +#endif /* defined(__XEN__) || defined(__XEN_TOOLS__) */
> +#endif /* __XEN_INTERFACE_VERSION__ >= 0x00040800 */
>
> #endif /* _IOREQ_H_ */
I'm afraid there's been some misunderstanding here during the v2
discussion: New hypervisor/tools only definitions don't need an
additional interface version guard. It's instead the pre-existing
ones which should be removed from the namespace by adding
such a guard.
And of course _everything_ being added here anew needs to be
XEN_ prefixed and guarded.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-11-22 10:37 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 21:00 [PATCH v3 00/11] PVH VCPU hotplug support Boris Ostrovsky
2016-11-21 21:00 ` [PATCH v3 01/11] x86/domctl: Add XEN_DOMCTL_set_avail_vcpus Boris Ostrovsky
2016-11-22 10:31 ` Jan Beulich
2016-11-22 10:39 ` Jan Beulich
2016-11-22 12:34 ` Boris Ostrovsky
2016-11-22 13:59 ` Jan Beulich
2016-11-22 14:37 ` Boris Ostrovsky
2016-11-22 15:07 ` Jan Beulich
2016-11-22 15:43 ` Boris Ostrovsky
2016-11-22 16:01 ` Jan Beulich
[not found] ` <a4ac4c28-833b-df5f-ce34-1fa72f7c4cd2@oracle.com>
2016-11-22 23:47 ` Boris Ostrovsky
2016-11-23 8:09 ` Jan Beulich
2016-11-23 13:33 ` Boris Ostrovsky
2016-11-23 13:58 ` Jan Beulich
2016-11-23 14:16 ` Boris Ostrovsky
2016-11-25 18:16 ` Boris Ostrovsky
2016-11-28 7:59 ` Jan Beulich
2016-11-22 12:19 ` Boris Ostrovsky
2016-11-21 21:00 ` [PATCH v3 02/11] acpi: Define ACPI IO registers for PVH guests Boris Ostrovsky
2016-11-22 10:37 ` Jan Beulich [this message]
2016-11-22 12:28 ` Boris Ostrovsky
2016-11-22 14:07 ` Jan Beulich
2016-11-22 14:53 ` Boris Ostrovsky
2016-11-22 15:13 ` Jan Beulich
2016-11-22 15:52 ` Boris Ostrovsky
2016-11-22 16:02 ` Jan Beulich
2016-11-21 21:00 ` [PATCH v3 03/11] pvh: Set online VCPU map to avail_vcpus Boris Ostrovsky
2016-11-21 21:00 ` [PATCH v3 04/11] acpi: Make pmtimer optional in FADT Boris Ostrovsky
2016-11-21 21:00 ` [PATCH v3 05/11] acpi: Power and Sleep ACPI buttons are not emulated for PVH guests Boris Ostrovsky
2016-11-21 21:00 ` [PATCH v3 06/11] acpi: PVH guests need _E02 method Boris Ostrovsky
2016-11-22 9:13 ` Jan Beulich
2016-11-22 20:20 ` Konrad Rzeszutek Wilk
2016-11-21 21:00 ` [PATCH v3 07/11] pvh/ioreq: Install handlers for ACPI-related PVH IO accesses Boris Ostrovsky
2016-11-22 11:34 ` Jan Beulich
2016-11-22 12:38 ` Boris Ostrovsky
2016-11-22 14:08 ` Jan Beulich
2016-11-28 15:16 ` Boris Ostrovsky
2016-11-28 15:48 ` Roger Pau Monné
2016-11-21 21:00 ` [PATCH v3 08/11] pvh/acpi: Handle ACPI accesses for PVH guests Boris Ostrovsky
2016-11-22 14:11 ` Paul Durrant
2016-11-22 15:01 ` Jan Beulich
2016-11-22 15:30 ` Boris Ostrovsky
2016-11-22 16:05 ` Jan Beulich
2016-11-22 16:33 ` Boris Ostrovsky
2016-11-21 21:00 ` [PATCH v3 09/11] events/x86: Define SCI virtual interrupt Boris Ostrovsky
2016-11-22 15:25 ` Jan Beulich
2016-11-22 15:57 ` Boris Ostrovsky
2016-11-22 16:07 ` Jan Beulich
2016-11-21 21:00 ` [PATCH v3 10/11] pvh: Send an SCI on VCPU hotplug event Boris Ostrovsky
2016-11-22 15:32 ` Jan Beulich
2016-11-21 21:00 ` [PATCH v3 11/11] docs: Describe PVHv2's VCPU hotplug procedure Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58342E030200007800120975@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=paul.durrant@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.