From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9Tnm-0003Qi-M0 for qemu-devel@nongnu.org; Wed, 23 Nov 2016 04:25:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9Tnj-00066W-HE for qemu-devel@nongnu.org; Wed, 23 Nov 2016 04:25:14 -0500 Received: from prv-mh.provo.novell.com ([137.65.248.74]:44902) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c9Tnj-000660-7t for qemu-devel@nongnu.org; Wed, 23 Nov 2016 04:25:11 -0500 Message-Id: <58356E83020000780012129C@prv-mh.provo.novell.com> Date: Wed, 23 Nov 2016 02:25:07 -0700 From: "Jan Beulich" References: <58356D610200007800121289@prv-mh.provo.novell.com> In-Reply-To: <58356D610200007800121289@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Subject: [Qemu-devel] [PATCH 3/3] xen: ignore direction in bufioreq handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: anthony.perard@citrix.com, Paul Durrant , Stefano Stabellini , xen-devel There's no way to communicate back read data, so only writes can ever be usefully specified. Ignore the field, paving the road for eventually re-using the bit for something else in a few (many?) years time. Signed-off-by: Jan Beulich --- a/xen-hvm.c +++ b/xen-hvm.c @@ -997,6 +997,7 @@ static int handle_buffered_iopage(XenIOS memset(&req, 0x00, sizeof(req)); req.state =3D STATE_IOREQ_READY; req.count =3D 1; + req.dir =3D IOREQ_WRITE; =20 for (;;) { uint32_t rdptr =3D buf_page->read_pointer, wrptr; @@ -1014,7 +1015,6 @@ static int handle_buffered_iopage(XenIOS req.size =3D 1U << buf_req->size; req.addr =3D buf_req->addr; req.data =3D buf_req->data; - req.dir =3D buf_req->dir; req.type =3D buf_req->type; xen_rmb(); qw =3D (req.size =3D=3D 8); @@ -1031,10 +1031,12 @@ static int handle_buffered_iopage(XenIOS handle_ioreq(state, &req); =20 /* Only req.data may get updated by handle_ioreq(), albeit even = that - * should not happen as such data would never make it to the = guest. + * should not happen as such data would never make it to the = guest (we + * can only usefully see writes here after all). */ assert(req.state =3D=3D STATE_IOREQ_READY); assert(req.count =3D=3D 1); + assert(req.dir =3D=3D IOREQ_WRITE); assert(!req.data_is_ptr); =20 atomic_add(&buf_page->read_pointer, qw + 1); From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: [PATCH 3/3] xen: ignore direction in bufioreq handling Date: Wed, 23 Nov 2016 02:25:07 -0700 Message-ID: <58356E83020000780012129C@prv-mh.provo.novell.com> References: <58356D610200007800121289@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9Tnm-0000vt-5T for xen-devel@lists.xenproject.org; Wed, 23 Nov 2016 09:25:14 +0000 In-Reply-To: <58356D610200007800121289@prv-mh.provo.novell.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: qemu-devel@nongnu.org Cc: anthony.perard@citrix.com, xen-devel , Paul Durrant , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org VGhlcmUncyBubyB3YXkgdG8gY29tbXVuaWNhdGUgYmFjayByZWFkIGRhdGEsIHNvIG9ubHkgd3Jp dGVzIGNhbiBldmVyCmJlIHVzZWZ1bGx5IHNwZWNpZmllZC4gSWdub3JlIHRoZSBmaWVsZCwgcGF2 aW5nIHRoZSByb2FkIGZvciBldmVudHVhbGx5CnJlLXVzaW5nIHRoZSBiaXQgZm9yIHNvbWV0aGlu ZyBlbHNlIGluIGEgZmV3IChtYW55PykgeWVhcnMgdGltZS4KClNpZ25lZC1vZmYtYnk6IEphbiBC ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KCi0tLSBhL3hlbi1odm0uYworKysgYi94ZW4taHZt LmMKQEAgLTk5Nyw2ICs5OTcsNyBAQCBzdGF0aWMgaW50IGhhbmRsZV9idWZmZXJlZF9pb3BhZ2Uo WGVuSU9TCiAgICAgbWVtc2V0KCZyZXEsIDB4MDAsIHNpemVvZihyZXEpKTsKICAgICByZXEuc3Rh dGUgPSBTVEFURV9JT1JFUV9SRUFEWTsKICAgICByZXEuY291bnQgPSAxOworICAgIHJlcS5kaXIg PSBJT1JFUV9XUklURTsKIAogICAgIGZvciAoOzspIHsKICAgICAgICAgdWludDMyX3QgcmRwdHIg PSBidWZfcGFnZS0+cmVhZF9wb2ludGVyLCB3cnB0cjsKQEAgLTEwMTQsNyArMTAxNSw2IEBAIHN0 YXRpYyBpbnQgaGFuZGxlX2J1ZmZlcmVkX2lvcGFnZShYZW5JT1MKICAgICAgICAgcmVxLnNpemUg PSAxVSA8PCBidWZfcmVxLT5zaXplOwogICAgICAgICByZXEuYWRkciA9IGJ1Zl9yZXEtPmFkZHI7 CiAgICAgICAgIHJlcS5kYXRhID0gYnVmX3JlcS0+ZGF0YTsKLSAgICAgICAgcmVxLmRpciA9IGJ1 Zl9yZXEtPmRpcjsKICAgICAgICAgcmVxLnR5cGUgPSBidWZfcmVxLT50eXBlOwogICAgICAgICB4 ZW5fcm1iKCk7CiAgICAgICAgIHF3ID0gKHJlcS5zaXplID09IDgpOwpAQCAtMTAzMSwxMCArMTAz MSwxMiBAQCBzdGF0aWMgaW50IGhhbmRsZV9idWZmZXJlZF9pb3BhZ2UoWGVuSU9TCiAgICAgICAg IGhhbmRsZV9pb3JlcShzdGF0ZSwgJnJlcSk7CiAKICAgICAgICAgLyogT25seSByZXEuZGF0YSBt YXkgZ2V0IHVwZGF0ZWQgYnkgaGFuZGxlX2lvcmVxKCksIGFsYmVpdCBldmVuIHRoYXQKLSAgICAg ICAgICogc2hvdWxkIG5vdCBoYXBwZW4gYXMgc3VjaCBkYXRhIHdvdWxkIG5ldmVyIG1ha2UgaXQg dG8gdGhlIGd1ZXN0LgorICAgICAgICAgKiBzaG91bGQgbm90IGhhcHBlbiBhcyBzdWNoIGRhdGEg d291bGQgbmV2ZXIgbWFrZSBpdCB0byB0aGUgZ3Vlc3QgKHdlCisgICAgICAgICAqIGNhbiBvbmx5 IHVzZWZ1bGx5IHNlZSB3cml0ZXMgaGVyZSBhZnRlciBhbGwpLgogICAgICAgICAgKi8KICAgICAg ICAgYXNzZXJ0KHJlcS5zdGF0ZSA9PSBTVEFURV9JT1JFUV9SRUFEWSk7CiAgICAgICAgIGFzc2Vy dChyZXEuY291bnQgPT0gMSk7CisgICAgICAgIGFzc2VydChyZXEuZGlyID09IElPUkVRX1dSSVRF KTsKICAgICAgICAgYXNzZXJ0KCFyZXEuZGF0YV9pc19wdHIpOwogCiAgICAgICAgIGF0b21pY19h ZGQoJmJ1Zl9wYWdlLT5yZWFkX3BvaW50ZXIsIHF3ICsgMSk7CgoKCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhl bi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK