All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: anthony.perard@citrix.com,
	xen-devel <xen-devel@lists.xenproject.org>,
	Paul Durrant <paul.durrant@citrix.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH 2/3] xen: slightly simplify bufioreq handling
Date: Thu, 24 Nov 2016 03:31:03 -0700	[thread overview]
Message-ID: <5836CF770200007800121986__11070.724661886$1479983522$gmane$org@prv-mh.provo.novell.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1611231012340.21858@sstabellini-ThinkPad-X260>

>>> On 23.11.16 at 19:13, <sstabellini@kernel.org> wrote:
> On Wed, 23 Nov 2016, Jan Beulich wrote:
>> There's no point setting fields always receiving the same value on each
>> iteration, as handle_ioreq() doesn't alter them anyway. Set state and
>> count once ahead of the loop, drop the redundant clearing of
>> data_is_ptr, and avoid the meaningless setting of df altogether.
> 
> Why setting df is meaningless?

With count being fixed to one there's no need to update addresses,
and hence no use for knowing which direction the updates should go.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-11-24 10:31 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23  9:20 [Qemu-devel] [PATCH 0/3] xen: XSA-197 follow-ups Jan Beulich
2016-11-23  9:24 ` [PATCH 1/3] xen: fix quad word bufioreq handling Jan Beulich
2016-11-23  9:24 ` [Qemu-devel] " Jan Beulich
2016-11-23  9:48   ` Paul Durrant
2016-11-23 10:36     ` Jan Beulich
2016-11-23 10:36     ` [Qemu-devel] " Jan Beulich
2016-11-23 10:45       ` Paul Durrant
2016-11-23 11:28         ` Jan Beulich
2016-11-23 11:28         ` [Qemu-devel] " Jan Beulich
2016-11-23 18:01           ` Stefano Stabellini
2016-11-23 18:01             ` Stefano Stabellini
2016-11-23 10:45       ` Paul Durrant
2016-11-23  9:48   ` Paul Durrant
2016-11-23  9:24 ` [Qemu-devel] [PATCH 2/3] xen: slightly simplify " Jan Beulich
2016-11-23  9:24   ` Jan Beulich
2016-11-23  9:51   ` [Qemu-devel] " Paul Durrant
2016-11-23  9:51     ` Paul Durrant
2016-11-23 18:13   ` Stefano Stabellini
2016-11-23 18:13   ` [Qemu-devel] " Stefano Stabellini
2016-11-24 10:31     ` Jan Beulich
2016-11-24 10:31     ` Jan Beulich [this message]
2016-11-23  9:25 ` [Qemu-devel] [PATCH 3/3] xen: ignore direction in " Jan Beulich
2016-11-23  9:25   ` Jan Beulich
2016-11-23  9:55   ` [Qemu-devel] " Paul Durrant
2016-11-23  9:55     ` Paul Durrant
2016-11-23 18:16     ` Stefano Stabellini
2016-11-23 18:16     ` [Qemu-devel] " Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='5836CF770200007800121986__11070.724661886$1479983522$gmane$org@prv-mh.provo.novell.com' \
    --to=jbeulich@suse.com \
    --cc=anthony.perard@citrix.com \
    --cc=paul.durrant@citrix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.