From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935105AbdACNO5 (ORCPT ); Tue, 3 Jan 2017 08:14:57 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:60433 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935088AbdACNOp (ORCPT ); Tue, 3 Jan 2017 08:14:45 -0500 Subject: Re: [PATCH 4/4] arm64: dts: exynos: Add tm2 touchkey node To: Jaechul Lee , Dmitry Torokhov , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Kukjin Kim , Krzysztof Kozlowski References: <1483430237-26823-1-git-send-email-jcsing.lee@samsung.com> <1483430237-26823-5-git-send-email-jcsing.lee@samsung.com> Cc: Andi Shyti , Chanwoo Choi , beomho.seo@samsung.com, galaxyra@gmail.com, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org From: Javier Martinez Canillas Message-ID: <58437de5-a837-9b34-da30-f8bc911b0854@osg.samsung.com> Date: Tue, 3 Jan 2017 10:14:34 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1483430237-26823-5-git-send-email-jcsing.lee@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Jaechul, On 01/03/2017 04:57 AM, Jaechul Lee wrote: > Add DT node support for TM2 touchkey device. > > Signed-off-by: Jaechul Lee > Signed-off-by: Beomho Seo > Signed-off-by: Andi Shyti > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > index 887a1f1..ef7d21c 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > @@ -18,3 +18,15 @@ > compatible = "samsung,tm2e", "samsung,exynos5433"; > }; > > +&hsi2c_9 { > + status = "okay"; > + > + touchkey@20 { > + compatible = "samsung,tm2-touchkey"; > + reg = <0x20>; > + interrupt-parent = <&gpa3>; > + interrupts = <2 IRQ_TYPE_EDGE_FALLING>; > + vcc-supply = <&ldo32_reg>; > + vdd-supply = <&ldo33_reg>; > + }; > +}; > If you re-spin with the changes suggested by Chanwoo instead of the commont .dtsi, feel free to add: Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America From mboxrd@z Thu Jan 1 00:00:00 1970 From: javier@osg.samsung.com (Javier Martinez Canillas) Date: Tue, 3 Jan 2017 10:14:34 -0300 Subject: [PATCH 4/4] arm64: dts: exynos: Add tm2 touchkey node In-Reply-To: <1483430237-26823-5-git-send-email-jcsing.lee@samsung.com> References: <1483430237-26823-1-git-send-email-jcsing.lee@samsung.com> <1483430237-26823-5-git-send-email-jcsing.lee@samsung.com> Message-ID: <58437de5-a837-9b34-da30-f8bc911b0854@osg.samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Jaechul, On 01/03/2017 04:57 AM, Jaechul Lee wrote: > Add DT node support for TM2 touchkey device. > > Signed-off-by: Jaechul Lee > Signed-off-by: Beomho Seo > Signed-off-by: Andi Shyti > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > index 887a1f1..ef7d21c 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > @@ -18,3 +18,15 @@ > compatible = "samsung,tm2e", "samsung,exynos5433"; > }; > > +&hsi2c_9 { > + status = "okay"; > + > + touchkey at 20 { > + compatible = "samsung,tm2-touchkey"; > + reg = <0x20>; > + interrupt-parent = <&gpa3>; > + interrupts = <2 IRQ_TYPE_EDGE_FALLING>; > + vcc-supply = <&ldo32_reg>; > + vdd-supply = <&ldo33_reg>; > + }; > +}; > If you re-spin with the changes suggested by Chanwoo instead of the commont .dtsi, feel free to add: Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America