All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>
To: Michal Hocko <mhocko@suse.cz>, David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Arnd Bergmann <arnd@arndb.de>, "vbabka@suse.cz" <vbabka@suse.cz>,
	"mgorman@suse.de" <mgorman@suse.de>,
	"minchan@kernel.org" <minchan@kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: RE: [PATCH] mm/compaction: Fix warning of 'flags' may be used uninitialized
Date: Thu, 11 Sep 2014 09:27:24 +0000	[thread overview]
Message-ID: <584917bf2134400882e23b62469975d4@BY2PR0301MB0613.namprd03.prod.outlook.com> (raw)
In-Reply-To: <20140911080455.GA22047@dhcp22.suse.cz>

Hi,

> > Arnd Bergmann already sent a patch for this to use uninitialized_var()
> > privately but it didn't get cc'd to any mailing list, sorry.
> 
> Besides that setting flags to 0 is certainly a misleading way to fix
> this issue. uninitialized_var is a correct way because the warning is a
> false possitive. compact_unlock_should_abort will not touch the flags if
> locked is false and this is true only after a lock has been taken and
> flags set. (this should be preferably in the patch description).
> 

Yes, right.

This should be added to the commit comment with the patch.

Thanks,

BRs
Xiubo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2014-09-11  9:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-10  6:12 [PATCH] mm/compaction: Fix warning of 'flags' may be used uninitialized Xiubo Li
2014-09-10 18:50 ` David Rientjes
2014-09-11  8:04   ` Michal Hocko
2014-09-11  9:27     ` Li.Xiubo [this message]
2014-09-11  9:02   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=584917bf2134400882e23b62469975d4@BY2PR0301MB0613.namprd03.prod.outlook.com \
    --to=li.xiubo@freescale.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.cz \
    --cc=minchan@kernel.org \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.