From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752727AbbJORQg (ORCPT ); Thu, 15 Oct 2015 13:16:36 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.218]:45018 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751277AbbJORQe convert rfc822-to-8bit (ORCPT ); Thu, 15 Oct 2015 13:16:34 -0400 X-RZG-AUTH: :JGIXVUS7cutRB/49FwqZ7WcKdUCnXG6JabOfSXKWrat/m8zrzY0= X-RZG-CLASS-ID: mo00 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH v2] ARM: fix vdsomunge not to depend on glibc specific byteswap.h From: "H. Nikolaus Schaller" In-Reply-To: <561FDD58.1020602@mentor.com> Date: Thu, 15 Oct 2015 19:16:27 +0200 Cc: Szabolcs Nagy , Russell King , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, marek@goldelico.com Content-Transfer-Encoding: 8BIT Message-Id: <585048FA-B498-4F84-AC09-642D95D7E8D9@goldelico.com> References: <2039A9BE-ADA4-4D28-84F4-C8B9D76834AD@goldelico.com> <5B19AAFC-976C-4B33-A83E-229693FA7858@goldelico.com> <561E63C9.3040702@mentor.com> <350DE2A3-622F-4624-8AFC-D0F37CCB29EA@goldelico.com> <561FDD58.1020602@mentor.com> To: Nathan Lynch X-Mailer: Apple Mail (2.1878.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 15.10.2015 um 19:07 schrieb Nathan Lynch : > On 10/15/2015 12:52 AM, H. Nikolaus Schaller wrote: >> Am 14.10.2015 um 16:16 schrieb Nathan Lynch : >>> and it would be easier for me to deal with a patch that isn't >>> whitespace-damaged. >> >> You mean: >> >> ERROR: space prohibited before that close parenthesis ')' >> #46: FILE: arch/arm/vdso/vdsomunge.c:64: >> + (((unsigned short)(x) & (unsigned short)0xff00U) >> 8) )) >> >> ERROR: space prohibited before that close parenthesis ')' >> #53: FILE: arch/arm/vdso/vdsomunge.c:71: >> + (((unsigned int)(x) & (unsigned int)0xff000000UL) >> 24) )) >> >> Well, I had copied that verbatim from arch/mips/boot/elf2ecoff.c and >> thought that it is better readable, but it is easy to fix. > > That's not what I was referring to, but it is fine to fix that too. > > What I meant was that the first column of the patch body is corrupted. > Your v2 has hunks like this (bad): > > static Elf32_Word read_elf_word(Elf32_Word word, bool swap) > { > - return swap ? bswap_32(word) : word; > + return swap ? swab32(word) : word; > } > > > Your v3 has this (good): > > static void write_elf_word(Elf32_Word val, Elf32_Word *dst, bool swap) > { > - *dst = swap ? bswap_32(val) : val; > + *dst = swap ? swab32(val) : val; > } Does this mean it is ok now in V3 in all cases? I have switched my patch editor tool from indirect git imap-send to git send-email (which appears to be more compatible). BR and thanks, Nikolaus Schaller From mboxrd@z Thu Jan 1 00:00:00 1970 From: hns@goldelico.com (H. Nikolaus Schaller) Date: Thu, 15 Oct 2015 19:16:27 +0200 Subject: [PATCH v2] ARM: fix vdsomunge not to depend on glibc specific byteswap.h In-Reply-To: <561FDD58.1020602@mentor.com> References: <2039A9BE-ADA4-4D28-84F4-C8B9D76834AD@goldelico.com> <5B19AAFC-976C-4B33-A83E-229693FA7858@goldelico.com> <561E63C9.3040702@mentor.com> <350DE2A3-622F-4624-8AFC-D0F37CCB29EA@goldelico.com> <561FDD58.1020602@mentor.com> Message-ID: <585048FA-B498-4F84-AC09-642D95D7E8D9@goldelico.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am 15.10.2015 um 19:07 schrieb Nathan Lynch : > On 10/15/2015 12:52 AM, H. Nikolaus Schaller wrote: >> Am 14.10.2015 um 16:16 schrieb Nathan Lynch : >>> and it would be easier for me to deal with a patch that isn't >>> whitespace-damaged. >> >> You mean: >> >> ERROR: space prohibited before that close parenthesis ')' >> #46: FILE: arch/arm/vdso/vdsomunge.c:64: >> + (((unsigned short)(x) & (unsigned short)0xff00U) >> 8) )) >> >> ERROR: space prohibited before that close parenthesis ')' >> #53: FILE: arch/arm/vdso/vdsomunge.c:71: >> + (((unsigned int)(x) & (unsigned int)0xff000000UL) >> 24) )) >> >> Well, I had copied that verbatim from arch/mips/boot/elf2ecoff.c and >> thought that it is better readable, but it is easy to fix. > > That's not what I was referring to, but it is fine to fix that too. > > What I meant was that the first column of the patch body is corrupted. > Your v2 has hunks like this (bad): > > static Elf32_Word read_elf_word(Elf32_Word word, bool swap) > { > - return swap ? bswap_32(word) : word; > + return swap ? swab32(word) : word; > } > > > Your v3 has this (good): > > static void write_elf_word(Elf32_Word val, Elf32_Word *dst, bool swap) > { > - *dst = swap ? bswap_32(val) : val; > + *dst = swap ? swab32(val) : val; > } Does this mean it is ok now in V3 in all cases? I have switched my patch editor tool from indirect git imap-send to git send-email (which appears to be more compatible). BR and thanks, Nikolaus Schaller