From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S936030AbcLTPMf (ORCPT <rfc822;w@1wt.eu>);
        Tue, 20 Dec 2016 10:12:35 -0500
Received: from mga07.intel.com ([134.134.136.100]:21514 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S935913AbcLTPMc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 20 Dec 2016 10:12:32 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,379,1477983600"; 
   d="scan'208";a="20754177"
Subject: Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command
To: Baolin Wang <baolin.wang@linaro.org>,
        Lu Baolu <baolu.lu@linux.intel.com>
References: <b0157454dce55d1288c7e097ddffc3d6c81351b2.1480922249.git.baolin.wang@linaro.org>
 <0c39bfed1cf6f7b747e702aa841f82c9d2140f27.1480922249.git.baolin.wang@linaro.org>
 <584EC7B9.6040100@linux.intel.com>
 <CAMz4ku+d+14PhZO-M5pNEkB4KyqJeiifeMWs=+tDGjyzN=phoA@mail.gmail.com>
 <5857B794.2070100@linux.intel.com>
 <CAMz4ku+c1k47Or_sYPeQEwX3LJoynepcRSEtfosAzoyjrS+2SQ@mail.gmail.com>
 <5857CEE4.6040007@intel.com> <5858B3AE.90705@linux.intel.com>
 <CAMz4ku+ryKutgBrkQAqSWqxP+PdcM7Hd-FrrRA3crk9G9MG3Zw@mail.gmail.com>
 <5858D231.7040407@linux.intel.com>
 <CAMz4ku+rYdpkCRt7NngM3X17pgwbApZg9cGoCwycGR-+XGMK8Q@mail.gmail.com>
 <5858DB52.8060707@linux.intel.com>
 <CAMz4kuLC1Ooj2dFvMo+iq2e9DmFeAam2B_yoOy3H5J86Fhs3Cw@mail.gmail.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
        Greg KH <gregkh@linuxfoundation.org>, USB <linux-usb@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, Mark Brown <broonie@kernel.org>,
        "Lu, Baolu" <baolu.lu@intel.com>
From: Mathias Nyman <mathias.nyman@linux.intel.com>
Message-ID: <58594A9A.10507@linux.intel.com>
Date: Tue, 20 Dec 2016 17:13:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <CAMz4kuLC1Ooj2dFvMo+iq2e9DmFeAam2B_yoOy3H5J86Fhs3Cw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20.12.2016 09:30, Baolin Wang wrote:
...

Alright, I gathered all current work related to xhci races and timeouts
and put them into a branch:

git://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git timeout_race_fixes

Its based on 4.9
It includes a few other patches just to avoid conflicts and  make my life easier

Interesting patches are:

ee4eb91 xhci: remove unnecessary check for pending timer
0cba67d xhci: detect stop endpoint race using pending timer instead of counter.
4f2535f xhci: Handle command completion and timeout race
b9d00d7 usb: host: xhci: Fix possible wild pointer when handling abort command
529a5a0 usb: xhci: fix possible wild pointer
4766555 xhci: Fix race related to abort operation
de834a3 xhci: Use delayed_work instead of timer for command timeout
69973b8 Linux 4.9

The fixes for command queue races will go to usb-linus and stable, the
reworks for stop ep watchdog timer will go to usb-next.

Still completely untested, (well it compiles)

Felipe gave instructions how to modify dwc3 driver to timeout on address
devicecommands to test these, I'll try to set that up.

All additional testing is welcome, especially if you can trigger timeouts
and races

-Mathias