From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756492AbcLUHWk (ORCPT ); Wed, 21 Dec 2016 02:22:40 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:50448 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754262AbcLUHWh (ORCPT ); Wed, 21 Dec 2016 02:22:37 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee61a-f79bd6d000000fc6-15-585a2dbcb5b8 Content-transfer-encoding: 8BIT Message-id: <585A2DBB.8070504@samsung.com> Date: Wed, 21 Dec 2016 16:22:35 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Baolin Wang , myungjoo.ham@samsung.com, wens@csie.org, kishon@ti.com, heiko@sntech.de Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linaro-kernel@lists.linaro.org, broonie@kernel.org, neilb@suse.com Subject: Re: [PATCH 2/3] extcon: axp288: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set References: <7b9836ce2ca34118a2acd1ea113605a5f13b4439.1482300213.git.baolin.wang@linaro.org> <11fb7adc2982a9134faee9abb1de4dcfb253f2d2.1482300213.git.baolin.wang@linaro.org> In-reply-to: <11fb7adc2982a9134faee9abb1de4dcfb253f2d2.1482300213.git.baolin.wang@linaro.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFIsWRmVeSWpSXmKPExsVy+t9jAd09ulERBk9m8Fp8arjCbDH14RM2 i/+PXrNaXHjaw2bx/tAzZotNj6+xWlzeNYfN4tOD/8wWtxtXAFkbYy1+HjrP5MDtseHRalaP Tas62TzuXNvD5rF5Sb3H7X+PmT36tqxi9Nh+bR6zx/otV1k8jt/YzuTxeZNcAFeUm01GamJK apFCal5yfkpmXrqtUmiIm66FkkJeYm6qrVKErm9IkJJCWWJOKZBnZIAGHJwD3IOV9O0S3DL2 Xb/JUvBEsuLXoYvMDYw/hbsYOTgkBEwk9s3l6mLkBDLFJC7cW8/WxcjFISSwlFGid9osNpAE r4CgxI/J91hA6pkF5CWOXMoGCTMLqEtMmreIGaL+AaPEgx9TWSHqtSROtGwBs1kEVCWWXutn AbHZgOL7X9wAm8kvoChx9cdjRpCZogIREt0nKkHCIgLFEhMOLWYFmckssIlR4tmuSYwgCWGB SInLnw4xQixrZZL4cb4fLMEpEC+x6tNmlgmMgrOQ3DoL4dZZSG5dwMi8ilEitSC5oDgpPdcw L7Vcrzgxt7g0L10vOT93EyM4np9J7WA8uMv9EKMAB6MSD+8O68gIIdbEsuLK3EOMEhzMSiK8 G7WjIoR4UxIrq1KL8uOLSnNSiw8xmgI9O5FZSjQ5H5hq8kriDU3MTcyNDSzMLS1NjJTEeRtn PwsXEkhPLEnNTk0tSC2C6WPi4JRqYHRQj7D8Kc7eY3Vi5Rmzi9xT3R+fs14897VMiFTxRd8i 7lQz4UNKmU8/KCeG/E7/HRpY2nVna1FaVOnNmhP9ofMW/rYQamePtt3ieZ4p2X7WUU/rqbqT WDVPWLxrXV15iyNvLxerYnaZfdikcqtl2/nWnzllyr0xPl/e+H549dUzG7f3diUqKrEUZyQa ajEXFScCAIYbBRL9AgAA X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2016년 12월 21일 15:10, Baolin Wang wrote: > According to the documentation, we should set the EXTCON_USB when > one SDP charger connector was reported. > > Signed-off-by: Baolin Wang > --- > drivers/extcon/extcon-axp288.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c > index 42f41e8..4490726 100644 > --- a/drivers/extcon/extcon-axp288.c > +++ b/drivers/extcon/extcon-axp288.c > @@ -102,6 +102,7 @@ enum axp288_extcon_irq { > }; > > static const unsigned int axp288_extcon_cables[] = { > + EXTCON_USB, > EXTCON_CHG_USB_SDP, > EXTCON_CHG_USB_CDP, > EXTCON_CHG_USB_DCP, > @@ -225,8 +226,12 @@ static int axp288_handle_chrg_det_event(struct axp288_extcon_info *info) > vbus_attach ? USB_EVENT_VBUS : USB_EVENT_NONE, NULL); > } > > - if (notify_charger) > + if (notify_charger) { > extcon_set_state_sync(info->edev, cable, vbus_attach); > + if (cable == EXTCON_CHG_USB_SDP) > + extcon_set_state_sync(info->edev, EXTCON_USB, > + vbus_attach); > + } > > /* Clear the flags on disconnect event */ > if (!vbus_attach) > The extcon-axp288.c driver has some patches on extcon-next[1] branch. [1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/log/?h=extcon-next I rework your patch on extcon-next branch as following: If you ok, I'll merge it for v4.11. commit 1a96f92bdfab86d0b634e56092f543cad348fd0b Refs: extcon-next, extcon-next-for-4.10-15-g1a96f92bdfab Author: Baolin Wang AuthorDate: Wed Dec 21 15:51:26 2016 +0900 Commit: Chanwoo Choi CommitDate: Wed Dec 21 15:52:00 2016 +0900 extcon: axp288: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set According to the documentation, we should set the EXTCON_USB when one SDP charger connector was reported. Signed-off-by: Baolin Wang Signed-off-by: Chanwoo Choi --- drivers/extcon/extcon-axp288.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c index 3e145e2a4860..f4fd03e58e37 100644 --- a/drivers/extcon/extcon-axp288.c +++ b/drivers/extcon/extcon-axp288.c @@ -96,6 +96,7 @@ enum axp288_extcon_irq { EXTCON_CHG_USB_SDP, EXTCON_CHG_USB_CDP, EXTCON_CHG_USB_DCP, + EXTCON_USB, EXTCON_NONE, }; @@ -206,8 +207,15 @@ static int axp288_handle_chrg_det_event(struct axp288_extcon_info *info) : EXTCON_GPIO_MUX_SEL_PMIC); extcon_set_state_sync(info->edev, info->previous_cable, false); + if (info->previous_cable == EXTCON_CHG_USB_SDP) + extcon_set_state_sync(info->edev, EXTCON_USB, false); + if (vbus_attach) { extcon_set_state_sync(info->edev, cable, vbus_attach); + if (cable == EXTCON_CHG_USB_SDP) + extcon_set_state_sync(info->edev, EXTCON_USB, + vbus_attach); + info->previous_cable = cable; } -- Regards, Chanwoo Choi From mboxrd@z Thu Jan 1 00:00:00 1970 From: cw00.choi@samsung.com (Chanwoo Choi) Date: Wed, 21 Dec 2016 16:22:35 +0900 Subject: [PATCH 2/3] extcon: axp288: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set In-Reply-To: <11fb7adc2982a9134faee9abb1de4dcfb253f2d2.1482300213.git.baolin.wang@linaro.org> References: <7b9836ce2ca34118a2acd1ea113605a5f13b4439.1482300213.git.baolin.wang@linaro.org> <11fb7adc2982a9134faee9abb1de4dcfb253f2d2.1482300213.git.baolin.wang@linaro.org> Message-ID: <585A2DBB.8070504@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 2016? 12? 21? 15:10, Baolin Wang wrote: > According to the documentation, we should set the EXTCON_USB when > one SDP charger connector was reported. > > Signed-off-by: Baolin Wang > --- > drivers/extcon/extcon-axp288.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c > index 42f41e8..4490726 100644 > --- a/drivers/extcon/extcon-axp288.c > +++ b/drivers/extcon/extcon-axp288.c > @@ -102,6 +102,7 @@ enum axp288_extcon_irq { > }; > > static const unsigned int axp288_extcon_cables[] = { > + EXTCON_USB, > EXTCON_CHG_USB_SDP, > EXTCON_CHG_USB_CDP, > EXTCON_CHG_USB_DCP, > @@ -225,8 +226,12 @@ static int axp288_handle_chrg_det_event(struct axp288_extcon_info *info) > vbus_attach ? USB_EVENT_VBUS : USB_EVENT_NONE, NULL); > } > > - if (notify_charger) > + if (notify_charger) { > extcon_set_state_sync(info->edev, cable, vbus_attach); > + if (cable == EXTCON_CHG_USB_SDP) > + extcon_set_state_sync(info->edev, EXTCON_USB, > + vbus_attach); > + } > > /* Clear the flags on disconnect event */ > if (!vbus_attach) > The extcon-axp288.c driver has some patches on extcon-next[1] branch. [1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/log/?h=extcon-next I rework your patch on extcon-next branch as following: If you ok, I'll merge it for v4.11. commit 1a96f92bdfab86d0b634e56092f543cad348fd0b Refs: extcon-next, extcon-next-for-4.10-15-g1a96f92bdfab Author: Baolin Wang AuthorDate: Wed Dec 21 15:51:26 2016 +0900 Commit: Chanwoo Choi CommitDate: Wed Dec 21 15:52:00 2016 +0900 extcon: axp288: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set According to the documentation, we should set the EXTCON_USB when one SDP charger connector was reported. Signed-off-by: Baolin Wang Signed-off-by: Chanwoo Choi --- drivers/extcon/extcon-axp288.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c index 3e145e2a4860..f4fd03e58e37 100644 --- a/drivers/extcon/extcon-axp288.c +++ b/drivers/extcon/extcon-axp288.c @@ -96,6 +96,7 @@ enum axp288_extcon_irq { EXTCON_CHG_USB_SDP, EXTCON_CHG_USB_CDP, EXTCON_CHG_USB_DCP, + EXTCON_USB, EXTCON_NONE, }; @@ -206,8 +207,15 @@ static int axp288_handle_chrg_det_event(struct axp288_extcon_info *info) : EXTCON_GPIO_MUX_SEL_PMIC); extcon_set_state_sync(info->edev, info->previous_cable, false); + if (info->previous_cable == EXTCON_CHG_USB_SDP) + extcon_set_state_sync(info->edev, EXTCON_USB, false); + if (vbus_attach) { extcon_set_state_sync(info->edev, cable, vbus_attach); + if (cable == EXTCON_CHG_USB_SDP) + extcon_set_state_sync(info->edev, EXTCON_USB, + vbus_attach); + info->previous_cable = cable; } -- Regards, Chanwoo Choi