From: Jike Song <jike.song@intel.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 0/4] vfio-mdev: Clean namespace and better define ABI
Date: Thu, 22 Dec 2016 10:11:00 +0800 [thread overview]
Message-ID: <585B3634.1050009@intel.com> (raw)
In-Reply-To: <20161221232315.6091.30612.stgit@gimli.home>
On 12/22/2016 07:27 AM, Alex Williamson wrote:
> Cleanup the namespace a bit by prefixing structures with mdev_ and
> also more concretely define the mdev interface. Structs with comments
> defining which fields are private vs public tempts poor behavior,
> especially for an interface where we expect out of tree vendor drivers.
Personally I like this series :)
Side notes: 1) There is also Documentation to be updated; 2) your mail
address in Author field is @nuc.home?
--
Thanks,
Jike
>
> ---
>
> Alex Williamson (4):
> vfio-mdev: Remove an unused structure element
> vfio-mdev: de-polute the namespace, rename parent_device & parent_ops
> vfio-mdev: Make mdev_parent private
> vfio-mdev: Make mdev_device private and abstract interfaces
>
>
> drivers/gpu/drm/i915/gvt/kvmgt.c | 22 +++++++------
> drivers/vfio/mdev/mdev_core.c | 64 ++++++++++++++++++++++++++++++--------
> drivers/vfio/mdev/mdev_private.h | 28 +++++++++++++++--
> drivers/vfio/mdev/mdev_sysfs.c | 8 ++---
> drivers/vfio/mdev/vfio_mdev.c | 12 ++++---
> include/linux/mdev.h | 54 +++++++-------------------------
> samples/vfio-mdev/mtty.c | 28 +++++++++--------
> 7 files changed, 123 insertions(+), 93 deletions(-)
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next prev parent reply other threads:[~2016-12-22 2:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 23:27 [PATCH 0/4] vfio-mdev: Clean namespace and better define ABI Alex Williamson
2016-12-21 23:27 ` [PATCH 1/4] vfio-mdev: Remove an unused structure element Alex Williamson
2016-12-21 23:27 ` [PATCH 2/4] vfio-mdev: de-polute the namespace, rename parent_device & parent_ops Alex Williamson
2016-12-22 7:51 ` Jike Song
2016-12-21 23:27 ` [PATCH 3/4] vfio-mdev: Make mdev_parent private Alex Williamson
2016-12-21 23:27 ` [PATCH 4/4] vfio-mdev: Make mdev_device private and abstract interfaces Alex Williamson
2016-12-22 2:11 ` Jike Song [this message]
2016-12-22 2:31 ` [PATCH 0/4] vfio-mdev: Clean namespace and better define ABI Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=585B3634.1050009@intel.com \
--to=jike.song@intel.com \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.