All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Gordeev <agordeev@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Alexander Gordeev <agordeev@redhat.com>,
	Anil Ravindranath <anil_ravindranath@pmc-sierra.com>,
	linux-scsi@vger.kernel.org, linux-pci@vger.kernel.org
Subject: [PATCH v2 RESEND 20/23] pmcraid: Use pci_enable_msix_range() instead of pci_enable_msix()
Date: Mon, 14 Apr 2014 10:05:44 +0200	[thread overview]
Message-ID: <585bd723050f1aad76c0cc8972293768eccdfc4c.1397461652.git.agordeev@redhat.com> (raw)
In-Reply-To: <cover.1397461652.git.agordeev@redhat.com>

As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range()  or pci_enable_msi_exact()
and pci_enable_msix_range() or pci_enable_msix_exact()
interfaces.

Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: Anil Ravindranath <anil_ravindranath@pmc-sierra.com>
Cc: linux-scsi@vger.kernel.org
Cc: linux-pci@vger.kernel.org
---
 drivers/scsi/pmcraid.c |   13 ++-----------
 1 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index c06af7f..6d0f208 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -4698,19 +4698,10 @@ pmcraid_register_interrupt_handler(struct pmcraid_instance *pinstance)
 		for (i = 0; i < PMCRAID_NUM_MSIX_VECTORS; i++)
 			entries[i].entry = i;
 
-		rc = pci_enable_msix(pdev, entries, num_hrrq);
-		if (rc < 0)
+		num_hrrq = pci_enable_msix_range(pdev, entries, 1, num_hrrq);
+		if (num_hrrq < 0)
 			goto pmcraid_isr_legacy;
 
-		/* Check how many MSIX vectors are allocated and register
-		 * msi-x handlers for each of them giving appropriate buffer
-		 */
-		if (rc > 0) {
-			num_hrrq = rc;
-			if (pci_enable_msix(pdev, entries, num_hrrq))
-				goto pmcraid_isr_legacy;
-		}
-
 		for (i = 0; i < num_hrrq; i++) {
 			pinstance->hrrq_vector[i].hrrq_id = i;
 			pinstance->hrrq_vector[i].drv_inst = pinstance;
-- 
1.7.7.6


  parent reply	other threads:[~2014-04-14  8:15 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-14  8:05 [PATCH v2 RESEND 00/23] scsi: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-04-14  8:05 ` [PATCH v2 RESEND 01/23] be2iscsi: Use pci_enable_msix_exact() " Alexander Gordeev
2014-04-14  8:05 ` [PATCH v2 RESEND 02/23] bfa: Do not call pci_enable_msix() after it failed once Alexander Gordeev
2014-04-16  9:03   ` Anil Gurumurthy
2014-04-16  9:03     ` Anil Gurumurthy
2014-04-14  8:05 ` [PATCH v2 RESEND 03/23] bfa: Cleanup bfad_setup_intr() function Alexander Gordeev
2014-04-16  9:04   ` Anil Gurumurthy
2014-04-16  9:04     ` Anil Gurumurthy
2014-04-16  9:05   ` Anil Gurumurthy
2014-04-16  9:05     ` Anil Gurumurthy
2014-04-14  8:05 ` [PATCH v2 RESEND 04/23] bfa: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-04-16  9:05   ` Anil Gurumurthy
2014-04-16  9:05     ` Anil Gurumurthy
2014-04-14  8:05 ` [PATCH v2 RESEND 05/23] csiostor: Remove superfluous call to pci_disable_msix() Alexander Gordeev
2014-04-14  8:05 ` [PATCH v2 RESEND 06/23] csiostor: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-04-14  8:05 ` [PATCH v2 RESEND 07/23] fnic: Use pci_enable_msix_exact() " Alexander Gordeev
2014-04-14  8:05 ` [PATCH v2 RESEND 08/23] isci: " Alexander Gordeev
2014-04-16 12:51   ` Artur Paszkiewicz
2014-04-14  8:05 ` [PATCH v2 RESEND 09/23] hpsa: Fallback to MSI rather than to INTx if MSI-X failed Alexander Gordeev
2014-04-14  8:05 ` [PATCH v2 RESEND 10/23] hpsa: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-08-13 19:27   ` scameron
2014-04-14  8:05 ` [PATCH v2 RESEND 11/23] lpfc: Remove superfluous call to pci_disable_msix() Alexander Gordeev
2014-04-14  8:05 ` [PATCH v2 RESEND 12/23] lpfc: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-04-14  8:05 ` [PATCH v2 RESEND 13/23] megaraid: Fail resume if MSI-X re-initialization failed Alexander Gordeev
2014-04-14  8:05 ` [PATCH v2 RESEND 14/23] megaraid: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-04-14  8:05 ` [PATCH v2 RESEND 15/23] mpt2sas: Use pci_enable_msix_exact() " Alexander Gordeev
2014-04-14  8:05 ` [PATCH v2 RESEND 16/23] mpt3sas: " Alexander Gordeev
2014-04-14  8:05 ` [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed Alexander Gordeev
2014-04-14  8:05 ` [PATCH v2 RESEND 18/23] pm8001: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-04-14  8:05 ` [PATCH v2 RESEND 19/23] pmcraid: Get rid of a redundant assignment Alexander Gordeev
2014-04-14  8:05 ` Alexander Gordeev [this message]
2014-04-14  8:05 ` [PATCH v2 RESEND 21/23] qla2xxx: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-04-14  8:05 ` [PATCH v2 RESEND 22/23] qla4xxx: Use pci_enable_msix_exact() " Alexander Gordeev
2014-04-15 12:48   ` Vikas Chaudhary
2014-04-15 12:48     ` Vikas Chaudhary
2014-04-14  8:05 ` [PATCH v2 RESEND 23/23] vmw_pvscsi: " Alexander Gordeev
2014-04-24 17:09 ` [PATCH v2 RESEND 00/23] scsi: Use pci_enable_msix_range() " Bjorn Helgaas
2014-04-24 17:51   ` James Bottomley
2014-04-24 18:07     ` Bjorn Helgaas
2014-07-07 18:03       ` Alexander Gordeev
2014-06-16  7:35     ` Alexander Gordeev
2014-07-16 18:05 Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 20/23] pmcraid: " Alexander Gordeev
2014-07-26  8:37   ` Alexander Gordeev
2014-08-11  7:44   ` Alexander Gordeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=585bd723050f1aad76c0cc8972293768eccdfc4c.1397461652.git.agordeev@redhat.com \
    --to=agordeev@redhat.com \
    --cc=anil_ravindranath@pmc-sierra.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.