From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A078FC35280 for ; Wed, 2 Oct 2019 15:21:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8008C21848 for ; Wed, 2 Oct 2019 15:21:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726239AbfJBPVZ (ORCPT ); Wed, 2 Oct 2019 11:21:25 -0400 Received: from ns.iliad.fr ([212.27.33.1]:34792 "EHLO ns.iliad.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726179AbfJBPVZ (ORCPT ); Wed, 2 Oct 2019 11:21:25 -0400 Received: from ns.iliad.fr (localhost [127.0.0.1]) by ns.iliad.fr (Postfix) with ESMTP id 2D6C120AEE; Wed, 2 Oct 2019 17:21:23 +0200 (CEST) Received: from [192.168.108.37] (freebox.vlq16.iliad.fr [213.36.7.13]) by ns.iliad.fr (Postfix) with ESMTP id 16ECB20723; Wed, 2 Oct 2019 17:21:23 +0200 (CEST) Subject: Re: [PATCHv9 2/3] arm64: dts: qcom: msm8998: Add Coresight support To: Mathieu Poirier References: <90114e06825e537c3aafd3de5c78743a9de6fadc.1564550873.git.saiprakash.ranjan@codeaurora.org> <16212a577339204e901cf4eefa5e82f1@codeaurora.org> <5b8835905a704fb813714694a792df54@codeaurora.org> Cc: Sai Prakash Ranjan , Jeffrey Hugo , Bjorn Andersson , Linux ARM , MSM From: Marc Gonzalez Message-ID: <585ee38c-39d1-47df-78b7-f4b670f17a25@free.fr> Date: Wed, 2 Oct 2019 17:21:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP ; ns.iliad.fr ; Wed Oct 2 17:21:23 2019 +0200 (CEST) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 02/10/2019 17:03, Mathieu Poirier wrote: > The problem here is that a debug and production device are using the > same device tree, i.e msm8998.dtsi. Disabling coresight devices in > the DTS file will allow the laptop to boot but completely disabled > coresight blocks on the MTP board. Leaving things as is breaks the > laptop but allows coresight to be used on the MTP board. One of three > things can happen: > > 1) Nothing gets done and production board can't boot without DTS modifications. > 2) Disable tags are added to the DTS file and the debug board can't > use coresight without modifications. > 2) The handling of the debug power domain is done properly on the > MSM8998 rather than relying on the bootloader to enable it. > 3) The DTS file is split or reorganised to account for debug/production devices. I believe 3) is already the de facto situation. arch/arm64/boot/dts/qcom/msm8998.dtsi is the "base" config. arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi for the MTP board. arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi for the laptops. > Which of the above ends up being the final solution is entirely up to > David and Andy. 2498f8c1c668 ;-) Regards. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8284FC352AA for ; Wed, 2 Oct 2019 15:21:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54A7C21848 for ; Wed, 2 Oct 2019 15:21:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="expl+4p5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54A7C21848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uO5i8MxnyolkR1sCEp7sgRaFD1Vy2eMFUMf7ZexOxDU=; b=expl+4p5QXwhX/ m4s1joaYr3Cny0bOveV44GCtscpJINrraTJ0abNr2Pwur3M7dEhHAce5Vn3/n/Q6qQE+glBisabhZ soof1q/eHTevReC0+1VDMPX8ZaAAsffXCEM9FXItQMYKxB/XVJ7tlOdIqlCiAo9p2+0oSN29c+UcK Llg0Jx3SA+lvY0nxjHb5uc2rIsmYjstIszylqEu7fnG68TU+p+b/EZOxyBjPHqBh1qaKvWr/Fuo3b xNwdxBKn58cMn2Bo3b6+WgENjrR7NN62TTYNLpFsXm/o4e8jDu2eFU10acLt5IsNfwCCtz41I+YEL yzjuBO8fpFNAAkWQ0zcA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFgRZ-00088x-NG; Wed, 02 Oct 2019 15:21:33 +0000 Received: from ns.iliad.fr ([212.27.33.1]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFgRW-00088T-6v for linux-arm-kernel@lists.infradead.org; Wed, 02 Oct 2019 15:21:31 +0000 Received: from ns.iliad.fr (localhost [127.0.0.1]) by ns.iliad.fr (Postfix) with ESMTP id 2D6C120AEE; Wed, 2 Oct 2019 17:21:23 +0200 (CEST) Received: from [192.168.108.37] (freebox.vlq16.iliad.fr [213.36.7.13]) by ns.iliad.fr (Postfix) with ESMTP id 16ECB20723; Wed, 2 Oct 2019 17:21:23 +0200 (CEST) Subject: Re: [PATCHv9 2/3] arm64: dts: qcom: msm8998: Add Coresight support To: Mathieu Poirier References: <90114e06825e537c3aafd3de5c78743a9de6fadc.1564550873.git.saiprakash.ranjan@codeaurora.org> <16212a577339204e901cf4eefa5e82f1@codeaurora.org> <5b8835905a704fb813714694a792df54@codeaurora.org> From: Marc Gonzalez Message-ID: <585ee38c-39d1-47df-78b7-f4b670f17a25@free.fr> Date: Wed, 2 Oct 2019 17:21:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Virus-Scanned: ClamAV using ClamSMTP ; ns.iliad.fr ; Wed Oct 2 17:21:23 2019 +0200 (CEST) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191002_082130_401670_6DA4DE13 X-CRM114-Status: GOOD ( 11.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: MSM , Sai Prakash Ranjan , Bjorn Andersson , Linux ARM , Jeffrey Hugo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02/10/2019 17:03, Mathieu Poirier wrote: > The problem here is that a debug and production device are using the > same device tree, i.e msm8998.dtsi. Disabling coresight devices in > the DTS file will allow the laptop to boot but completely disabled > coresight blocks on the MTP board. Leaving things as is breaks the > laptop but allows coresight to be used on the MTP board. One of three > things can happen: > > 1) Nothing gets done and production board can't boot without DTS modifications. > 2) Disable tags are added to the DTS file and the debug board can't > use coresight without modifications. > 2) The handling of the debug power domain is done properly on the > MSM8998 rather than relying on the bootloader to enable it. > 3) The DTS file is split or reorganised to account for debug/production devices. I believe 3) is already the de facto situation. arch/arm64/boot/dts/qcom/msm8998.dtsi is the "base" config. arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi for the MTP board. arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi for the laptops. > Which of the above ends up being the final solution is entirely up to > David and Andy. 2498f8c1c668 ;-) Regards. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel