From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mengdong Lin Subject: Re: [PATCH v2 1/2] ASoC: core: Add API to use DMI name in sound card long name Date: Fri, 6 Jan 2017 14:07:19 +0800 Message-ID: <586F3417.1010405@linux.intel.com> References: <0827a46b8200cc3e053f8fc6b3b428eac90a3618.1483418875.git.mengdong.lin@linux.intel.com> <1483454417.4555.2.camel@loki> <1483471712.4063.17.camel@loki> <984e6c66-c1c9-c37b-f6b6-d357cd967d48@intel.com> <586C9E54.60201@linux.intel.com> <1483566423.2629.17.camel@loki> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by alsa0.perex.cz (Postfix) with ESMTP id 8D0BB2667A5 for ; Fri, 6 Jan 2017 07:04:19 +0100 (CET) In-Reply-To: <1483566423.2629.17.camel@loki> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Liam Girdwood Cc: "alsa-devel@alsa-project.org" , "tiwai@suse.de" , "Lin, Mengdong" , "Koul, Vinod" , "broonie@kernel.org" , Pierre-Louis Bossart List-Id: alsa-devel@alsa-project.org On 01/05/2017 05:47 AM, Liam Girdwood wrote: > On Wed, 2017-01-04 at 15:03 +0800, Mengdong Lin wrote: >> >> On 01/04/2017 04:09 AM, Pierre-Louis Bossart wrote: >> So we'll keep the manufacturer name. >> >> And let's put the "Product version" as well if available, Liam? > > Yes, lets keep the manufacturer name. I agree with Pierre in that we > dont want meaningless directories names. Okay. Thanks for your confirmation! > Creating a directory structures > like > > 1) manufacturer/product/board OR > 2) manufacturer/product OR > 3) manufacturer/board > > (2 or 3 if board or product is NULL) > > are fine by me and make finding the correct card simpler. You could even > replace the . with / in your longname to save the string conversion > later on. > > Liam May we keep the flat directory structure for UCM files? For the same manufacturer, its DMI vendor name could change, e.g. "Intel Inc." or "Intel Corporation". In addition, there may be changes caused by using upper case or low case characters. Since we don't want to maintain a mapping table and just do verbatim copy of DMI info, it's hard to group all the products/boards of one manufacturer into one UCM directory. So I feel it may be better to keep the simple flat directory structure. Thanks Mengdong