From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761794AbdAKFdd (ORCPT ); Wed, 11 Jan 2017 00:33:33 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:46235 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761765AbdAKFd2 (ORCPT ); Wed, 11 Jan 2017 00:33:28 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: b6c32a36-f79d86d000003cda-5f-5875c3a66a9f Content-transfer-encoding: 8BIT Message-id: <5875C3A6.9040002@samsung.com> Date: Wed, 11 Jan 2017 14:33:26 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hoegeun Kwon , robh@kernel.org, thierry.reding@gmail.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, a.hajda@samsung.com, cw00.choi@samsung.com, jh80.chung@samsung.com Subject: Re: [PATCH v7 2/4] drm/exynos: mic: Fix parse_dt function In-reply-to: <1483611609-23522-3-git-send-email-hoegeun.kwon@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA02SaUwTYRCG83W326JU13ow1gh1jRcJpbsUWBSMeKWKB+oPG4/UFTZA6EG6 bSNGjVpFRUTAhGg1ike4TJTgBV5RxAOjVEWjgrYYohJQ+aHiERW7XY3+e2e+Z76ZeTNKTF1D aJQ5NifvsHEWihiEn78xJTam8obLpK/qoNj2U61ydk9ri4x9+umtnD3SHAwff+4j2L6qQoJ9 9r1Azu7t6sVYn69OwbZdPESw+31XZezA5QYF++3iYXyGytjofakw1tfuIowX+jvlxsDu2zJj 8dlaZPxYH5lOrOCTs3kuk3doeVuGPTPHlpVCpS0zzzLHJ+jpGDqJTaS0Ns7Kp1CzF6THzM2x BCeltG7O4gqm0jlBoGKnJzvsLievzbYLzhRqJU0zOlqfqGMYRmeIWz2ViQ8ia/jsgooeLG9b +LoTlX58M6oLK0RhSiANcH9LCy7pUfDAf5ooRIOUarIBgf/kL7n4oCZ3yOBBy+JCpAwVeDpG S0wVgu7jPkxkVOQw+LrPj4sMRkZB86NcMY2RU6D7UxkufeNHcOBemoRHg6ezQyFqnJwAP9qu I1ETQV1aHSBEPZI0QeOR/hAzgtyLoLE6R+yLkXcQeJ6VhKDh5Ex44ikJFYeR8+DkuUuYCAHZ roD+tpuENPRYqL+GSUvOhsqKw4Skh0PP7bMKSY+B2l/tMql2N4KnRUWEFOxE8HPXwB+L4iDQ 6cek1YbAh89FcqmBCnYWqCXECG8ufEGSToXtV/swya0OBMUNXnkJivL+Z5j3n2He/wyrQFgt GsXnCdYsXqDzGJ3AWQWXLUuXYbfWo9CZRic0oGOtC5oQqURUuIrtdZrUcs4t5FubECgxaoRq SZPLpFZlcvnreYfd7HBZeKEJxQcNL8U0IzPswaO3Oc20IYE2MAaaTmT0DBWhOr5lmklNZnFO Ppfn83jH3zqZMkyzGcWGrzuzlA1seo5XzEndaMgfrU0tdbjLI3uXE5PuDfFcnxg//o5r9dfc iGHd4fZXUS/wjZq07QdvrtrArC2LjVhouDTZ5xzQFs8PdLqrE+qSht7qeXelPPC6S7PVUk5A ckZU5LVj+hqO2BF34Ghz17iHbgzVZL5fVNVmTrp7f2jlYAoXsjk6GnMI3G880XZ4vAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCIsWRmVeSWpSXmKPExsVy+t9jAd1lh0sjDN52ClvcWneO1aL33Ekm i+tfnrNazD8C5F75+p7N4v3yLjaLG7/aWC36H79mtjh/fgO7xeVdc9gsZpzfx2Txf88Odouf u+axOPB67Jx1l91j06pONo/t3x6wetzvPs7k0bdlFaPH501yAWxRbjYZqYkpqUUKqXnJ+SmZ eem2SqEhbroWSgp5ibmptkoRur4hQUoKZYk5pUCekQEacHAOcA9W0rdLcMtoW/CKuaCFp2LJ snssDYwbOLsYOTgkBEwkmm9LdjFyApliEhfurWfrYuTiEBJYyijxZ+UBNpAEr4CgxI/J91hA 6pkF5CWOXMqGMNUlpkzJhSh/wCgx/+ZNFohyLYnmB7fZQWwWAVWJP5cPMoLYbED2xBX32UB6 RQUiJLpPVIL0igj0Mkrs33CICaSGWeAEo8TbBncQW1jASeJq8wRGiAW3GSX+9R4EW8Ap4Cmx eutu5gmMArOQnDcL4bxZCOctYGRexSiRWpBcUJyUnmuYl1quV5yYW1yal66XnJ+7iREco8+k djAe3OV+iFGAg1GJh/fBi5IIIdbEsuLK3EOMEhzMSiK8gYdKI4R4UxIrq1KL8uOLSnNSiw8x mgL9N5FZSjQ5H5g+8kriDU3MTcyNDSzMLS1NjJTEeRtnPwsXEkhPLEnNTk0tSC2C6WPi4JRq YOT3/ZaxlfFjzdHXp+ex7fdImMyqJXz3kW1jmErV0RuOUcLb9epLfWK2dHaURQRWOHbsdpi0 tKFxVZTny55jmxkOOJ40Kz+6+GbQz0e9ehYFbwW7gz+0PpDJZXLMcTPMCX54r3TaTp5zwTwP 1osnOqz8UHl1dd9fsRN/ZzAqtZRKX/ewLp0moMRSnJFoqMVcVJwIALbzZx/nAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170111053326epcas1p433cc02d99e04d91d504a11332a3df597 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?64yA7J246riwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?SW5raSBEYWUbVGl6ZW4gUGxhdGZvcm0gTGFiLhtTYW1zdW5n?= =?UTF-8?B?IEVsZWN0cm9uaWNzG1M1L1NlbmlvciBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170105102012epcas5p308c2d3ed269d9bf76f76f1d38422eb54 X-RootMTR: 20170105102012epcas5p308c2d3ed269d9bf76f76f1d38422eb54 References: <1483611609-23522-1-git-send-email-hoegeun.kwon@samsung.com> <1483611609-23522-3-git-send-email-hoegeun.kwon@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied. Thanks. 2017년 01월 05일 19:20에 Hoegeun Kwon 이(가) 쓴 글: > The OF graph is not necessary because the panel is a child of > dsi. therefore, the parse_dt function of dsi does not need to > check the remote_node connected to the panel. and the whole > parse_dt function should be refactored later. > > Signed-off-by: Hoegeun Kwon > --- > drivers/gpu/drm/exynos/exynos_drm_mic.c | 25 +++---------------------- > 1 file changed, 3 insertions(+), 22 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c > index fed1a94..cf9361a 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c > @@ -269,28 +269,9 @@ static int parse_dt(struct exynos_mic *mic) > } > nodes[j++] = remote_node; > > - switch (i) { > - case ENDPOINT_DECON_NODE: > - /* decon node */ > - if (of_get_child_by_name(remote_node, > - "i80-if-timings")) > - mic->i80_mode = 1; > - > - break; > - case ENDPOINT_DSI_NODE: > - /* panel node */ > - remote_node = get_remote_node(remote_node, 1); > - if (!remote_node) { > - ret = -EPIPE; > - goto exit; > - } > - nodes[j++] = remote_node; > - > - break; > - default: > - DRM_ERROR("mic: Unknown endpoint from MIC"); > - break; > - } > + if (i == ENDPOINT_DECON_NODE && > + of_get_child_by_name(remote_node, "i80-if-timings")) > + mic->i80_mode = 1; > } > > exit: > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH v7 2/4] drm/exynos: mic: Fix parse_dt function Date: Wed, 11 Jan 2017 14:33:26 +0900 Message-ID: <5875C3A6.9040002@samsung.com> References: <1483611609-23522-1-git-send-email-hoegeun.kwon@samsung.com> <1483611609-23522-3-git-send-email-hoegeun.kwon@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <1483611609-23522-3-git-send-email-hoegeun.kwon@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hoegeun Kwon , robh@kernel.org, thierry.reding@gmail.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, jh80.chung@samsung.com, cw00.choi@samsung.com List-Id: devicetree@vger.kernel.org QXBwbGllZC4KClRoYW5rcy4KCjIwMTfrhYQgMDHsm5QgMDXsnbwgMTk6MjDsl5AgSG9lZ2V1biBL d29uIOydtCjqsIApIOyTtCDquIA6Cj4gVGhlIE9GIGdyYXBoIGlzIG5vdCBuZWNlc3NhcnkgYmVj YXVzZSB0aGUgcGFuZWwgaXMgYSBjaGlsZCBvZgo+IGRzaS4gdGhlcmVmb3JlLCB0aGUgcGFyc2Vf ZHQgZnVuY3Rpb24gb2YgZHNpIGRvZXMgbm90IG5lZWQgdG8KPiBjaGVjayB0aGUgcmVtb3RlX25v ZGUgY29ubmVjdGVkIHRvIHRoZSBwYW5lbC4gYW5kIHRoZSB3aG9sZQo+IHBhcnNlX2R0IGZ1bmN0 aW9uIHNob3VsZCBiZSByZWZhY3RvcmVkIGxhdGVyLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEhvZWdl dW4gS3dvbiA8aG9lZ2V1bi5rd29uQHNhbXN1bmcuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vZXh5bm9zL2V4eW5vc19kcm1fbWljLmMgfCAyNSArKystLS0tLS0tLS0tLS0tLS0tLS0tLS0t Cj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDIyIGRlbGV0aW9ucygtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fbWljLmMgYi9k cml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fbWljLmMKPiBpbmRleCBmZWQxYTk0Li5j ZjkzNjFhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RybV9t aWMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RybV9taWMuYwo+IEBA IC0yNjksMjggKzI2OSw5IEBAIHN0YXRpYyBpbnQgcGFyc2VfZHQoc3RydWN0IGV4eW5vc19taWMg Km1pYykKPiAgCQl9Cj4gIAkJbm9kZXNbaisrXSA9IHJlbW90ZV9ub2RlOwo+ICAKPiAtCQlzd2l0 Y2ggKGkpIHsKPiAtCQljYXNlIEVORFBPSU5UX0RFQ09OX05PREU6Cj4gLQkJCS8qIGRlY29uIG5v ZGUgKi8KPiAtCQkJaWYgKG9mX2dldF9jaGlsZF9ieV9uYW1lKHJlbW90ZV9ub2RlLAo+IC0JCQkJ CQkiaTgwLWlmLXRpbWluZ3MiKSkKPiAtCQkJCW1pYy0+aTgwX21vZGUgPSAxOwo+IC0KPiAtCQkJ YnJlYWs7Cj4gLQkJY2FzZSBFTkRQT0lOVF9EU0lfTk9ERToKPiAtCQkJLyogcGFuZWwgbm9kZSAq Lwo+IC0JCQlyZW1vdGVfbm9kZSA9IGdldF9yZW1vdGVfbm9kZShyZW1vdGVfbm9kZSwgMSk7Cj4g LQkJCWlmICghcmVtb3RlX25vZGUpIHsKPiAtCQkJCXJldCA9IC1FUElQRTsKPiAtCQkJCWdvdG8g ZXhpdDsKPiAtCQkJfQo+IC0JCQlub2Rlc1tqKytdID0gcmVtb3RlX25vZGU7Cj4gLQo+IC0JCQli cmVhazsKPiAtCQlkZWZhdWx0Ogo+IC0JCQlEUk1fRVJST1IoIm1pYzogVW5rbm93biBlbmRwb2lu dCBmcm9tIE1JQyIpOwo+IC0JCQlicmVhazsKPiAtCQl9Cj4gKwkJaWYgKGkgPT0gRU5EUE9JTlRf REVDT05fTk9ERSAmJgo+ICsJCQlvZl9nZXRfY2hpbGRfYnlfbmFtZShyZW1vdGVfbm9kZSwgImk4 MC1pZi10aW1pbmdzIikpCj4gKwkJCW1pYy0+aTgwX21vZGUgPSAxOwo+ICAJfQo+ICAKPiAgZXhp dDoKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==