From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH 09/37] PCI: dwc: designware: Parse *num-lanes* property in dw_pcie_setup_rc Date: Mon, 16 Jan 2017 10:49:57 +0530 Message-ID: <587C57FD.7050601@ti.com> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-10-git-send-email-kishon@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Joao Pinto , Bjorn Helgaas , Jingoo Han , Arnd Bergmann Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, linux-arm-msm@vger.kernel.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org List-Id: linux-arm-msm@vger.kernel.org Hi, On Friday 13 January 2017 10:43 PM, Joao Pinto wrote: > Hi, > = > =C0s 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: >> *num-lanes* dt property is parsed in dw_pcie_host_init. However >> *num-lanes* property is applicable to both root complex mode and >> endpoint mode. As a first step, move the parsing of this property >> outside dw_pcie_host_init. This is in preparation for splitting >> pcie-designware.c to pcie-designware.c and pcie-designware-host.c >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> drivers/pci/dwc/pcie-designware.c | 18 +++++++++++------- >> drivers/pci/dwc/pcie-designware.h | 1 - >> 2 files changed, 11 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/pci/dwc/pcie-designware.c b/drivers/pci/dwc/pcie-de= signware.c >> index 00a0fdc..89cdb6b 100644 >> --- a/drivers/pci/dwc/pcie-designware.c >> +++ b/drivers/pci/dwc/pcie-designware.c >> @@ -551,10 +551,6 @@ int dw_pcie_host_init(struct pcie_port *pp) >> } >> } >> = >> - ret =3D of_property_read_u32(np, "num-lanes", &pci->lanes); >> - if (ret) >> - pci->lanes =3D 0; >> - >> ret =3D of_property_read_u32(np, "num-viewport", &pci->num_viewport); >> if (ret) >> pci->num_viewport =3D 2; >> @@ -751,18 +747,26 @@ static int dw_pcie_wr_conf(struct pci_bus *bus, u3= 2 devfn, >> = >> void dw_pcie_setup_rc(struct pcie_port *pp) >> { >> + int ret; >> + u32 lanes; >> u32 val; >> struct dw_pcie *pci =3D to_dw_pcie_from_pp(pp); >> + struct device *dev =3D pci->dev; >> + struct device_node *np =3D dev->of_node; >> = >> /* get iATU unroll support */ >> pci->iatu_unroll_enabled =3D dw_pcie_iatu_unroll_enabled(pci); >> dev_dbg(pci->dev, "iATU unroll: %s\n", >> pci->iatu_unroll_enabled ? "enabled" : "disabled"); >> = >> + ret =3D of_property_read_u32(np, "num-lanes", &lanes); >> + if (ret) >> + lanes =3D 0; > = > You moved from host_init to root complex setup function, which in my opin= ion did > not improve (in this scope). > = > I suggest that instead of making so much intermediary patches, which is n= ice to > understand your development sequence, but hard to review. Wouldn't be bet= ter to > condense some of the patches? We would have a cloear vision of the final = product :) I thought the other way. If squashing patches is easier to review, I'll do = it. Btw, thanks for reviewing. Cheers Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751260AbdAPFUq (ORCPT ); Mon, 16 Jan 2017 00:20:46 -0500 Received: from lelnx193.ext.ti.com ([198.47.27.77]:37639 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751171AbdAPFUm (ORCPT ); Mon, 16 Jan 2017 00:20:42 -0500 Subject: Re: [PATCH 09/37] PCI: dwc: designware: Parse *num-lanes* property in dw_pcie_setup_rc To: Joao Pinto , Bjorn Helgaas , Jingoo Han , Arnd Bergmann References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-10-git-send-email-kishon@ti.com> CC: , , , , , , , , , , From: Kishon Vijay Abraham I Message-ID: <587C57FD.7050601@ti.com> Date: Mon, 16 Jan 2017 10:49:57 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Friday 13 January 2017 10:43 PM, Joao Pinto wrote: > Hi, > > Ās 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: >> *num-lanes* dt property is parsed in dw_pcie_host_init. However >> *num-lanes* property is applicable to both root complex mode and >> endpoint mode. As a first step, move the parsing of this property >> outside dw_pcie_host_init. This is in preparation for splitting >> pcie-designware.c to pcie-designware.c and pcie-designware-host.c >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> drivers/pci/dwc/pcie-designware.c | 18 +++++++++++------- >> drivers/pci/dwc/pcie-designware.h | 1 - >> 2 files changed, 11 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/pci/dwc/pcie-designware.c b/drivers/pci/dwc/pcie-designware.c >> index 00a0fdc..89cdb6b 100644 >> --- a/drivers/pci/dwc/pcie-designware.c >> +++ b/drivers/pci/dwc/pcie-designware.c >> @@ -551,10 +551,6 @@ int dw_pcie_host_init(struct pcie_port *pp) >> } >> } >> >> - ret = of_property_read_u32(np, "num-lanes", &pci->lanes); >> - if (ret) >> - pci->lanes = 0; >> - >> ret = of_property_read_u32(np, "num-viewport", &pci->num_viewport); >> if (ret) >> pci->num_viewport = 2; >> @@ -751,18 +747,26 @@ static int dw_pcie_wr_conf(struct pci_bus *bus, u32 devfn, >> >> void dw_pcie_setup_rc(struct pcie_port *pp) >> { >> + int ret; >> + u32 lanes; >> u32 val; >> struct dw_pcie *pci = to_dw_pcie_from_pp(pp); >> + struct device *dev = pci->dev; >> + struct device_node *np = dev->of_node; >> >> /* get iATU unroll support */ >> pci->iatu_unroll_enabled = dw_pcie_iatu_unroll_enabled(pci); >> dev_dbg(pci->dev, "iATU unroll: %s\n", >> pci->iatu_unroll_enabled ? "enabled" : "disabled"); >> >> + ret = of_property_read_u32(np, "num-lanes", &lanes); >> + if (ret) >> + lanes = 0; > > You moved from host_init to root complex setup function, which in my opinion did > not improve (in this scope). > > I suggest that instead of making so much intermediary patches, which is nice to > understand your development sequence, but hard to review. Wouldn't be better to > condense some of the patches? We would have a cloear vision of the final product :) I thought the other way. If squashing patches is easier to review, I'll do it. Btw, thanks for reviewing. Cheers Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH 09/37] PCI: dwc: designware: Parse *num-lanes* property in dw_pcie_setup_rc To: Joao Pinto , Bjorn Helgaas , Jingoo Han , Arnd Bergmann References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-10-git-send-email-kishon@ti.com> From: Kishon Vijay Abraham I Message-ID: <587C57FD.7050601@ti.com> Date: Mon, 16 Jan 2017 10:49:57 +0530 MIME-Version: 1.0 In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, linux-arm-msm@vger.kernel.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="windows-1252" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: Hi, On Friday 13 January 2017 10:43 PM, Joao Pinto wrote: > Hi, > = > =C0s 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: >> *num-lanes* dt property is parsed in dw_pcie_host_init. However >> *num-lanes* property is applicable to both root complex mode and >> endpoint mode. As a first step, move the parsing of this property >> outside dw_pcie_host_init. This is in preparation for splitting >> pcie-designware.c to pcie-designware.c and pcie-designware-host.c >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> drivers/pci/dwc/pcie-designware.c | 18 +++++++++++------- >> drivers/pci/dwc/pcie-designware.h | 1 - >> 2 files changed, 11 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/pci/dwc/pcie-designware.c b/drivers/pci/dwc/pcie-de= signware.c >> index 00a0fdc..89cdb6b 100644 >> --- a/drivers/pci/dwc/pcie-designware.c >> +++ b/drivers/pci/dwc/pcie-designware.c >> @@ -551,10 +551,6 @@ int dw_pcie_host_init(struct pcie_port *pp) >> } >> } >> = >> - ret =3D of_property_read_u32(np, "num-lanes", &pci->lanes); >> - if (ret) >> - pci->lanes =3D 0; >> - >> ret =3D of_property_read_u32(np, "num-viewport", &pci->num_viewport); >> if (ret) >> pci->num_viewport =3D 2; >> @@ -751,18 +747,26 @@ static int dw_pcie_wr_conf(struct pci_bus *bus, u3= 2 devfn, >> = >> void dw_pcie_setup_rc(struct pcie_port *pp) >> { >> + int ret; >> + u32 lanes; >> u32 val; >> struct dw_pcie *pci =3D to_dw_pcie_from_pp(pp); >> + struct device *dev =3D pci->dev; >> + struct device_node *np =3D dev->of_node; >> = >> /* get iATU unroll support */ >> pci->iatu_unroll_enabled =3D dw_pcie_iatu_unroll_enabled(pci); >> dev_dbg(pci->dev, "iATU unroll: %s\n", >> pci->iatu_unroll_enabled ? "enabled" : "disabled"); >> = >> + ret =3D of_property_read_u32(np, "num-lanes", &lanes); >> + if (ret) >> + lanes =3D 0; > = > You moved from host_init to root complex setup function, which in my opin= ion did > not improve (in this scope). > = > I suggest that instead of making so much intermediary patches, which is n= ice to > understand your development sequence, but hard to review. Wouldn't be bet= ter to > condense some of the patches? We would have a cloear vision of the final = product :) I thought the other way. If squashing patches is easier to review, I'll do = it. Btw, thanks for reviewing. Cheers Kishon _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (Kishon Vijay Abraham I) Date: Mon, 16 Jan 2017 10:49:57 +0530 Subject: [PATCH 09/37] PCI: dwc: designware: Parse *num-lanes* property in dw_pcie_setup_rc In-Reply-To: References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-10-git-send-email-kishon@ti.com> Message-ID: <587C57FD.7050601@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Friday 13 January 2017 10:43 PM, Joao Pinto wrote: > Hi, > > ?s 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: >> *num-lanes* dt property is parsed in dw_pcie_host_init. However >> *num-lanes* property is applicable to both root complex mode and >> endpoint mode. As a first step, move the parsing of this property >> outside dw_pcie_host_init. This is in preparation for splitting >> pcie-designware.c to pcie-designware.c and pcie-designware-host.c >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> drivers/pci/dwc/pcie-designware.c | 18 +++++++++++------- >> drivers/pci/dwc/pcie-designware.h | 1 - >> 2 files changed, 11 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/pci/dwc/pcie-designware.c b/drivers/pci/dwc/pcie-designware.c >> index 00a0fdc..89cdb6b 100644 >> --- a/drivers/pci/dwc/pcie-designware.c >> +++ b/drivers/pci/dwc/pcie-designware.c >> @@ -551,10 +551,6 @@ int dw_pcie_host_init(struct pcie_port *pp) >> } >> } >> >> - ret = of_property_read_u32(np, "num-lanes", &pci->lanes); >> - if (ret) >> - pci->lanes = 0; >> - >> ret = of_property_read_u32(np, "num-viewport", &pci->num_viewport); >> if (ret) >> pci->num_viewport = 2; >> @@ -751,18 +747,26 @@ static int dw_pcie_wr_conf(struct pci_bus *bus, u32 devfn, >> >> void dw_pcie_setup_rc(struct pcie_port *pp) >> { >> + int ret; >> + u32 lanes; >> u32 val; >> struct dw_pcie *pci = to_dw_pcie_from_pp(pp); >> + struct device *dev = pci->dev; >> + struct device_node *np = dev->of_node; >> >> /* get iATU unroll support */ >> pci->iatu_unroll_enabled = dw_pcie_iatu_unroll_enabled(pci); >> dev_dbg(pci->dev, "iATU unroll: %s\n", >> pci->iatu_unroll_enabled ? "enabled" : "disabled"); >> >> + ret = of_property_read_u32(np, "num-lanes", &lanes); >> + if (ret) >> + lanes = 0; > > You moved from host_init to root complex setup function, which in my opinion did > not improve (in this scope). > > I suggest that instead of making so much intermediary patches, which is nice to > understand your development sequence, but hard to review. Wouldn't be better to > condense some of the patches? We would have a cloear vision of the final product :) I thought the other way. If squashing patches is easier to review, I'll do it. Btw, thanks for reviewing. Cheers Kishon