From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH 36/37] ARM: DRA7: clockdomain: Change the CLKTRCTRL of CM_PCIE_CLKSTCTRL to SW_WKUP Date: Mon, 16 Jan 2017 11:35:02 +0530 Message-ID: <587C628E.7070804@ti.com> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-37-git-send-email-kishon@ti.com> <20170113171537.GZ2630@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170113171537.GZ2630@atomide.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Tony Lindgren Cc: devicetree@vger.kernel.org, Joao Pinto , Arnd Bergmann , linux-doc@vger.kernel.org, Jingoo Han , linux-arm-msm@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, linux-samsung-soc@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas , linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org List-Id: linux-arm-msm@vger.kernel.org Hi Tony, On Friday 13 January 2017 10:45 PM, Tony Lindgren wrote: > * Kishon Vijay Abraham I [170112 02:35]: >> The PCIe programming sequence in TRM suggests CLKSTCTRL of PCIe should >> be set to SW_WKUP. There are no issues when CLKSTCTRL is set to HW_AUTO >> in RC mode. However in EP mode, the host system is not able to access the >> MEMSPACE and setting the CLKSTCTRL to SW_WKUP fixes it. > > I guess ideally in the long run we would set this dynamically based on > the selected mode, right? The programming sequence mentioned in the TRM w.r.t clock programming is same for both host mode or device mode. Though we never faced any issues in host mode when HW_AUTO is set, it's better to follow TRM recommended settings IMHO. Thanks Kishon > > Regards, > > Tony > >> Signed-off-by: Kishon Vijay Abraham I >> --- >> arch/arm/mach-omap2/clockdomains7xx_data.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-omap2/clockdomains7xx_data.c b/arch/arm/mach-omap2/clockdomains7xx_data.c >> index 6c67965..67ebff8 100644 >> --- a/arch/arm/mach-omap2/clockdomains7xx_data.c >> +++ b/arch/arm/mach-omap2/clockdomains7xx_data.c >> @@ -524,7 +524,7 @@ >> .dep_bit = DRA7XX_PCIE_STATDEP_SHIFT, >> .wkdep_srcs = pcie_wkup_sleep_deps, >> .sleepdep_srcs = pcie_wkup_sleep_deps, >> - .flags = CLKDM_CAN_HWSUP_SWSUP, >> + .flags = CLKDM_CAN_SWSUP, >> }; >> >> static struct clockdomain atl_7xx_clkdm = { >> -- >> 1.7.9.5 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751202AbdAPGFy (ORCPT ); Mon, 16 Jan 2017 01:05:54 -0500 Received: from lelnx193.ext.ti.com ([198.47.27.77]:38867 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbdAPGFv (ORCPT ); Mon, 16 Jan 2017 01:05:51 -0500 Subject: Re: [PATCH 36/37] ARM: DRA7: clockdomain: Change the CLKTRCTRL of CM_PCIE_CLKSTCTRL to SW_WKUP To: Tony Lindgren References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-37-git-send-email-kishon@ti.com> <20170113171537.GZ2630@atomide.com> CC: Bjorn Helgaas , Jingoo Han , Joao Pinto , Arnd Bergmann , , , , , , , , , , , From: Kishon Vijay Abraham I Message-ID: <587C628E.7070804@ti.com> Date: Mon, 16 Jan 2017 11:35:02 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20170113171537.GZ2630@atomide.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tony, On Friday 13 January 2017 10:45 PM, Tony Lindgren wrote: > * Kishon Vijay Abraham I [170112 02:35]: >> The PCIe programming sequence in TRM suggests CLKSTCTRL of PCIe should >> be set to SW_WKUP. There are no issues when CLKSTCTRL is set to HW_AUTO >> in RC mode. However in EP mode, the host system is not able to access the >> MEMSPACE and setting the CLKSTCTRL to SW_WKUP fixes it. > > I guess ideally in the long run we would set this dynamically based on > the selected mode, right? The programming sequence mentioned in the TRM w.r.t clock programming is same for both host mode or device mode. Though we never faced any issues in host mode when HW_AUTO is set, it's better to follow TRM recommended settings IMHO. Thanks Kishon > > Regards, > > Tony > >> Signed-off-by: Kishon Vijay Abraham I >> --- >> arch/arm/mach-omap2/clockdomains7xx_data.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-omap2/clockdomains7xx_data.c b/arch/arm/mach-omap2/clockdomains7xx_data.c >> index 6c67965..67ebff8 100644 >> --- a/arch/arm/mach-omap2/clockdomains7xx_data.c >> +++ b/arch/arm/mach-omap2/clockdomains7xx_data.c >> @@ -524,7 +524,7 @@ >> .dep_bit = DRA7XX_PCIE_STATDEP_SHIFT, >> .wkdep_srcs = pcie_wkup_sleep_deps, >> .sleepdep_srcs = pcie_wkup_sleep_deps, >> - .flags = CLKDM_CAN_HWSUP_SWSUP, >> + .flags = CLKDM_CAN_SWSUP, >> }; >> >> static struct clockdomain atl_7xx_clkdm = { >> -- >> 1.7.9.5 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH 36/37] ARM: DRA7: clockdomain: Change the CLKTRCTRL of CM_PCIE_CLKSTCTRL to SW_WKUP To: Tony Lindgren References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-37-git-send-email-kishon@ti.com> <20170113171537.GZ2630@atomide.com> From: Kishon Vijay Abraham I Message-ID: <587C628E.7070804@ti.com> Date: Mon, 16 Jan 2017 11:35:02 +0530 MIME-Version: 1.0 In-Reply-To: <20170113171537.GZ2630@atomide.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Joao Pinto , Arnd Bergmann , linux-doc@vger.kernel.org, Jingoo Han , linux-arm-msm@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, linux-samsung-soc@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas , linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: Hi Tony, On Friday 13 January 2017 10:45 PM, Tony Lindgren wrote: > * Kishon Vijay Abraham I [170112 02:35]: >> The PCIe programming sequence in TRM suggests CLKSTCTRL of PCIe should >> be set to SW_WKUP. There are no issues when CLKSTCTRL is set to HW_AUTO >> in RC mode. However in EP mode, the host system is not able to access the >> MEMSPACE and setting the CLKSTCTRL to SW_WKUP fixes it. > > I guess ideally in the long run we would set this dynamically based on > the selected mode, right? The programming sequence mentioned in the TRM w.r.t clock programming is same for both host mode or device mode. Though we never faced any issues in host mode when HW_AUTO is set, it's better to follow TRM recommended settings IMHO. Thanks Kishon > > Regards, > > Tony > >> Signed-off-by: Kishon Vijay Abraham I >> --- >> arch/arm/mach-omap2/clockdomains7xx_data.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-omap2/clockdomains7xx_data.c b/arch/arm/mach-omap2/clockdomains7xx_data.c >> index 6c67965..67ebff8 100644 >> --- a/arch/arm/mach-omap2/clockdomains7xx_data.c >> +++ b/arch/arm/mach-omap2/clockdomains7xx_data.c >> @@ -524,7 +524,7 @@ >> .dep_bit = DRA7XX_PCIE_STATDEP_SHIFT, >> .wkdep_srcs = pcie_wkup_sleep_deps, >> .sleepdep_srcs = pcie_wkup_sleep_deps, >> - .flags = CLKDM_CAN_HWSUP_SWSUP, >> + .flags = CLKDM_CAN_SWSUP, >> }; >> >> static struct clockdomain atl_7xx_clkdm = { >> -- >> 1.7.9.5 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (Kishon Vijay Abraham I) Date: Mon, 16 Jan 2017 11:35:02 +0530 Subject: [PATCH 36/37] ARM: DRA7: clockdomain: Change the CLKTRCTRL of CM_PCIE_CLKSTCTRL to SW_WKUP In-Reply-To: <20170113171537.GZ2630@atomide.com> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-37-git-send-email-kishon@ti.com> <20170113171537.GZ2630@atomide.com> Message-ID: <587C628E.7070804@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Tony, On Friday 13 January 2017 10:45 PM, Tony Lindgren wrote: > * Kishon Vijay Abraham I [170112 02:35]: >> The PCIe programming sequence in TRM suggests CLKSTCTRL of PCIe should >> be set to SW_WKUP. There are no issues when CLKSTCTRL is set to HW_AUTO >> in RC mode. However in EP mode, the host system is not able to access the >> MEMSPACE and setting the CLKSTCTRL to SW_WKUP fixes it. > > I guess ideally in the long run we would set this dynamically based on > the selected mode, right? The programming sequence mentioned in the TRM w.r.t clock programming is same for both host mode or device mode. Though we never faced any issues in host mode when HW_AUTO is set, it's better to follow TRM recommended settings IMHO. Thanks Kishon > > Regards, > > Tony > >> Signed-off-by: Kishon Vijay Abraham I >> --- >> arch/arm/mach-omap2/clockdomains7xx_data.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-omap2/clockdomains7xx_data.c b/arch/arm/mach-omap2/clockdomains7xx_data.c >> index 6c67965..67ebff8 100644 >> --- a/arch/arm/mach-omap2/clockdomains7xx_data.c >> +++ b/arch/arm/mach-omap2/clockdomains7xx_data.c >> @@ -524,7 +524,7 @@ >> .dep_bit = DRA7XX_PCIE_STATDEP_SHIFT, >> .wkdep_srcs = pcie_wkup_sleep_deps, >> .sleepdep_srcs = pcie_wkup_sleep_deps, >> - .flags = CLKDM_CAN_HWSUP_SWSUP, >> + .flags = CLKDM_CAN_SWSUP, >> }; >> >> static struct clockdomain atl_7xx_clkdm = { >> -- >> 1.7.9.5 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> the body of a message to majordomo at vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >>