From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v5 29/29] net/i40e: set/clear VF stats from PF
Date: Tue, 20 Dec 2016 13:24:35 +0000
Message-ID: <587a2f08-0541-3f99-d16f-1c14206f11e9@intel.com>
References: <20161216143919.4909-1-ferruh.yigit@intel.com>
 <20161216190257.6921-1-ferruh.yigit@intel.com>
 <20161216190257.6921-30-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: Jingjing Wu <jingjing.wu@intel.com>, Helin Zhang <helin.zhang@intel.com>,
 Qi Zhang <qi.z.zhang@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 "Chen, Jing D" <jing.d.chen@intel.com>
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 6D259FB85
 for <dev@dpdk.org>; Tue, 20 Dec 2016 14:24:58 +0100 (CET)
In-Reply-To: <20161216190257.6921-30-ferruh.yigit@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/16/2016 7:02 PM, Ferruh Yigit wrote:
> From: Qi Zhang <qi.z.zhang@intel.com>
> 
> This patch add support to get/clear VF statistics
> from PF side.
> Two APIs are added:
> rte_pmd_i40e_get_vf_stats.
> rte_pmd_i40e_reset_vf_stats.
> 
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---

<...>

> diff --git a/drivers/net/i40e/rte_pmd_i40e_version.map b/drivers/net/i40e/rte_pmd_i40e_version.map
> index 8ac1bc8..7a5d211 100644
> --- a/drivers/net/i40e/rte_pmd_i40e_version.map
> +++ b/drivers/net/i40e/rte_pmd_i40e_version.map
> @@ -6,7 +6,9 @@ DPDK_2.0 {
>  DPDK_17.02 {
>  	global:
>  
> +	rte_pmd_i40e_get_vf_stats;
>  	rte_pmd_i40e_ping_vfs;
> +	rte_pmd_i40e_reset_vf_stats;
>  	rte_pmd_i40e_set_tx_loopback;
>  	rte_pmd_i40e_set_vf_broadcast;
>  	rte_pmd_i40e_set_vf_mac_addr;

Hi Wenzhuo, Mark,

I think this is the list of all APIs added with this patchset.

Just a question, what do you think following a logic in API naming as:
<name_space>_<object>_<action> ?

So API names become:
rte_pmd_i40e_tx_loopback_set;
rte_pmd_i40e_vf_broadcast_set;
rte_pmd_i40e_vf_mac_addr_set;
rte_pmd_i40e_vfs_ping;
rte_pmd_i40e_vf_stats_get;
rte_pmd_i40e_vf_stats_reset;


After above rename, rte_pmd_i40e_tx_loopback_set() is not giving a hint
that this is something related to the PF controlling VF, perhaps we can
rename the API ?

Also rte_pmd_i40e_vfs_ping() can become rte_pmd_i40e_vf_ping_all() to be
more consistent about _vf_ usage.

Overall, they can be something like:
rte_pmd_i40e_vf_broadcast_set;
rte_pmd_i40e_vf_mac_addr_set;
rte_pmd_i40e_vf_ping_all;
rte_pmd_i40e_vf_stats_get;
rte_pmd_i40e_vf_stats_reset;
rte_pmd_i40e_vf_tx_loopback_set;

What do you think?


>