From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DB68C432BE for ; Fri, 27 Aug 2021 08:36:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7670A60EB3 for ; Fri, 27 Aug 2021 08:36:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244603AbhH0IhU (ORCPT ); Fri, 27 Aug 2021 04:37:20 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:15259 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233297AbhH0IhU (ORCPT ); Fri, 27 Aug 2021 04:37:20 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4GwtND5BGGz8BMF; Fri, 27 Aug 2021 16:36:12 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 27 Aug 2021 16:36:29 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 27 Aug 2021 16:36:28 +0800 Subject: Re: [PATCH v3 1/3] vmalloc: Choose a better start address in vm_area_register_early() To: Catalin Marinas CC: , , , , , , , , References: <20210809093750.131091-1-wangkefeng.wang@huawei.com> <20210809093750.131091-2-wangkefeng.wang@huawei.com> <20210825175953.GI3420@arm.com> From: Kefeng Wang Message-ID: <587a3a75-bbee-2ae4-8e69-563b9f277306@huawei.com> Date: Fri, 27 Aug 2021 16:36:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20210825175953.GI3420@arm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/8/26 1:59, Catalin Marinas wrote: > On Mon, Aug 09, 2021 at 05:37:48PM +0800, Kefeng Wang wrote: >> diff --git a/mm/vmalloc.c b/mm/vmalloc.c >> index d5cd52805149..1e8fe08725b8 100644 >> --- a/mm/vmalloc.c >> +++ b/mm/vmalloc.c >> @@ -2238,11 +2238,17 @@ void __init vm_area_add_early(struct vm_struct *vm) >> */ >> void __init vm_area_register_early(struct vm_struct *vm, size_t align) >> { >> - static size_t vm_init_off __initdata; >> - unsigned long addr; >> - >> - addr = ALIGN(VMALLOC_START + vm_init_off, align); >> - vm_init_off = PFN_ALIGN(addr + vm->size) - VMALLOC_START; >> + struct vm_struct *head = vmlist, *curr, *next; >> + unsigned long addr = ALIGN(VMALLOC_START, align); >> + >> + while (head != NULL) { > Nitpick: I'd use the same pattern as in vm_area_add_early(), i.e. a > 'for' loop. You might as well insert it directly than calling the add > function and going through the loop again. Not a strong preference > either way. > >> + next = head->next; >> + curr = head; >> + head = next; >> + addr = ALIGN((unsigned long)curr->addr + curr->size, align); >> + if (next && (unsigned long)next->addr - addr > vm->size) > Is greater or equal sufficient? > >> + break; >> + } >> >> vm->addr = (void *)addr; > Another nitpick: it's very unlikely on a 64-bit architecture but not > impossible on 32-bit to hit VMALLOC_END here. Maybe some BUG_ON. Hi Catalin, thank for your review, I will update in the next version, Could you take a look the following change, is it OK? void __init vm_area_register_early(struct vm_struct *vm, size_t align) {          struct vm_struct *next, *cur, **p;          unsigned long addr = ALIGN(VMALLOC_START, align); BUG_ON(vmap_initialized);          for (p = &vmlist; (cur = *p) != NULL, next = cur->next; p = &next) {                  addr = ALIGN((unsigned long)cur->addr + cur->size, align);                  if (next && (unsigned long)next->addr - addr >= vm->size) {                          p = &next; break; } }          BUG_ON(addr > VMALLOC_END - vm->size);          vm->addr = (void *)addr;          vm->next = *p;          *p = vm; } > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 251B9C432BE for ; Fri, 27 Aug 2021 08:39:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD2C560F4F for ; Fri, 27 Aug 2021 08:39:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DD2C560F4F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qbBTUpWKnbjKHTtonBdLzCSFtv3Ltx1qFRDduHeDoMc=; b=sHO5pHzCqdCP3uU/8mTHbAgo7G PAzV8IfYYYLFynzSbVx6ymLzX+wLEq7fHpziTs6rJ5Kye3CoaVhOHgekq3EOADWgwHx9pXhHTt0/g 7isCBMlrTzvA5X7yYMCmfi5YWzhMCrynIkblLZULMh7pc+4+/2aWenfmEAqkecSh8v0a7eZwfaQXD s1GWO7pdp9IvldEOne4+yuCXxmZrkVsBPwWWp+EJqK75u8LuV9krelpT3RGzZTKuu87wCvNxTz4+x 5CeWXEYQhsLnth73jRiWP7tvmFYOHRcPhkr/TEJBSQuKdfeKB16B1LwSgXa2h5RwZDM5rx6d4k48O E2kCzFtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJXLw-00Bxuc-BD; Fri, 27 Aug 2021 08:36:44 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJXLs-00Bxti-46 for linux-arm-kernel@lists.infradead.org; Fri, 27 Aug 2021 08:36:42 +0000 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4GwtND5BGGz8BMF; Fri, 27 Aug 2021 16:36:12 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 27 Aug 2021 16:36:29 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 27 Aug 2021 16:36:28 +0800 Subject: Re: [PATCH v3 1/3] vmalloc: Choose a better start address in vm_area_register_early() To: Catalin Marinas CC: , , , , , , , , References: <20210809093750.131091-1-wangkefeng.wang@huawei.com> <20210809093750.131091-2-wangkefeng.wang@huawei.com> <20210825175953.GI3420@arm.com> From: Kefeng Wang Message-ID: <587a3a75-bbee-2ae4-8e69-563b9f277306@huawei.com> Date: Fri, 27 Aug 2021 16:36:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20210825175953.GI3420@arm.com> Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210827_013640_657958_1283260C X-CRM114-Status: GOOD ( 17.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDIwMjEvOC8yNiAxOjU5LCBDYXRhbGluIE1hcmluYXMgd3JvdGU6Cj4gT24gTW9uLCBBdWcg MDksIDIwMjEgYXQgMDU6Mzc6NDhQTSArMDgwMCwgS2VmZW5nIFdhbmcgd3JvdGU6Cj4+IGRpZmYg LS1naXQgYS9tbS92bWFsbG9jLmMgYi9tbS92bWFsbG9jLmMKPj4gaW5kZXggZDVjZDUyODA1MTQ5 Li4xZThmZTA4NzI1YjggMTAwNjQ0Cj4+IC0tLSBhL21tL3ZtYWxsb2MuYwo+PiArKysgYi9tbS92 bWFsbG9jLmMKPj4gQEAgLTIyMzgsMTEgKzIyMzgsMTcgQEAgdm9pZCBfX2luaXQgdm1fYXJlYV9h ZGRfZWFybHkoc3RydWN0IHZtX3N0cnVjdCAqdm0pCj4+ICAgICovCj4+ICAgdm9pZCBfX2luaXQg dm1fYXJlYV9yZWdpc3Rlcl9lYXJseShzdHJ1Y3Qgdm1fc3RydWN0ICp2bSwgc2l6ZV90IGFsaWdu KQo+PiAgIHsKPj4gLQlzdGF0aWMgc2l6ZV90IHZtX2luaXRfb2ZmIF9faW5pdGRhdGE7Cj4+IC0J dW5zaWduZWQgbG9uZyBhZGRyOwo+PiAtCj4+IC0JYWRkciA9IEFMSUdOKFZNQUxMT0NfU1RBUlQg KyB2bV9pbml0X29mZiwgYWxpZ24pOwo+PiAtCXZtX2luaXRfb2ZmID0gUEZOX0FMSUdOKGFkZHIg KyB2bS0+c2l6ZSkgLSBWTUFMTE9DX1NUQVJUOwo+PiArCXN0cnVjdCB2bV9zdHJ1Y3QgKmhlYWQg PSB2bWxpc3QsICpjdXJyLCAqbmV4dDsKPj4gKwl1bnNpZ25lZCBsb25nIGFkZHIgPSBBTElHTihW TUFMTE9DX1NUQVJULCBhbGlnbik7Cj4+ICsKPj4gKwl3aGlsZSAoaGVhZCAhPSBOVUxMKSB7Cj4g Tml0cGljazogSSdkIHVzZSB0aGUgc2FtZSBwYXR0ZXJuIGFzIGluIHZtX2FyZWFfYWRkX2Vhcmx5 KCksIGkuZS4gYQo+ICdmb3InIGxvb3AuIFlvdSBtaWdodCBhcyB3ZWxsIGluc2VydCBpdCBkaXJl Y3RseSB0aGFuIGNhbGxpbmcgdGhlIGFkZAo+IGZ1bmN0aW9uIGFuZCBnb2luZyB0aHJvdWdoIHRo ZSBsb29wIGFnYWluLiBOb3QgYSBzdHJvbmcgcHJlZmVyZW5jZQo+IGVpdGhlciB3YXkuCj4KPj4g KwkJbmV4dCA9IGhlYWQtPm5leHQ7Cj4+ICsJCWN1cnIgPSBoZWFkOwo+PiArCQloZWFkID0gbmV4 dDsKPj4gKwkJYWRkciA9IEFMSUdOKCh1bnNpZ25lZCBsb25nKWN1cnItPmFkZHIgKyBjdXJyLT5z aXplLCBhbGlnbik7Cj4+ICsJCWlmIChuZXh0ICYmICh1bnNpZ25lZCBsb25nKW5leHQtPmFkZHIg LSBhZGRyID4gdm0tPnNpemUpCj4gSXMgZ3JlYXRlciBvciBlcXVhbCBzdWZmaWNpZW50Pwo+Cj4+ ICsJCQlicmVhazsKPj4gKwl9Cj4+ICAgCj4+ICAgCXZtLT5hZGRyID0gKHZvaWQgKilhZGRyOwo+ IEFub3RoZXIgbml0cGljazogaXQncyB2ZXJ5IHVubGlrZWx5IG9uIGEgNjQtYml0IGFyY2hpdGVj dHVyZSBidXQgbm90Cj4gaW1wb3NzaWJsZSBvbiAzMi1iaXQgdG8gaGl0IFZNQUxMT0NfRU5EIGhl cmUuIE1heWJlIHNvbWUgQlVHX09OLgoKSGkgQ2F0YWxpbiwgdGhhbmsgZm9yIHlvdXIgcmV2aWV3 LCBJIHdpbGwgdXBkYXRlIGluIHRoZSBuZXh0IHZlcnNpb24sCgpDb3VsZCB5b3UgdGFrZSBhIGxv b2sgdGhlIGZvbGxvd2luZyBjaGFuZ2UsIGlzIGl0IE9LPwoKdm9pZCBfX2luaXQgdm1fYXJlYV9y ZWdpc3Rlcl9lYXJseShzdHJ1Y3Qgdm1fc3RydWN0ICp2bSwgc2l6ZV90IGFsaWduKQoKewoKIMKg wqDCoMKgwqDCoMKgwqAgc3RydWN0IHZtX3N0cnVjdCAqbmV4dCwgKmN1ciwgKipwOwogwqDCoMKg wqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIGFkZHIgPSBBTElHTihWTUFMTE9DX1NUQVJULCBhbGln bik7CkJVR19PTih2bWFwX2luaXRpYWxpemVkKTsKCiDCoMKgwqDCoMKgwqDCoMKgIGZvciAocCA9 ICZ2bWxpc3Q7IChjdXIgPSAqcCkgIT0gTlVMTCwgbmV4dCA9IGN1ci0+bmV4dDsgcCA9IAombmV4 dCkgewogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgYWRkciA9IEFMSUdOKCh1bnNp Z25lZCBsb25nKWN1ci0+YWRkciArIGN1ci0+c2l6ZSwgCmFsaWduKTsKIMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIGlmIChuZXh0ICYmICh1bnNpZ25lZCBsb25nKW5leHQtPmFkZHIg LSBhZGRyID49IAp2bS0+c2l6ZSkgewogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIHAgPSAmbmV4dDsKYnJlYWs7Cn0KfQoKIMKgwqDCoMKgwqDCoMKgwqAg QlVHX09OKGFkZHIgPiBWTUFMTE9DX0VORCAtIHZtLT5zaXplKTsKIMKgwqDCoMKgwqDCoMKgwqAg dm0tPmFkZHIgPSAodm9pZCAqKWFkZHI7CiDCoMKgwqDCoMKgwqDCoMKgIHZtLT5uZXh0ID0gKnA7 CiDCoMKgwqDCoMKgwqDCoMKgICpwID0gdm07Cn0KCgo+CgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==