All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@infradead.org>,
	Bart Van Assche <bvanassche@acm.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
	"yi.zhang@redhat.com" <yi.zhang@redhat.com>,
	"sagi@grimberg.me" <sagi@grimberg.me>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: can't run nvme-mp blktests
Date: Fri, 15 Apr 2022 05:58:16 +0000	[thread overview]
Message-ID: <587c14e7-2b7e-74ac-377b-6faafcb829e4@nvidia.com> (raw)
In-Reply-To: <YlkAlHe6LloUAzzN@infradead.org>

On 4/14/22 22:20, Christoph Hellwig wrote:
> On Wed, Apr 13, 2022 at 03:46:16PM -0700, Bart Van Assche wrote:
>> I'm not sure whether the nvme-mp tests test any code that is not yet tested by
>> any nvme or srp test. How about removing these tests since these tests make
>> it harder than necessary to run blktests?
> 
> I haven't looked at the details recently, but if these tests still are
> basically a copy and paste of the srp mpath tests I'm all for removing
> them!

If it doesn't add a new test coverage in the blktest framework
then please remove.

-ck


  reply	other threads:[~2022-04-15  5:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13  0:24 can't run nvme-mp blktests Luis Chamberlain
2022-04-13  3:02 ` Yi Zhang
2022-04-13 17:38   ` Luis Chamberlain
2022-04-13  4:53 ` Christoph Hellwig
2022-04-13 17:38   ` Luis Chamberlain
2022-04-13 17:41     ` Christoph Hellwig
2022-04-13 18:12       ` Luis Chamberlain
2022-04-15  5:22         ` Christoph Hellwig
2022-04-13 22:46       ` Bart Van Assche
2022-04-15  5:20         ` Christoph Hellwig
2022-04-15  5:58           ` Chaitanya Kulkarni [this message]
2022-04-15 17:59             ` Luis Chamberlain
2022-04-15 18:09               ` Bart Van Assche
2022-04-20 10:36                 ` Hannes Reinecke
2022-04-21 17:56                 ` Luis Chamberlain
2022-04-15 18:06             ` Bart Van Assche
2022-04-20 10:29               ` Hannes Reinecke
2022-04-13  5:53 ` Bart Van Assche
2022-04-13 18:08   ` Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=587c14e7-2b7e-74ac-377b-6faafcb829e4@nvidia.com \
    --to=chaitanyak@nvidia.com \
    --cc=bvanassche@acm.org \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mcgrof@kernel.org \
    --cc=sagi@grimberg.me \
    --cc=yi.zhang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.