From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754187AbdASSVp (ORCPT ); Thu, 19 Jan 2017 13:21:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44134 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753667AbdASSVl (ORCPT ); Thu, 19 Jan 2017 13:21:41 -0500 Subject: Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host. To: Dan Carpenter References: <1484771338-8903-1-git-send-email-cavery@redhat.com> <1484771338-8903-3-git-send-email-cavery@redhat.com> <20170118231555.GC4454@mwanda> Cc: kys@microsoft.com, haiyangz@microsoft.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org From: Cathy Avery Message-ID: <5880FD8F.8020608@redhat.com> Date: Thu, 19 Jan 2017 12:55:27 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20170118231555.GC4454@mwanda> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 19 Jan 2017 17:55:29 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/18/2017 06:15 PM, Dan Carpenter wrote: > On Wed, Jan 18, 2017 at 03:28:58PM -0500, Cathy Avery wrote: >> Enable FC lightweight host option so that the luns exposed by >> the driver may be manually scanned. >> >> Signed-off-by: Cathy Avery >> --- >> drivers/scsi/storvsc_drv.c | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) >> >> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c >> index 888e16e..fc1d6ba 100644 >> --- a/drivers/scsi/storvsc_drv.c >> +++ b/drivers/scsi/storvsc_drv.c >> @@ -1882,6 +1882,7 @@ static struct hv_driver storvsc_drv = { >> static struct fc_function_template fc_transport_functions = { >> .show_host_node_name = 1, >> .show_host_port_name = 1, >> + .lightweight_transport = 1, >> }; >> #endif >> >> @@ -1906,11 +1907,6 @@ static int __init storvsc_drv_init(void) >> fc_transport_template = fc_attach_transport(&fc_transport_functions); >> if (!fc_transport_template) >> return -ENODEV; >> - >> - /* >> - * Install Hyper-V specific timeout handler. >> - */ >> - fc_transport_template->eh_timed_out = storvsc_eh_timed_out; > I don't undestand how removing this is related. Its not related but it is also not necessary so I took it out. The default scsi timeout handler will be used. I can certainly put it back. Cathy > > regards, > dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cathy Avery Subject: Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host. Date: Thu, 19 Jan 2017 12:55:27 -0500 Message-ID: <5880FD8F.8020608@redhat.com> References: <1484771338-8903-1-git-send-email-cavery@redhat.com> <1484771338-8903-3-git-send-email-cavery@redhat.com> <20170118231555.GC4454@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170118231555.GC4454@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Dan Carpenter Cc: jejb@linux.vnet.ibm.com, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, haiyangz@microsoft.com, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org List-Id: linux-scsi@vger.kernel.org On 01/18/2017 06:15 PM, Dan Carpenter wrote: > On Wed, Jan 18, 2017 at 03:28:58PM -0500, Cathy Avery wrote: >> Enable FC lightweight host option so that the luns exposed by >> the driver may be manually scanned. >> >> Signed-off-by: Cathy Avery >> --- >> drivers/scsi/storvsc_drv.c | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) >> >> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c >> index 888e16e..fc1d6ba 100644 >> --- a/drivers/scsi/storvsc_drv.c >> +++ b/drivers/scsi/storvsc_drv.c >> @@ -1882,6 +1882,7 @@ static struct hv_driver storvsc_drv = { >> static struct fc_function_template fc_transport_functions = { >> .show_host_node_name = 1, >> .show_host_port_name = 1, >> + .lightweight_transport = 1, >> }; >> #endif >> >> @@ -1906,11 +1907,6 @@ static int __init storvsc_drv_init(void) >> fc_transport_template = fc_attach_transport(&fc_transport_functions); >> if (!fc_transport_template) >> return -ENODEV; >> - >> - /* >> - * Install Hyper-V specific timeout handler. >> - */ >> - fc_transport_template->eh_timed_out = storvsc_eh_timed_out; > I don't undestand how removing this is related. Its not related but it is also not necessary so I took it out. The default scsi timeout handler will be used. I can certainly put it back. Cathy > > regards, > dan carpenter