From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 2/5] arm64: dts: renesas: r8a77980: add VSPD support Date: Fri, 08 Jun 2018 17:01:57 +0300 Message-ID: <5881797.ZzEO2jGKGA@avalon> References: <390fabf0-4caf-1600-3780-1893207d94f7@cogentembedded.com> <5f151ec5-bec7-ed06-cb94-4f0cfe8e43dc@cogentembedded.com> <20180608135456.cathgcuyp24csbwx@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180608135456.cathgcuyp24csbwx@verge.net.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Simon Horman Cc: Mark Rutland , devicetree@vger.kernel.org, Magnus Damm , Geert Uytterhoeven , Sergei Shtylyov , Catalin Marinas , Will Deacon , linux-renesas-soc@vger.kernel.org, Rob Herring , Laurent Pinchart , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hello Simon, On Friday, 8 June 2018 16:54:56 EEST Simon Horman wrote: > [CC Laurent, Geert] > > On Thu, Jun 07, 2018 at 11:20:47PM +0300, Sergei Shtylyov wrote: > > Describe VSPD0 in the R8A77980 device tree; it will be used by DU in > > the next patch... > > > > Based on the original (and large) patch by Vladimir Barinov. > > > > Signed-off-by: Vladimir Barinov > > Signed-off-by: Sergei Shtylyov > > > > --- > > > > arch/arm64/boot/dts/renesas/r8a77980.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi > > =================================================================== > > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi > > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi > > @@ -653,6 +653,16 @@ > > resets = <&cpg 408>; > > }; > > > > + vspd0: vsp@fea20000 { > > + compatible = "renesas,vsp2"; > > + reg = <0 0xfea20000 0 0x4000>; > > As per "[PATCH] arm64: dts: renesas: Fix VSPD registers range" > I think the width of the range should be 0x5000. I agree with that. > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 623>; > > + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; > > + resets = <&cpg 623>; > > + renesas,fcp = <&fcpvd0>; > > + }; > > + > > fcpvd0: fcp@fea27000 { > > compatible = "renesas,fcpv"; > > reg = <0 0xfea27000 0 0x200>; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Laurent Pinchart To: Simon Horman Cc: Sergei Shtylyov , Rob Herring , Catalin Marinas , Will Deacon , linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, Magnus Damm , Mark Rutland , linux-arm-kernel@lists.infradead.org, Laurent Pinchart , Geert Uytterhoeven Subject: Re: [PATCH v2 2/5] arm64: dts: renesas: r8a77980: add VSPD support Date: Fri, 08 Jun 2018 17:01:57 +0300 Message-ID: <5881797.ZzEO2jGKGA@avalon> In-Reply-To: <20180608135456.cathgcuyp24csbwx@verge.net.au> References: <390fabf0-4caf-1600-3780-1893207d94f7@cogentembedded.com> <5f151ec5-bec7-ed06-cb94-4f0cfe8e43dc@cogentembedded.com> <20180608135456.cathgcuyp24csbwx@verge.net.au> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: devicetree-owner@vger.kernel.org List-ID: Hello Simon, On Friday, 8 June 2018 16:54:56 EEST Simon Horman wrote: > [CC Laurent, Geert] > > On Thu, Jun 07, 2018 at 11:20:47PM +0300, Sergei Shtylyov wrote: > > Describe VSPD0 in the R8A77980 device tree; it will be used by DU in > > the next patch... > > > > Based on the original (and large) patch by Vladimir Barinov. > > > > Signed-off-by: Vladimir Barinov > > Signed-off-by: Sergei Shtylyov > > > > --- > > > > arch/arm64/boot/dts/renesas/r8a77980.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi > > =================================================================== > > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi > > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi > > @@ -653,6 +653,16 @@ > > resets = <&cpg 408>; > > }; > > > > + vspd0: vsp@fea20000 { > > + compatible = "renesas,vsp2"; > > + reg = <0 0xfea20000 0 0x4000>; > > As per "[PATCH] arm64: dts: renesas: Fix VSPD registers range" > I think the width of the range should be 0x5000. I agree with that. > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 623>; > > + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; > > + resets = <&cpg 623>; > > + renesas,fcp = <&fcpvd0>; > > + }; > > + > > fcpvd0: fcp@fea27000 { > > compatible = "renesas,fcpv"; > > reg = <0 0xfea27000 0 0x200>; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Fri, 08 Jun 2018 17:01:57 +0300 Subject: [PATCH v2 2/5] arm64: dts: renesas: r8a77980: add VSPD support In-Reply-To: <20180608135456.cathgcuyp24csbwx@verge.net.au> References: <390fabf0-4caf-1600-3780-1893207d94f7@cogentembedded.com> <5f151ec5-bec7-ed06-cb94-4f0cfe8e43dc@cogentembedded.com> <20180608135456.cathgcuyp24csbwx@verge.net.au> Message-ID: <5881797.ZzEO2jGKGA@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Simon, On Friday, 8 June 2018 16:54:56 EEST Simon Horman wrote: > [CC Laurent, Geert] > > On Thu, Jun 07, 2018 at 11:20:47PM +0300, Sergei Shtylyov wrote: > > Describe VSPD0 in the R8A77980 device tree; it will be used by DU in > > the next patch... > > > > Based on the original (and large) patch by Vladimir Barinov. > > > > Signed-off-by: Vladimir Barinov > > Signed-off-by: Sergei Shtylyov > > > > --- > > > > arch/arm64/boot/dts/renesas/r8a77980.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi > > =================================================================== > > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi > > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi > > @@ -653,6 +653,16 @@ > > resets = <&cpg 408>; > > }; > > > > + vspd0: vsp at fea20000 { > > + compatible = "renesas,vsp2"; > > + reg = <0 0xfea20000 0 0x4000>; > > As per "[PATCH] arm64: dts: renesas: Fix VSPD registers range" > I think the width of the range should be 0x5000. I agree with that. > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 623>; > > + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; > > + resets = <&cpg 623>; > > + renesas,fcp = <&fcpvd0>; > > + }; > > + > > fcpvd0: fcp at fea27000 { > > compatible = "renesas,fcpv"; > > reg = <0 0xfea27000 0 0x200>; -- Regards, Laurent Pinchart