From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751210AbdAVDJ5 (ORCPT ); Sat, 21 Jan 2017 22:09:57 -0500 Received: from regular1.263xmail.com ([211.150.99.134]:43482 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750741AbdAVDJk (ORCPT ); Sat, 21 Jan 2017 22:09:40 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: zyw@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: zyw@rock-chips.com X-UNIQUE-TAG: <0369acd0922eb99fc8695dbac283cc61> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 26/26] drm/rockchip: dw-mipi-dsi: support read commands To: John Keeping , Mark Yao References: <20170121163128.22240-1-john@metanate.com> <20170121163128.22240-27-john@metanate.com> Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org From: Chris Zhong Message-ID: <58842245.6000103@rock-chips.com> Date: Sun, 22 Jan 2017 11:08:53 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20170121163128.22240-27-john@metanate.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John On 01/22/2017 12:31 AM, John Keeping wrote: > I haven't found any method for getting the length of a response, so this > just uses the requested rx_len > > Signed-off-by: John Keeping > --- > Unchanged in v2 > --- > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 54 ++++++++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > index f780401e8b5e..f0cb005c6d76 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -675,6 +675,54 @@ static int dw_mipi_dsi_dcs_long_write(struct dw_mipi_dsi *dsi, > return dw_mipi_dsi_gen_pkt_hdr_write(dsi, hdr_val); > } > > +static int dw_mipi_dsi_dcs_read(struct dw_mipi_dsi *dsi, > + const struct mipi_dsi_msg *msg) > +{ > + const u8 *tx_buf = msg->tx_buf; > + u8 *rx_buf = msg->rx_buf; > + size_t i; > + int ret, val; > + > + dsi_write(dsi, DSI_PCKHDL_CFG, EN_CRC_RX | EN_ECC_RX | EN_BTA); > + dsi_write(dsi, DSI_GEN_HDR, GEN_HDATA(tx_buf[0]) | GEN_HTYPE(msg->type)); WARNING: line over 80 characters > + > + ret = readl_poll_timeout(dsi->base + DSI_CMD_PKT_STATUS, > + val, !(val & GEN_RD_CMD_BUSY), 1000, > + CMD_PKT_STATUS_TIMEOUT_US); > + if (ret < 0) { > + dev_err(dsi->dev, "failed to read command response\n"); > + return ret; > + } > + > + for (i = 0; i < msg->rx_len;) { > + u32 pld = dsi_read(dsi, DSI_GEN_PLD_DATA); > + while (i < msg->rx_len) { > + rx_buf[i] = pld & 0xff; > + pld >>= 8; > + i++; > + } > + } > + > + return msg->rx_len; > +} > + > +static int dw_mipi_dsi_set_max_return_packet_size(struct dw_mipi_dsi *dsi, > + size_t len) > +{ > + u8 val[] = { len & 0xff, (len >> 8) & 0xff }; > + struct mipi_dsi_msg msg = { > + .channel = dsi->channel, > + .type = MIPI_DSI_SET_MAXIMUM_RETURN_PACKET_SIZE, > + .tx_buf = val, > + .tx_len = 2, > + }; > + > + if (len > 0xffff) > + return -EINVAL; > + > + return dw_mipi_dsi_dcs_short_write(dsi, &msg); > +} > + > static ssize_t dw_mipi_dsi_host_transfer(struct mipi_dsi_host *host, > const struct mipi_dsi_msg *msg) > { > @@ -692,6 +740,12 @@ static ssize_t dw_mipi_dsi_host_transfer(struct mipi_dsi_host *host, > case MIPI_DSI_DCS_LONG_WRITE: > ret = dw_mipi_dsi_dcs_long_write(dsi, msg); > break; > + case MIPI_DSI_DCS_READ: > + ret = dw_mipi_dsi_set_max_return_packet_size(dsi, msg->rx_len); > + if (ret < 0) > + return ret; > + ret = dw_mipi_dsi_dcs_read(dsi, msg); > + break; > default: > dev_err(dsi->dev, "unsupported message type 0x%02x\n", > msg->type); From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Zhong Subject: Re: [PATCH v2 26/26] drm/rockchip: dw-mipi-dsi: support read commands Date: Sun, 22 Jan 2017 11:08:53 +0800 Message-ID: <58842245.6000103@rock-chips.com> References: <20170121163128.22240-1-john@metanate.com> <20170121163128.22240-27-john@metanate.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170121163128.22240-27-john@metanate.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Keeping , Mark Yao Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org SGkgSm9obgoKT24gMDEvMjIvMjAxNyAxMjozMSBBTSwgSm9obiBLZWVwaW5nIHdyb3RlOgo+IEkg aGF2ZW4ndCBmb3VuZCBhbnkgbWV0aG9kIGZvciBnZXR0aW5nIHRoZSBsZW5ndGggb2YgYSByZXNw b25zZSwgc28gdGhpcwo+IGp1c3QgdXNlcyB0aGUgcmVxdWVzdGVkIHJ4X2xlbgo+Cj4gU2lnbmVk LW9mZi1ieTogSm9obiBLZWVwaW5nIDxqb2huQG1ldGFuYXRlLmNvbT4KPiAtLS0KPiBVbmNoYW5n ZWQgaW4gdjIKPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS5j IHwgNTQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICAgMSBmaWxlIGNoYW5n ZWQsIDU0IGluc2VydGlvbnMoKykKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcm9j a2NoaXAvZHctbWlwaS1kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1taXBpLWRz aS5jCj4gaW5kZXggZjc4MDQwMWU4YjVlLi5mMGNiMDA1YzZkNzYgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3LW1pcGktZHNpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vcm9ja2NoaXAvZHctbWlwaS1kc2kuYwo+IEBAIC02NzUsNiArNjc1LDU0IEBAIHN0YXRpYyBp bnQgZHdfbWlwaV9kc2lfZGNzX2xvbmdfd3JpdGUoc3RydWN0IGR3X21pcGlfZHNpICpkc2ksCj4g ICAJcmV0dXJuIGR3X21pcGlfZHNpX2dlbl9wa3RfaGRyX3dyaXRlKGRzaSwgaGRyX3ZhbCk7Cj4g ICB9Cj4gICAKPiArc3RhdGljIGludCBkd19taXBpX2RzaV9kY3NfcmVhZChzdHJ1Y3QgZHdfbWlw aV9kc2kgKmRzaSwKPiArCQkJCWNvbnN0IHN0cnVjdCBtaXBpX2RzaV9tc2cgKm1zZykKPiArewo+ ICsJY29uc3QgdTggKnR4X2J1ZiA9IG1zZy0+dHhfYnVmOwo+ICsJdTggKnJ4X2J1ZiA9IG1zZy0+ cnhfYnVmOwo+ICsJc2l6ZV90IGk7Cj4gKwlpbnQgcmV0LCB2YWw7Cj4gKwo+ICsJZHNpX3dyaXRl KGRzaSwgRFNJX1BDS0hETF9DRkcsIEVOX0NSQ19SWCB8IEVOX0VDQ19SWCB8IEVOX0JUQSk7Cj4g Kwlkc2lfd3JpdGUoZHNpLCBEU0lfR0VOX0hEUiwgR0VOX0hEQVRBKHR4X2J1ZlswXSkgfCBHRU5f SFRZUEUobXNnLT50eXBlKSk7CgpXQVJOSU5HOiBsaW5lIG92ZXIgODAgY2hhcmFjdGVycwoKPiAr Cj4gKwlyZXQgPSByZWFkbF9wb2xsX3RpbWVvdXQoZHNpLT5iYXNlICsgRFNJX0NNRF9QS1RfU1RB VFVTLAo+ICsJCQkJIHZhbCwgISh2YWwgJiBHRU5fUkRfQ01EX0JVU1kpLCAxMDAwLAo+ICsJCQkJ IENNRF9QS1RfU1RBVFVTX1RJTUVPVVRfVVMpOwo+ICsJaWYgKHJldCA8IDApIHsKPiArCQlkZXZf ZXJyKGRzaS0+ZGV2LCAiZmFpbGVkIHRvIHJlYWQgY29tbWFuZCByZXNwb25zZVxuIik7Cj4gKwkJ cmV0dXJuIHJldDsKPiArCX0KPiArCj4gKwlmb3IgKGkgPSAwOyBpIDwgbXNnLT5yeF9sZW47KSB7 Cj4gKwkJdTMyIHBsZCA9IGRzaV9yZWFkKGRzaSwgRFNJX0dFTl9QTERfREFUQSk7Cj4gKwkJd2hp bGUgKGkgPCBtc2ctPnJ4X2xlbikgewo+ICsJCQlyeF9idWZbaV0gPSBwbGQgJiAweGZmOwo+ICsJ CQlwbGQgPj49IDg7Cj4gKwkJCWkrKzsKPiArCQl9Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIG1zZy0+ cnhfbGVuOwo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IGR3X21pcGlfZHNpX3NldF9tYXhfcmV0dXJu X3BhY2tldF9zaXplKHN0cnVjdCBkd19taXBpX2RzaSAqZHNpLAo+ICsJCQkJCQkgIHNpemVfdCBs ZW4pCj4gK3sKPiArCXU4IHZhbFtdID0geyBsZW4gJiAweGZmLCAobGVuID4+IDgpICYgMHhmZiB9 Owo+ICsJc3RydWN0IG1pcGlfZHNpX21zZyBtc2cgPSB7Cj4gKwkJLmNoYW5uZWwgPSBkc2ktPmNo YW5uZWwsCj4gKwkJLnR5cGUgPSBNSVBJX0RTSV9TRVRfTUFYSU1VTV9SRVRVUk5fUEFDS0VUX1NJ WkUsCj4gKwkJLnR4X2J1ZiA9IHZhbCwKPiArCQkudHhfbGVuID0gMiwKPiArCX07Cj4gKwo+ICsJ aWYgKGxlbiA+IDB4ZmZmZikKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiArCj4gKwlyZXR1cm4gZHdf bWlwaV9kc2lfZGNzX3Nob3J0X3dyaXRlKGRzaSwgJm1zZyk7Cj4gK30KPiArCj4gICBzdGF0aWMg c3NpemVfdCBkd19taXBpX2RzaV9ob3N0X3RyYW5zZmVyKHN0cnVjdCBtaXBpX2RzaV9ob3N0ICpo b3N0LAo+ICAgCQkJCQkgY29uc3Qgc3RydWN0IG1pcGlfZHNpX21zZyAqbXNnKQo+ICAgewo+IEBA IC02OTIsNiArNzQwLDEyIEBAIHN0YXRpYyBzc2l6ZV90IGR3X21pcGlfZHNpX2hvc3RfdHJhbnNm ZXIoc3RydWN0IG1pcGlfZHNpX2hvc3QgKmhvc3QsCj4gICAJY2FzZSBNSVBJX0RTSV9EQ1NfTE9O R19XUklURToKPiAgIAkJcmV0ID0gZHdfbWlwaV9kc2lfZGNzX2xvbmdfd3JpdGUoZHNpLCBtc2cp Owo+ICAgCQlicmVhazsKPiArCWNhc2UgTUlQSV9EU0lfRENTX1JFQUQ6Cj4gKwkJcmV0ID0gZHdf bWlwaV9kc2lfc2V0X21heF9yZXR1cm5fcGFja2V0X3NpemUoZHNpLCBtc2ctPnJ4X2xlbik7Cj4g KwkJaWYgKHJldCA8IDApCj4gKwkJCXJldHVybiByZXQ7Cj4gKwkJcmV0ID0gZHdfbWlwaV9kc2lf ZGNzX3JlYWQoZHNpLCBtc2cpOwo+ICsJCWJyZWFrOwo+ICAgCWRlZmF1bHQ6Cj4gICAJCWRldl9l cnIoZHNpLT5kZXYsICJ1bnN1cHBvcnRlZCBtZXNzYWdlIHR5cGUgMHglMDJ4XG4iLAo+ICAgCQkJ bXNnLT50eXBlKTsKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: zyw@rock-chips.com (Chris Zhong) Date: Sun, 22 Jan 2017 11:08:53 +0800 Subject: [PATCH v2 26/26] drm/rockchip: dw-mipi-dsi: support read commands In-Reply-To: <20170121163128.22240-27-john@metanate.com> References: <20170121163128.22240-1-john@metanate.com> <20170121163128.22240-27-john@metanate.com> Message-ID: <58842245.6000103@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi John On 01/22/2017 12:31 AM, John Keeping wrote: > I haven't found any method for getting the length of a response, so this > just uses the requested rx_len > > Signed-off-by: John Keeping > --- > Unchanged in v2 > --- > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 54 ++++++++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > index f780401e8b5e..f0cb005c6d76 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -675,6 +675,54 @@ static int dw_mipi_dsi_dcs_long_write(struct dw_mipi_dsi *dsi, > return dw_mipi_dsi_gen_pkt_hdr_write(dsi, hdr_val); > } > > +static int dw_mipi_dsi_dcs_read(struct dw_mipi_dsi *dsi, > + const struct mipi_dsi_msg *msg) > +{ > + const u8 *tx_buf = msg->tx_buf; > + u8 *rx_buf = msg->rx_buf; > + size_t i; > + int ret, val; > + > + dsi_write(dsi, DSI_PCKHDL_CFG, EN_CRC_RX | EN_ECC_RX | EN_BTA); > + dsi_write(dsi, DSI_GEN_HDR, GEN_HDATA(tx_buf[0]) | GEN_HTYPE(msg->type)); WARNING: line over 80 characters > + > + ret = readl_poll_timeout(dsi->base + DSI_CMD_PKT_STATUS, > + val, !(val & GEN_RD_CMD_BUSY), 1000, > + CMD_PKT_STATUS_TIMEOUT_US); > + if (ret < 0) { > + dev_err(dsi->dev, "failed to read command response\n"); > + return ret; > + } > + > + for (i = 0; i < msg->rx_len;) { > + u32 pld = dsi_read(dsi, DSI_GEN_PLD_DATA); > + while (i < msg->rx_len) { > + rx_buf[i] = pld & 0xff; > + pld >>= 8; > + i++; > + } > + } > + > + return msg->rx_len; > +} > + > +static int dw_mipi_dsi_set_max_return_packet_size(struct dw_mipi_dsi *dsi, > + size_t len) > +{ > + u8 val[] = { len & 0xff, (len >> 8) & 0xff }; > + struct mipi_dsi_msg msg = { > + .channel = dsi->channel, > + .type = MIPI_DSI_SET_MAXIMUM_RETURN_PACKET_SIZE, > + .tx_buf = val, > + .tx_len = 2, > + }; > + > + if (len > 0xffff) > + return -EINVAL; > + > + return dw_mipi_dsi_dcs_short_write(dsi, &msg); > +} > + > static ssize_t dw_mipi_dsi_host_transfer(struct mipi_dsi_host *host, > const struct mipi_dsi_msg *msg) > { > @@ -692,6 +740,12 @@ static ssize_t dw_mipi_dsi_host_transfer(struct mipi_dsi_host *host, > case MIPI_DSI_DCS_LONG_WRITE: > ret = dw_mipi_dsi_dcs_long_write(dsi, msg); > break; > + case MIPI_DSI_DCS_READ: > + ret = dw_mipi_dsi_set_max_return_packet_size(dsi, msg->rx_len); > + if (ret < 0) > + return ret; > + ret = dw_mipi_dsi_dcs_read(dsi, msg); > + break; > default: > dev_err(dsi->dev, "unsupported message type 0x%02x\n", > msg->type);