Re: [PATCH] Makefile: enable -Wsparse-error for DEVELOPER build

[Ramsay Jones <ramsay@ramsayjones.plus.com>]

On 04/11/2020 18:11, Junio C Hamano wrote:
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> 
>> On 04/11/2020 13:43, Johannes Schindelin wrote:
>>> Hi Ramsay,
>>>
>>> On Tue, 3 Nov 2020, Ramsay Jones wrote:
>>>
>>>> On 02/11/2020 18:55, Junio C Hamano wrote:
>>>>
>>>>> CI builds already have enough stuff around invocation of "make test"
>>>>> etc., and it would be trivial to pass SPARSE_FLAGS from the command
>>>>> line when adding "make sparse" invocation to one of the scripts in ci/
>>>>> directory, so from that point of view, this patch is not needed for
>>>>> them, either.
>>>>
>>>> My concern was more about how the CI system obtains/installs/builds a
>>>> sufficiently new version of sparse. Otherwise, 'make sparse' won't do
>>>> very much. ;-)  As I said, I don't know what's involved in getting that
>>>> to work.
>>>
>>> As mentioned in https://github.com/gitgitgadget/git/issues/345, there is a
>>> Pipeline that builds sparse packages for Ubuntu, ready for use in our CI
>>> build: https://dev.azure.com/git/git/_build?definitionId=10&_a=summary.
>>> Currently, it is scheduled to run every weekday at 5:00am (I assume that's
>>> UTC).
>>
>> Oh-my! Has there been a CI 'make sparse' build since september last year? :-D
>> I missed that! (I couldn't view the azure build summary given above - it just
>> keeps asking for a user/password :( ).
> 
> Hmph, is that what Dscho said?
> 
> I thought he was just saying packaged versions of latest sparse
> usable on Ubuntu are regularly available so those who wants to add
> "make sparse" to our jobs have a place to fetch it from.

Ah, yes. Having read that again, I think your interpretation is correct.

Ahem. My mistake. Still, it's good to know that a suitable version of
sparse is available should anyone need it.

Thanks!

ATB,
Ramsay Jones