From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roopa Prabhu Subject: Re: [PATCH cumulus-4.1.y 1/5] vxlan: flush fdb entries on oper down Date: Mon, 23 Jan 2017 16:11:44 -0800 Message-ID: <58869BC0.7090308@cumulusnetworks.com> References: <1484984410-3304-1-git-send-email-roopa@cumulusnetworks.com> <20170123085945.36404cf0@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org, ramanb@cumulusnetworks.com, jbenc@redhat.com, pshelar@ovn.org To: Stephen Hemminger Return-path: Received: from mail-pf0-f179.google.com ([209.85.192.179]:36857 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbdAXALq (ORCPT ); Mon, 23 Jan 2017 19:11:46 -0500 Received: by mail-pf0-f179.google.com with SMTP id 189so45042522pfu.3 for ; Mon, 23 Jan 2017 16:11:46 -0800 (PST) In-Reply-To: <20170123085945.36404cf0@xeon-e3> Sender: netdev-owner@vger.kernel.org List-ID: On 1/23/17, 8:59 AM, Stephen Hemminger wrote: > On Fri, 20 Jan 2017 23:40:06 -0800 > Roopa Prabhu wrote: > >> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c >> index 19b1653..15b1c23 100644 >> --- a/drivers/net/vxlan.c >> +++ b/drivers/net/vxlan.c >> @@ -3276,6 +3276,12 @@ static int vxlan_netdevice_event(struct notifier_block *unused, >> vxlan_handle_lowerdev_unregister(vn, dev); >> else if (event == NETDEV_UDP_TUNNEL_PUSH_INFO) >> vxlan_push_rx_ports(dev); >> + else if (event == NETDEV_CHANGE) { >> + if (dev->netdev_ops == &vxlan_netdev_ops) { >> + if (netif_running(dev) && !netif_oper_up(dev)) >> + vxlan_flush(netdev_priv(dev)); >> + } >> + } > Looks correct. > Maybe logic would be clearer with a switch() statement here. ack. this was an internal patch i accidentally sent. I have refined it a bit for upstream since then. will post an update.. thanks