Re: [PATCH] mkfs.f2fs: fix bad assignment of total_sectors for f2fs_configuration

From: Sheng Yong <shengyong1@huawei.com>
To: Kinglong Mee <kinglongmee@gmail.com>,
	Jaegeuk Kim <jaegeuk@kernel.org>,
	linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] mkfs.f2fs: fix bad assignment of total_sectors for f2fs_configuration
Date: Tue, 24 Jan 2017 11:06:56 +0800	[thread overview]
Message-ID: <5886C4D0.8040601@huawei.com> (raw)
In-Reply-To: <130c919b-def1-33b1-0e16-e18e8de28d5c@gmail.com>

Hi, Kinglong

On 1/24/2017 10:42 AM, Kinglong Mee wrote:
> wanted_total_sectors is introduced instead total_sectors,
> so that, the initialize is a fault, drop it.
> 
> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
> ---
>  mkfs/f2fs_format_main.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/mkfs/f2fs_format_main.c b/mkfs/f2fs_format_main.c
> index db1dc94..5bb1faf 100644
> --- a/mkfs/f2fs_format_main.c
> +++ b/mkfs/f2fs_format_main.c
> @@ -151,9 +151,6 @@ static void f2fs_parse_options(int argc, char *argv[])
>  		c.wanted_total_sectors = atoll(argv[optind+1]);
>  	}
>  
> -	if ((optind + 1) < argc)
> -		c.total_sectors = atoll(argv[optind+1]);
> -
Here we get the number of sectors specified by user, so that we could
create an image based on a specific size. There seems no fault. Could
you please give more detail :)

thanks,
Sheng
>  	if (c.zoned_mode)
>  		c.feature |= cpu_to_le32(F2FS_FEATURE_BLKZONED);
>  }
> 


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot