From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tools: Correct python building host tools
Date: Tue, 24 Jan 2017 07:06:42 +0100 [thread overview]
Message-ID: <5886EEF2.1010104@denx.de> (raw)
In-Reply-To: <1485189873-23136-1-git-send-email-trini@konsulko.com>
Hello Tom,
Am 23.01.2017 um 17:44 schrieb Tom Rini:
> When we have python building tools for the host it will not check HOSTXX
> variables but only XX variables, for example LDFLAGS and not
> HOSTLDFLAGS.
>
> Cc: Simon Glass <sjg@chromium.org>
> Reported-by: Heiko Schocher <hs@denx.de>
> Fixes: 1905c8fc711a ("build: Always build the libfdt python module")
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> tools/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks! This fixes the build for the tqm5200 board.
Tested-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
>
> diff --git a/tools/Makefile b/tools/Makefile
> index a609d058595b..cefcedf683ca 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -117,7 +117,8 @@ _libfdt.so-sharedobjs += $(LIBFDT_OBJS)
> libfdt:
>
> tools/_libfdt.so: $(patsubst %.o,%.c,$(LIBFDT_OBJS)) tools/libfdt_wrap.c
> - python $(srctree)/lib/libfdt/setup.py "$(_hostc_flags)" $^
> + LDFLAGS="$(HOSTLDFLAGS)" python $(srctree)/lib/libfdt/setup.py \
> + "$(_hostc_flags)" $^
> mv _libfdt.so $@
>
> tools/libfdt_wrap.c: $(srctree)/lib/libfdt/libfdt.swig
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2017-01-24 6:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 16:44 [U-Boot] [PATCH] tools: Correct python building host tools Tom Rini
2017-01-23 17:12 ` Simon Glass
2017-01-24 6:06 ` Heiko Schocher [this message]
2017-01-25 2:15 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5886EEF2.1010104@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.