Re: [dpdk-dev] [PATCH v3 0/5] fix vector rx burst for PMDs

From: "Guo, Jia" <jia.guo@intel.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>,
	"Morten Brørup" <mb@smartsharesystems.com>,
	"Yang, Qiming" <qiming.yang@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"Zhao1, Wei" <wei.zhao1@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Zhang, Helin" <helin.zhang@intel.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"stephen@networkplumber.org" <stephen@networkplumber.org>,
	"barbette@kth.se" <barbette@kth.se>
Subject: Re: [dpdk-dev] [PATCH v3 0/5] fix vector rx burst for PMDs
Date: Wed, 9 Sep 2020 08:01:01 +0000	[thread overview]
Message-ID: <5886e64345ae4b33afc599aca0dac482@intel.com> (raw)
In-Reply-To: <BN8PR11MB3795B20CE37E57EF0DD61750F7260@BN8PR11MB3795.namprd11.prod.outlook.com>

> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Wednesday, September 9, 2020 3:55 PM
> To: Morten Brørup <mb@smartsharesystems.com>; Guo, Jia
> <jia.guo@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; dev@dpdk.org; Zhang,
> Helin <helin.zhang@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> stephen@networkplumber.org; barbette@kth.se
> Subject: RE: [dpdk-dev] [PATCH v3 0/5] fix vector rx burst for PMDs
> 
> > -----Original Message-----
> > From: Morten Brørup <mb@smartsharesystems.com>
> > Sent: Wednesday, September 9, 2020 15:43
> > To: Wang, Haiyue <haiyue.wang@intel.com>; Guo, Jia
> > <jia.guo@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Xing,
> > Beilei <beilei.xing@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>;
> > Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing
> > <jingjing.wu@intel.com>
> > Cc: Richardson, Bruce <bruce.richardson@intel.com>; dev@dpdk.org;
> > Zhang, Helin <helin.zhang@intel.com>; Yigit, Ferruh
> > <ferruh.yigit@intel.com>; stephen@networkplumber.org;
> barbette@kth.se
> > Subject: RE: [dpdk-dev] [PATCH v3 0/5] fix vector rx burst for PMDs
> >
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wang, Haiyue
> > > Sent: Wednesday, September 9, 2020 9:05 AM
> > >
> > > > From: Guo, Jia <jia.guo@intel.com>
> > > > Sent: Wednesday, September 9, 2020 15:03
> > > >
> > > > Hi, haiyue
> > > >
> > > > > From: Wang, Haiyue <haiyue.wang@intel.com>
> > > > > Sent: Wednesday, September 9, 2020 2:45 PM
> > > > >
> > > > > > From: Guo, Jia <jia.guo@intel.com>
> > > > > > Sent: Wednesday, September 9, 2020 14:37
> > > > > >
> > > > > > The limitation of burst size in vector rx was removed, since
> > > > > > it
> > > should
> > > > > > retrieve as much received packets as possible. And also the
> > > scattered
> > > > > > receive path should use a wrapper function to achieve the goal
> > > > > > of burst maximizing.
> > > > > >
> > > > > > This patch set aims to maximize vector rx burst for for
> > > > > > ixgbe/i40e/ice/iavf/fm10k PMDs, and also do some code cleaning.
> > > > >
> > > > > IMO, this can be "enhance the vector ...", but not "fix ...".
> > > > > If "fix", it needs "Fixes:" tags ... ;-)
> > > > >
> > > >
> > > > Ok, so I will prefer to use "refine the vector rx burst for PMDs",
> > > thanks.
> > >
> > > Better than "fix" now.
> > >
> >
> > It does fix a bug: https://bugs.dpdk.org/show_bug.cgi?id=516
> 

Oh, I missing it, so the Fixed tag and bug info could be expect in commit log in next version. Thanks, morten.

> Looks like a backport is needed.
> 