From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932261AbdA3PRq (ORCPT ); Mon, 30 Jan 2017 10:17:46 -0500 Received: from SMTPBG15.QQ.COM ([183.60.61.204]:57250 "EHLO smtpbg15.qq.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932215AbdA3PQ3 (ORCPT ); Mon, 30 Jan 2017 10:16:29 -0500 X-Greylist: delayed 377 seconds by postgrey-1.27 at vger.kernel.org; Mon, 30 Jan 2017 10:16:29 EST X-QQ-mid: esmtp20t1485788655tlx822yh7 X-QQ-SSF: 01000000000000606G110300000000V X-QQ-FEAT: nETcBmVCK8aByHlPGMgMlqSeREpB5O/U9BszgPe7dsitqWmB8CIDWCG1Uvjm+ rphyvSGb+dqwcSuidUTGTQckFF8GOPQmcJAbrbYLnKuGWse5OZCSqty1uM+GVgdtEtkrM7K QyqtBZBP0ArS7AVljCTZ3t2eOj5vrSiZTTMn5CEdYt53qbsH/bRYRJho4J/pKzkfe5wpeoY s6PVTbgqos0YxDqVEea5NrE0UMBIz5obwWvvo8uBoJr6z3ke81MaFkjwGm0hDbeUayjniYx X9+T3Ywks9Gj5L X-QQ-GoodBg: 0 Subject: Re: [PATCH v4 2/2] HWPOISON: soft offlining for non-lru movable page To: Michal Hocko References: <1485356738-4831-1-git-send-email-ysxie@foxmail.com> <1485356738-4831-3-git-send-email-ysxie@foxmail.com> <20170126092725.GD6590@dhcp22.suse.cz> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, n-horiguchi@ah.jp.nec.com, akpm@linux-foundation.org, minchan@kernel.org, vbabka@suse.cz, guohanjun@huawei.com, qiuxishi@huawei.com From: Yisheng Xie Message-ID: <588F55ED.3010509@foxmail.com> Date: Mon, 30 Jan 2017 23:04:13 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20170126092725.GD6590@dhcp22.suse.cz> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-QQ-SENDSIZE: 520 Feedback-ID: esmtp:foxmail.com:bgforeign:bgforeign1 X-QQ-Bgrelay: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Michal, Sorry for late reply. On 01/26/2017 05:27 PM, Michal Hocko wrote: > On Wed 25-01-17 23:05:38, ysxie@foxmail.com wrote: >> From: Yisheng Xie >> >> This patch is to extends soft offlining framework to support >> non-lru page, which already support migration after >> commit bda807d44454 ("mm: migrate: support non-lru movable page >> migration") >> >> When memory corrected errors occur on a non-lru movable page, >> we can choose to stop using it by migrating data onto another >> page and disable the original (maybe half-broken) one. >> >> Signed-off-by: Yisheng Xie >> Suggested-by: Michal Hocko >> Suggested-by: Minchan Kim >> Reviewed-by: Minchan Kim >> Acked-by: Naoya Horiguchi >> CC: Vlastimil Babka >> --- >> mm/memory-failure.c | 26 ++++++++++++++++---------- >> 1 file changed, 16 insertions(+), 10 deletions(-) >> >> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >> index f283c7e..56e39f8 100644 >> --- a/mm/memory-failure.c >> +++ b/mm/memory-failure.c >> @@ -1527,7 +1527,8 @@ static int get_any_page(struct page *page, unsigned long pfn, int flags) >> { >> int ret = __get_any_page(page, pfn, flags); >> >> - if (ret == 1 && !PageHuge(page) && !PageLRU(page)) { >> + if (ret == 1 && !PageHuge(page) && >> + !PageLRU(page) && !__PageMovable(page)) { >> /* >> * Try to free it. >> */ > Is this sufficient? Not that I am familiar with get_any_page() but > __get_any_page doesn't seem to be aware of movable pages and neither > shake_page is. Sorry,maybe I do not quite get what you mean. If the page can be migrated, it can skip "shake_page and __get_any_page once more" here, though it is not a free page. right ? Please let me know if I miss anything. >> @@ -1649,7 +1650,10 @@ static int __soft_offline_page(struct page *page, int flags) >> * Try to migrate to a new page instead. migrate.c >> * handles a large number of cases for us. >> */ >> - ret = isolate_lru_page(page); >> + if (PageLRU(page)) >> + ret = isolate_lru_page(page); >> + else if (!isolate_movable_page(page, ISOLATE_UNEVICTABLE)) >> + ret = -EBUSY; > As pointed out in the previous response isolate_movable_page should > really have the same return value contract as [__]isolate_lru_page Yes, I agree with your suggestion. I will rewrite it in later patch if it is suitable. as I mention before. Thanks again for your reviewing. Yisheng Xie >> /* >> * Drop page reference which is came from get_any_page() >> * successful isolate_lru_page() already took another one. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f197.google.com (mail-qk0-f197.google.com [209.85.220.197]) by kanga.kvack.org (Postfix) with ESMTP id 65F336B0260 for ; Mon, 30 Jan 2017 10:04:23 -0500 (EST) Received: by mail-qk0-f197.google.com with SMTP id l126so54186562qkc.1 for ; Mon, 30 Jan 2017 07:04:23 -0800 (PST) Received: from smtpbgbr2.qq.com (smtpbgbr2.qq.com. [54.207.22.56]) by mx.google.com with ESMTPS id g8si9703970qtc.212.2017.01.30.07.04.21 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 30 Jan 2017 07:04:22 -0800 (PST) Subject: Re: [PATCH v4 2/2] HWPOISON: soft offlining for non-lru movable page References: <1485356738-4831-1-git-send-email-ysxie@foxmail.com> <1485356738-4831-3-git-send-email-ysxie@foxmail.com> <20170126092725.GD6590@dhcp22.suse.cz> From: Yisheng Xie Message-ID: <588F55ED.3010509@foxmail.com> Date: Mon, 30 Jan 2017 23:04:13 +0800 MIME-Version: 1.0 In-Reply-To: <20170126092725.GD6590@dhcp22.suse.cz> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, n-horiguchi@ah.jp.nec.com, akpm@linux-foundation.org, minchan@kernel.org, vbabka@suse.cz, guohanjun@huawei.com, qiuxishi@huawei.com Hi, Michal, Sorry for late reply. On 01/26/2017 05:27 PM, Michal Hocko wrote: > On Wed 25-01-17 23:05:38, ysxie@foxmail.com wrote: >> From: Yisheng Xie >> >> This patch is to extends soft offlining framework to support >> non-lru page, which already support migration after >> commit bda807d44454 ("mm: migrate: support non-lru movable page >> migration") >> >> When memory corrected errors occur on a non-lru movable page, >> we can choose to stop using it by migrating data onto another >> page and disable the original (maybe half-broken) one. >> >> Signed-off-by: Yisheng Xie >> Suggested-by: Michal Hocko >> Suggested-by: Minchan Kim >> Reviewed-by: Minchan Kim >> Acked-by: Naoya Horiguchi >> CC: Vlastimil Babka >> --- >> mm/memory-failure.c | 26 ++++++++++++++++---------- >> 1 file changed, 16 insertions(+), 10 deletions(-) >> >> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >> index f283c7e..56e39f8 100644 >> --- a/mm/memory-failure.c >> +++ b/mm/memory-failure.c >> @@ -1527,7 +1527,8 @@ static int get_any_page(struct page *page, unsigned long pfn, int flags) >> { >> int ret = __get_any_page(page, pfn, flags); >> >> - if (ret == 1 && !PageHuge(page) && !PageLRU(page)) { >> + if (ret == 1 && !PageHuge(page) && >> + !PageLRU(page) && !__PageMovable(page)) { >> /* >> * Try to free it. >> */ > Is this sufficient? Not that I am familiar with get_any_page() but > __get_any_page doesn't seem to be aware of movable pages and neither > shake_page is. Sorry,maybe I do not quite get what you mean. If the page can be migrated, it can skip "shake_page and __get_any_page once more" here, though it is not a free page. right ? Please let me know if I miss anything. >> @@ -1649,7 +1650,10 @@ static int __soft_offline_page(struct page *page, int flags) >> * Try to migrate to a new page instead. migrate.c >> * handles a large number of cases for us. >> */ >> - ret = isolate_lru_page(page); >> + if (PageLRU(page)) >> + ret = isolate_lru_page(page); >> + else if (!isolate_movable_page(page, ISOLATE_UNEVICTABLE)) >> + ret = -EBUSY; > As pointed out in the previous response isolate_movable_page should > really have the same return value contract as [__]isolate_lru_page Yes, I agree with your suggestion. I will rewrite it in later patch if it is suitable. as I mention before. Thanks again for your reviewing. Yisheng Xie >> /* >> * Drop page reference which is came from get_any_page() >> * successful isolate_lru_page() already took another one. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org