From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from alexa-out.qualcomm.com ([129.46.98.28]:12568 "EHLO alexa-out.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030496AbeCANSw (ORCPT ); Thu, 1 Mar 2018 08:18:52 -0500 From: Govind Singh To: Arnd Bergmann , Kalle Valo CC: Govind Singh , linux-wireless , "ath10k@lists.infradead.org" Subject: RE: [PATCH] ath10k: Enable IOMMU support for WCN3990 target Date: Thu, 1 Mar 2018 13:18:44 +0000 Message-ID: <588e4d951bd84ea29dfc1a68353505e7@aphydexm01b.ap.qualcomm.com> (sfid-20180301_141857_050725_AD53A548) References: <1518685448-15317-1-git-send-email-govinds@codeaurora.org> <877eqwqfml.fsf@kamboji.qca.qualcomm.com> In-Reply-To: Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: >> The asm/dma-iommu.h header file exsists only on arm32, no other architec= ture. >> I'm not sure about the purpose of the patch to start with: >> it's normally up to the platform code to allocate IOMMU domains, device = drivers should only need to manually interact with the IOMMU layer if they = need more than one domain, but this ath10k patch appears to be using the de= fault domain and should have no effect as long as the platform code works c= orrectly. Thanks Arnd, I have fixed this and migrated to 64bit API's(iommu_attach_de= vice/iommu_detach_device/ iommu_get_domain_for_dev), will share the next re= vision. I tried using the default domain by adding the stream ID and mask in dt and= no manual interaction, but it is resulting in TZ error and unhandled conte= xt fault. Seems I need to provide explicit mapping range(aperture_start/ aperture_end= ) as this is only working combination for me.. BR, Govind -----Original Message----- From: ath10k [mailto:ath10k-bounces@lists.infradead.org] On Behalf Of Arnd = Bergmann Sent: Thursday, March 1, 2018 3:40 PM To: Kalle Valo Cc: Govind Singh ; linux-wireless ; ath10k@lists.infradead.org Subject: Re: [PATCH] ath10k: Enable IOMMU support for WCN3990 target On Thu, Mar 1, 2018 at 11:01 AM, Kalle Valo wrote: > Govind Singh writes: > >> When an IOMMU device is available on the platform bus, allocate an=20 >> IOMMU domain and attach the wlan target to it. >> WCN3990 target can then attach an DMA I/O virtual address space to=20 >> scan out of bound transactions. >> >> Signed-off-by: Govind Singh >> --- >> drivers/net/wireless/ath/ath10k/snoc.c | 100 ++++++++++++++++++++++++++= ++++++- >> drivers/net/wireless/ath/ath10k/snoc.h | 3 + >> 2 files changed, 101 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath10k/snoc.c=20 >> b/drivers/net/wireless/ath/ath10k/snoc.c >> index cd21b25..502263d 100644 >> --- a/drivers/net/wireless/ath/ath10k/snoc.c >> +++ b/drivers/net/wireless/ath/ath10k/snoc.c >> @@ -26,6 +26,10 @@ >> #include >> #include #include >> +#include >> +#include >> +#include > > Kbuild bot reported a problem with arm64 but strangely I cannot find=20 > the full report. Anyway, this was the warning: > > drivers/net/wireless/ath/ath10k/snoc.c:29:10: fatal error: > asm/dma-iommu.h: No such file or directory > > Any ideas? Adding also Arnd, the grand master of compilation problems=20 > :) > > Full patch here: > > https://patchwork.kernel.org/patch/10220719/ > The asm/dma-iommu.h header file exsists only on arm32, no other architectur= e. I'm not sure about the purpose of the patch to start with: it's normally up to the platform code to allocate IOMMU domains, device dri= vers should only need to manually interact with the IOMMU layer if they nee= d more than one domain, but this ath10k patch appears to be using the defau= lt domain and should have no effect as long as the platform code works corr= ectly. Arnd _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from alexa-out.qualcomm.com ([129.46.98.28]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1erO8F-00032f-BW for ath10k@lists.infradead.org; Thu, 01 Mar 2018 13:20:29 +0000 From: Govind Singh Subject: RE: [PATCH] ath10k: Enable IOMMU support for WCN3990 target Date: Thu, 1 Mar 2018 13:18:44 +0000 Message-ID: <588e4d951bd84ea29dfc1a68353505e7@aphydexm01b.ap.qualcomm.com> References: <1518685448-15317-1-git-send-email-govinds@codeaurora.org> <877eqwqfml.fsf@kamboji.qca.qualcomm.com> In-Reply-To: Content-Language: en-US MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Arnd Bergmann , Kalle Valo Cc: Govind Singh , linux-wireless , "ath10k@lists.infradead.org" >> The asm/dma-iommu.h header file exsists only on arm32, no other architecture. >> I'm not sure about the purpose of the patch to start with: >> it's normally up to the platform code to allocate IOMMU domains, device drivers should only need to manually interact with the IOMMU layer if they need more than one domain, but this ath10k patch appears to be using the default domain and should have no effect as long as the platform code works correctly. Thanks Arnd, I have fixed this and migrated to 64bit API's(iommu_attach_device/iommu_detach_device/ iommu_get_domain_for_dev), will share the next revision. I tried using the default domain by adding the stream ID and mask in dt and no manual interaction, but it is resulting in TZ error and unhandled context fault. Seems I need to provide explicit mapping range(aperture_start/ aperture_end) as this is only working combination for me.. BR, Govind -----Original Message----- From: ath10k [mailto:ath10k-bounces@lists.infradead.org] On Behalf Of Arnd Bergmann Sent: Thursday, March 1, 2018 3:40 PM To: Kalle Valo Cc: Govind Singh ; linux-wireless ; ath10k@lists.infradead.org Subject: Re: [PATCH] ath10k: Enable IOMMU support for WCN3990 target On Thu, Mar 1, 2018 at 11:01 AM, Kalle Valo wrote: > Govind Singh writes: > >> When an IOMMU device is available on the platform bus, allocate an >> IOMMU domain and attach the wlan target to it. >> WCN3990 target can then attach an DMA I/O virtual address space to >> scan out of bound transactions. >> >> Signed-off-by: Govind Singh >> --- >> drivers/net/wireless/ath/ath10k/snoc.c | 100 ++++++++++++++++++++++++++++++++- >> drivers/net/wireless/ath/ath10k/snoc.h | 3 + >> 2 files changed, 101 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath10k/snoc.c >> b/drivers/net/wireless/ath/ath10k/snoc.c >> index cd21b25..502263d 100644 >> --- a/drivers/net/wireless/ath/ath10k/snoc.c >> +++ b/drivers/net/wireless/ath/ath10k/snoc.c >> @@ -26,6 +26,10 @@ >> #include >> #include #include >> +#include >> +#include >> +#include > > Kbuild bot reported a problem with arm64 but strangely I cannot find > the full report. Anyway, this was the warning: > > drivers/net/wireless/ath/ath10k/snoc.c:29:10: fatal error: > asm/dma-iommu.h: No such file or directory > > Any ideas? Adding also Arnd, the grand master of compilation problems > :) > > Full patch here: > > https://patchwork.kernel.org/patch/10220719/ > The asm/dma-iommu.h header file exsists only on arm32, no other architecture. I'm not sure about the purpose of the patch to start with: it's normally up to the platform code to allocate IOMMU domains, device drivers should only need to manually interact with the IOMMU layer if they need more than one domain, but this ath10k patch appears to be using the default domain and should have no effect as long as the platform code works correctly. Arnd _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k