From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40F7EC3A5A1 for ; Mon, 26 Aug 2019 01:32:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1320A20673 for ; Mon, 26 Aug 2019 01:32:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="ArrOsJbq"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="AbT9WAIJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726254AbfHZBcC (ORCPT ); Sun, 25 Aug 2019 21:32:02 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:40985 "EHLO wout2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726215AbfHZBcC (ORCPT ); Sun, 25 Aug 2019 21:32:02 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 9612039E; Sun, 25 Aug 2019 21:32:00 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute4.internal (MEProxy); Sun, 25 Aug 2019 21:32:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm3; bh=GQy9HXGKBleVZguowV/+z3W+P9jSPkD lUZyUbUOI3MQ=; b=ArrOsJbq1b1aUx1WRMwKSoeZtJW1HmVpiiDf6P773HnPNyS cnXrvx7M0QFUG591al+NS4RD/jyl/I15ZbAqIoFdvlsSXh8Lw5GUVM3BsXSuAuI8 h1PI0zhNozJHSAhyy2cZkYWY1hOHYg5OyvMpM5/973YxNEEcxKDoe5hndNL3o4Tw nmJk8nPfJgJNNH0EusawWmmgSa3OuinCzIje7N2bmaM2QTxjKSC9Fh1Tumg+klQC Bib1Sqr6NAJ34bS5wA8HPMkQZhoUwhl5Uew7zz7DAYDOfcelxCENwAUYu2j+vXWu pIyjeowXHJIIXBaERukCSUolZEUTofhpvTZ/FsQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=GQy9HX GKBleVZguowV/+z3W+P9jSPkDlUZyUbUOI3MQ=; b=AbT9WAIJKJpiYR/fWC3eiD FFNskaxsxJXacirhFwmeANOQ11K0HyoO5UslpymcdnFd7AjXt3qr/pn+YsBNKht9 O0Nzh184cFZ0GWGLbWXh2lXTGW47LuJhwiG4dXJB02LBxiPK+FMOBF0bapeqLCqr iRmvbgis5Dm/gvjEYqA1+jiAcdhxtaLhZm7hawvepZCbczZQfsOjbhXfRwmJ9wDx WDvtPFkjKyoAz5LEvNb29dUTrlGTigtf1ZGIzueMeLBnpzHFJcc07okjUlCmgvHC BrC0Vc0lmx2UAf/FcmPYdA64/exI6MdRPeoOPgbtQWIDYITv4YjzBGOVlvqpN9TA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudehfedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecurfgrrh grmhepmhgrihhlfhhrohhmpegrnhgurhgvfiesrghjrdhiugdrrghunecuvehluhhsthgv rhfuihiivgeptd X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 5EA86E00A3; Sun, 25 Aug 2019 21:31:58 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.6-916-g49fca03-fmstable-20190821v7 Mime-Version: 1.0 Message-Id: <588f6cbd-b6ca-4f43-8034-80956ee56bb8@www.fastmail.com> In-Reply-To: <20190823212957.26043-1-jae.hyun.yoo@linux.intel.com> References: <20190823212957.26043-1-jae.hyun.yoo@linux.intel.com> Date: Mon, 26 Aug 2019 11:02:19 +0930 From: "Andrew Jeffery" To: "Jae Hyun Yoo" , "Eddie James" , "Mauro Carvalho Chehab" , "Joel Stanley" , "Benjamin Herrenschmidt" Cc: linux-aspeed@lists.ozlabs.org, linux-media@vger.kernel.org, openbmc@lists.ozlabs.org Subject: =?UTF-8?Q?Re:_[PATCH]_media:_aspeed:_fix_an_incorrect_return_code_on_buf?= =?UTF-8?Q?fer_allocation_failure?= Content-Type: text/plain Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Sat, 24 Aug 2019, at 07:00, Jae Hyun Yoo wrote: > It returns '0' even when a failure happens on jpeg buffer allocation > so this commit fixes the issue. > > Signed-off-by: Jae Hyun Yoo Reviewed-by: Andrew Jeffery > --- > drivers/media/platform/aspeed-video.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/aspeed-video.c > b/drivers/media/platform/aspeed-video.c > index f899ac3b4a61..94f97d96dabc 100644 > --- a/drivers/media/platform/aspeed-video.c > +++ b/drivers/media/platform/aspeed-video.c > @@ -1624,6 +1624,7 @@ static int aspeed_video_init(struct aspeed_video > *video) > if (!aspeed_video_alloc_buf(video, &video->jpeg, > VE_JPEG_HEADER_SIZE)) { > dev_err(dev, "Failed to allocate DMA for JPEG header\n"); > + rc = -ENOMEM; > goto err_release_reserved_mem; > } > > -- > 2.7.4 > >