From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752112AbdAaNOA (ORCPT ); Tue, 31 Jan 2017 08:14:00 -0500 Received: from mga07.intel.com ([134.134.136.100]:58033 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751992AbdAaNNv (ORCPT ); Tue, 31 Jan 2017 08:13:51 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,315,1477983600"; d="scan'208";a="37754234" Subject: Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM To: Baolin Wang , Mathias Nyman , Felipe Balbi References: Cc: Greg KH , Mark Brown , USB , LKML , Alan Stern From: Mathias Nyman Message-ID: <58908DBC.5010208@linux.intel.com> Date: Tue, 31 Jan 2017 15:14:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16.01.2017 12:56, Baolin Wang wrote: > Hi Mathias, Hi Sorry about the long review delay CC Alan in case my pm assumptions need to be corrected > > On 13 December 2016 at 15:49, Baolin Wang wrote: >> Enable the xhci plat runtime PM for parent device to suspend/resume xhci. >> Also call pm_runtime_get_noresume() in probe() function in case the parent >> device doesn't call suspend/resume callback by runtime PM now. >> >> Signed-off-by: Baolin Wang >> --- >> Changes since v4: >> - No updates. >> >> Changes since v3: >> - Fix kbuild error. >> >> Changes since v2: >> - Add pm_runtime_get_noresume() in probe() function. >> - Add pm_runtime_set_suspended()/pm_runtime_put_noidle() in remove() function. >> >> Changes since v1: >> - No updates. >> --- > > Do you have any comments about this patch? Thanks. > >> drivers/usb/host/xhci-plat.c | 41 ++++++++++++++++++++++++++++++++++++----- >> 1 file changed, 36 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c >> index ed56bf9..5805c6a 100644 >> --- a/drivers/usb/host/xhci-plat.c >> +++ b/drivers/usb/host/xhci-plat.c >> @@ -246,6 +246,10 @@ static int xhci_plat_probe(struct platform_device *pdev) >> if (ret) >> goto dealloc_usb2_hcd; >> >> + pm_runtime_get_noresume(&pdev->dev); >> + pm_runtime_set_active(&pdev->dev); >> + pm_runtime_enable(&pdev->dev); >> + >> return 0; >> >> To me this looks like we are not really enabling runtime pm for xhci, we increment the usage count in probe, and keep it until remove is called. This would normally prevent parent dwc3 from runtime suspending, but I see that in patch 2/2 adds pm_suspend_ignore_children(dev, true) to dwc3, and, that dwc3 actually controls xhci runtime pm by calling pm_runtime_get/put for xhci in its own dwc3 runtime_suspend/resume callbacks. Looks a bit upside down to me, what's the reason for this? what prevents calling pm_runtime_put_* before leaving probe in xhci and let pm code handle the runtime suspend and parent/child relationships? -Mathias