From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 914C0C433EF for ; Wed, 15 Sep 2021 04:23:33 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EB7461056 for ; Wed, 15 Sep 2021 04:23:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2EB7461056 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1F91780ECB; Wed, 15 Sep 2021 06:23:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1631679810; bh=T5ze5YGksCVXPhClgmdo98nT0RcJq5BKyPHDfQRmFJo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Reply-To:From; b=YQwQMeBDhNGVhHwtIw6jv2p02gpm0FIm/W29w8QAtERY0PuEdkgCv4GwJWwu7Mdrb 7EKcw2DEuz4/xJmBLt+Oy82ONRsc3nhpqkoGg33bRWXpNvPP/0VxakWVDyGrCVDqIB 6Jafn0Cb2bDZ40EPdIWVh7yO1LhRHC5hcvyXTyPvlThHFfolngYEDBh43Sn8Ln6kxE MXuQnxWokWKyCIFzMznGwP5uqYhKht7P5UrfL92a8GZ0Q+yfe3OA1tCfpmNm4CBzvQ g8SquNd6df0snaGa+3719qTKFSUijfUSKwQI1mz+noVVwp9lgXgbzz+KZSeo/i8xMq Lsr+Xyt/AYStw== Received: from [192.168.1.107] (87-97-107-210.pool.digikabel.hu [87.97.107.210]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: hs@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 5F85880C8A; Wed, 15 Sep 2021 06:23:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1631679808; bh=T5ze5YGksCVXPhClgmdo98nT0RcJq5BKyPHDfQRmFJo=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ERJzdHUyeI0Z8pOiG9htfvzJ3AGBo18sHOY09yUIYhVcEQvrD+uC3TyGnGFoG0hWb psvKTCHjal5X8GazxDciegWdR/ueviqY6DGH0LN9SXE2vqGGY1BoEG6x+VEjotnWAg zITTS+4XHgpGd5tB36ctcKElHyQiz8uHbH8NEV4LD0Y6GGUfvTDpx7vDyQJWxY3uGz b8JUhu4aFjsjew12HdJFVDOqx+OAza6EDjtpwl04l8/fb7I34i/oduZIoFi7yMnGlo MLy7cmjD6IVUo6oU8EmivAcqXV9srjtlaxgNdlT1DWcVoBOAvLERY543OhEnLy3/0K 1m2rByWqitzig== Subject: Re: [PATCH] mtd: spi-nor: Fix SF MTDIDS when registering multiple MTDs with DM enabled To: Marek Vasut , u-boot@lists.denx.de Cc: Jagan Teki , =?UTF-8?Q?Marek_Beh=c3=ban?= , Miquel Raynal , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Patrice Chotard , Patrick Delaunay , Priyanka Jain , Simon Glass References: <20210914230622.245747-1-marex@denx.de> From: Heiko Schocher Message-ID: <58930899-7190-9c36-6377-cc0c41d1800a@denx.de> Date: Wed, 15 Sep 2021 06:23:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210914230622.245747-1-marex@denx.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: hs@denx.de Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Marek, On 15.09.21 01:06, Marek Vasut wrote: > The flash->mtd.name used to be nor%d before, now it is the type of the > SPI NOR like e.g. mt25ql02g. It is possible to find plenty of examples > of the former in U-Boot configs by searching for MTDIDS.*nor.*spi, while > the later is ambiguous if there are multiple flashes of the same type in > the system and breaks existing environments. > > This does no longer get recognized when running 'mtdparts' for example: > CONFIG_MTDIDS_DEFAULT="nor0=47040000.spi.0" > > Fix this by setting the correct mtd.name to nor%d. > > Fixes: b7f060565e3 ("mtd: spi-nor: allow registering multiple MTDs when DM is enabled") > Signed-off-by: Marek Vasut > Cc: Heiko Schocher > Cc: Jagan Teki > Cc: Marek Behún > Cc: Miquel Raynal > Cc: Pali Rohár > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: Priyanka Jain > Cc: Simon Glass > --- > drivers/mtd/spi/sf_mtd.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Seem fixes the same problem as Patrick already posted here: https://patchwork.ozlabs.org/project/uboot/patch/20210913095742.v2.1.I73dae4b93f0587dc130e512e95a1f4794e0b0233@changeid/ I find your approach cleaner, so: Acked-by: Heiko Schocher @Patrick: Could you test this patch please? Thanks! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de