From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 879CDC388F7 for ; Fri, 13 Nov 2020 09:23:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D01D22244 for ; Fri, 13 Nov 2020 09:23:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=wdc.com header.i=@wdc.com header.b="qiJEkCUm"; dkim=pass (1024-bit key) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="GgpkyfWc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726181AbgKMJW7 (ORCPT ); Fri, 13 Nov 2020 04:22:59 -0500 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:49362 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726160AbgKMJW6 (ORCPT ); Fri, 13 Nov 2020 04:22:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1605259378; x=1636795378; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=vhGPTPVvs/GLZ1bKVr+gHsQslM5YUkDznIdkuBcpxtc=; b=qiJEkCUm78llsh8RQRJgrRibGWLZRmwayElQpoOhjeqEEr346j2eUs7/ J43hz9A2HfNSKmL28d1jG7aWslkvr9k2hz+TbIBcjiIqxyGeLxC0m01ml WHGZSYSROYsHbC5LeY1b0JT/TpRHpnV6Z0nlCdl6Qhv3BXQIUzAyeoi6/ UNtRrB7XFxI/S+gt/yYLznpMf67r7MLJOHlwdCmuvvY7wtoNcFW945WlS YY2QQ1ercpz4XOgslY8oYk6ho1GJkvhKbt7vEYkZCvbopBfmdz11pC8Rc N8zYxCgJojumVjH3P8IoliO16FtmPt2BDz0RHEPhTjfMdzaFVkHCOBnh5 Q==; IronPort-SDR: ElwMMwfYKt4favxwrpLC/WejHDJrF8Np7EtjX4RZAmg5AtoHtgvCH4NtfeN1o7WUHlzp6DvPdS 0+/8SfNn9nSRkuTcUK0tq91QOrvqa/PrIp3r/PZNNMaUh4uCfnZyaKNEVId3k+DmyEhKD45enX /2afucd5N3jZajveC0OPrmwPpe3RqVLzZTtHaMTJr5fmenxcI0FBvrjCKzbOY/Z1IyNX7mw9qb EmP96LznoH/bJTjZRSg2FyA2vlwOYmD2bMscqBN+3QrnNts7iPpyabm9ZgtyEZ6BFTuol0FWm6 PMw= X-IronPort-AV: E=Sophos;i="5.77,475,1596470400"; d="scan'208";a="153755605" Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44]) by ob1.hgst.iphmx.com with ESMTP; 13 Nov 2020 17:22:57 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L+EMzhyt/NHwJatoy7AGoUNqC5aNoQMFLOtaIeYovuAZ0f/ADB4eiLRWYZBYNvvpnqTVz8nNz7ojyWTii1d7fPrpnmEd7JcNoagHDaTlgAkzOqbMxmLitkjHMX8RTG3glN5UelQ0WycQYPAsdiovc8SUwyD23PYCTSOxEUdwVc/mj8KTqsFfyGYtsoTngWXjtMAsAIRaYMs0cmIV7VmiEO5PH+JvgaVyhFYIoc89LqYzqZ2I1JMNHjbzHU4HgEUvdJntUiyCJIBrxysWPoYKMxzXKqq0ijxzj4ASVhhp8BtXH1eicRbMu7oHdfbgH7OpdhfBzX34t897XmB5GClKyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vhGPTPVvs/GLZ1bKVr+gHsQslM5YUkDznIdkuBcpxtc=; b=d7MV5Jeep/0xiKrWWaCFZS+WdYEpUuguYUdf/KpOpkTNZ/HoWsDVzhOKdBxIjs/z+1CuaB2k7Vi7rmJf4yTFCNdLrq1Xp/XEmCx2iLKm+iXgNKa5xg5Q5BNIvAhvyqDZZCyuLvUqjKK8ujIxkCFMKytEmbjmWoASeJFUMBXrt36Rmh4qCc5BMMdGQcnLcU8R1EBipdj0EtIUSYC7NeRkOyhvtoa8DnxBjUr6hqiTDsGansJQd/584vJKbG+s8NH31TrZ5mrYlZyXAJCmCPpSYQNDQkWkuyZpR5tcKV7dydcy8N3uNSenbH5zWcEQkiRj2/nJh8eAs0/MVtqsiYCraQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vhGPTPVvs/GLZ1bKVr+gHsQslM5YUkDznIdkuBcpxtc=; b=GgpkyfWcOErWTXW6hSO2YC+YegpQyidTEUAisw+9MAnNJmI72I7/zO59cWQqwBcVRbVAO9gTcrIkuFf51qXJgeC6k9U4+05eDa4bh6JnqCqsnS/rNNeXfwkxpnvgeGvwsJGSZY97Q2AQFTAfOVHvA2rGllNO+P8fH0JPqq9i0jk= Received: from BL0PR04MB6514.namprd04.prod.outlook.com (2603:10b6:208:1ca::23) by BL0PR04MB6595.namprd04.prod.outlook.com (2603:10b6:208:1c5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Fri, 13 Nov 2020 09:22:54 +0000 Received: from BL0PR04MB6514.namprd04.prod.outlook.com ([fe80::4c3e:2b29:1dc5:1a85]) by BL0PR04MB6514.namprd04.prod.outlook.com ([fe80::4c3e:2b29:1dc5:1a85%7]) with mapi id 15.20.3499.032; Fri, 13 Nov 2020 09:22:54 +0000 From: Damien Le Moal To: "fancer.lancer@gmail.com" CC: "linux-spi@vger.kernel.org" , "palmer@dabbelt.com" , "linux-riscv@lists.infradead.org" , "broonie@kernel.org" , "seanga2@gmail.com" Subject: Re: [PATCH 04/32] spi: dw: Introduce polling device tree property Thread-Topic: [PATCH 04/32] spi: dw: Introduce polling device tree property Thread-Index: AQHWtN4Jq5yxP9fdykKNjBOI754ZyqnAO9uAgAWXiAA= Date: Fri, 13 Nov 2020 09:22:54 +0000 Message-ID: <58943f7988706497040cac6f6108336286e9d15f.camel@wdc.com> References: <20201107081420.60325-1-damien.lemoal@wdc.com> <20201107081420.60325-5-damien.lemoal@wdc.com> <20201109195913.itgfj2ga5y7sr6zx@mobilestation> In-Reply-To: <20201109195913.itgfj2ga5y7sr6zx@mobilestation> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.38.1 (3.38.1-1.fc33) authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=wdc.com; x-originating-ip: [2400:2411:43c0:6000:8d3e:27aa:85c2:44b5] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 91bc297d-efe6-487b-ca16-08d887b5b3a8 x-ms-traffictypediagnostic: BL0PR04MB6595: x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0JpO55x7+SlY9NIpI10WB13VmycVDTQEUJHX8fqivHJ0nmvus8pZOMLDtMAOB3rLZkPiQurAAolfA/gDZDFEy5qa9qDUO1HyBy11HlHucVBWJIWK0wetmidtPsgf0t/Ri+0s02hGufs3UIHl9lLy66iLx2i7HZ9RQ00IFRLlyucTkugo+hsa8IwvUAajjr2ZFFWIrxX7J/FlWTEdWf/BDsXvfI/FwQP2ZnUYOszFptaTaPj1O1X28/1560f+1Lj2eIpbKvvK/uZpquWHcwzV6u+CUy79d5pP3MgGF9GTlVGCHz4wyaw/iy1dgVLx9rtHs3LqnghxmcrGLvsGSgm8yA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR04MB6514.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(39860400002)(366004)(136003)(396003)(36756003)(6512007)(2906002)(478600001)(66946007)(6506007)(4326008)(86362001)(316002)(83380400001)(6486002)(5660300002)(8676002)(66556008)(66476007)(54906003)(64756008)(76116006)(6916009)(8936002)(91956017)(2616005)(71200400001)(66446008)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: BXzjWKrmB1KLdMYqnRTBD8HXCg5WLgAoiU+uvkcBsY4o+NTNB1sGDbXtUwYcVp5SEQKMGu5dMOTfSzB9r8VUxefiHfrA6a2N/zoVzNTwv9zwyfqP2Znpcs/RT4P8B1X3ZIXjJxw8DIabvWtffNmA4jYZZflpInRe6T+mcvM6P2z6W5K8f+HHr5imAgJO1coM9adGbVSyb3mkeSTWCdHsBNptifgU95jTou1dbXjboOuy154IDeF9Rj1GXODkdd8hgVwhoju+ZR/w0Vqidjrf6vBbtbOK1TCrAs32eXxK8KVjJ5YL2f9mXe8yirCQqxfez7wXCxsnBvQnYR0t4urfL97cI1XyIVANlOrQfTY59Vlp8aY9JVxfE6Nz6YKzb2aMNDy3xC7OJr8c4yyCXd55w/wJwJ/2fcN2o+4PQ4hCr5nmV15g2iEeWUg+/jo8/qfYF42gVjR5Eh+KPAxqwnkH5qFU9r3S++ppESO5YugGMXifR/1lMx9pfx8dsfzSrseUUOtns43/JKTOC6R9/93qGpdQKtuLDhYkmS8/ER2rjpueRslSyy3xpStVIyD2tUKWYqU9qXWEzo0gLoIjDxLDJNHd7Q5cEzmmKfBNi1NtRlG5FMmnOPoAF/Viz2deuye3lqKip5olMAs5nUnnI9ITUcWji2hals4RYn7sJYd23ZUl+qLih2uvq42icOkMd1LSoWmWEBnYM/9AcXfftAPgRw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR04MB6514.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91bc297d-efe6-487b-ca16-08d887b5b3a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2020 09:22:54.4395 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: v9bcGwCY6kIij6wcZ15uLQuhrJ37x1wINqwOJB1fJ5koXxl9ehs39oCMMceEkNtK2UvCiTMf8yuS9ith7ahcHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR04MB6595 Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org T24gTW9uLCAyMDIwLTExLTA5IGF0IDIyOjU5ICswMzAwLCBTZXJnZSBTZW1pbiB3cm90ZToNCj4g T24gU2F0LCBOb3YgMDcsIDIwMjAgYXQgMDU6MTM6NTJQTSArMDkwMCwgRGFtaWVuIExlIE1vYWwg d3JvdGU6DQo+ID4gV2l0aCBib2FyZHMgdGhhdCBoYXZlIHNsb3cgaW50ZXJydXB0cyBjb250ZXh0 IHN3aXRjaCwgYW5kIGEgZmFzdCBkZXZpY2UNCj4gPiBjb25uZWN0ZWQgdG8gYSBzcGkgbWFzdGVy LCBlLmcuIGFuIFNEIGNhcmQgdGhyb3VnaCBtbWMtc3BpLA0KPiANCj4gPiB1c2luZw0KPiA+IGR3 X3NwaV9wb2xsX3RyYW5zZmVyKCkgaW50ZWFkIG9mIHRoZSByZWd1bGFyIGludGVycnVwdCBiYXNl ZA0KPiA+IGR3X3NwaV90cmFuc2Zlcl9oYW5kbGVyKCkgZnVuY3Rpb24gaXMgbW9yZSBlZmZpY2ll bnQgYW5kDQo+IA0KPiBJIGNhbiBiZWxpZXZlIGluIHRoYXQuIEJ1dCB0aGUgbmV4dCBwYXJ0IHNl ZW1zIHF1ZXN0aW9uYWJsZToNCj4gDQo+ID4gY2FuIGF2b2lkIGEgbG90DQo+ID4gb2YgUlggRklG TyBvdmVyZmxvdyBlcnJvcnMgd2hpbGUga2VlcGluZyB0aGUgZGV2aWNlIFNQSSBmcmVxdWVuY3kN Cj4gPiByZWFzb25uYWJseSBoaWdoIChmb3Igc3BlZWQpLg0KPiANCj4gTm8gbWF0dGVyIHdoZXRo ZXIgaXQncyBhbiBJUlEtYmFzZWQgb3IgcG9sbC1iYXNlZCB0cmFuc2ZlciwgYXMgbG9uZyBhcyBh DQo+IGNsaWVudCBTUEktZGV2aWNlIGlzIGNvbm5lY3RlZCB3aXRoIGEgR1BJTy1iYXNlZCBjaGlw LXNlbGVjdCAob3IgdGhlDQo+IERXIEFQQiBTU0ktY29udHJvbGxlciBmZWF0dXJlIG9mIHRoZSBh dXRvbWF0aWMgY2hpcC1zZWxlY3QgdG9nZ2xpbmcgaXMNCj4gZml4ZWQpLCB0aGUgUnggRklGTyBz aG91bGQgbmV2ZXIgb3ZlcnJ1bi4gSXQncyBlbnN1cmVkIGJ5IHRoZSB0cmFuc2Zlcg0KPiBhbGdv cml0aG0gZGVzaWduIGJ5IGNhbGN1bGF0aW5nIHRoZSByeHR4X2dhcCBpbiB0aGUgZHdfd3JpdGVy KCkNCj4gbWV0aG9kLiBJZiB0aGUgZXJyb3Igc3RpbGwgaGFwcGVucyB0aGVuIHRoZXJlIG11c3Qg YmUgc29tZSBidWcgaW4NCj4gdGhlIGNvZGUuDQo+IA0KPiBJdCdzIGFsc28gc3RyYW5nZSB0byBo ZWFyIHRoYXQgdGhlIHBvbGxpbmctYmFzZWQgdHJhbnNmZXIgaGVscHMNCj4gdG8gYXZvaWQgdGhl IFJ4IEZJRk8gb3ZlcmZsb3cgZXJyb3JzLCB3aGlsZSB0aGUgSVJRLWJhc2VkIHRyYW5zZmVyDQo+ IGNhdXNlcyB0aGVtLiBCb3RoIG9mIHRob3NlIG1ldGhvZHMgYXJlIGJhc2VkIG9uIHRoZSBzYW1l IGR3X3dyaXRlcigpDQo+IGFuZCBkd19yZWFkZXIoKSBtZXRob2RzLiBTbyBiYXNpY2FsbHkgdGhl eSBib3RoIHNob3VsZCBlaXRoZXIgd29yaw0KPiB3ZWxsIG9yIGNhdXNlIHRoZSBlcnJvcnMgYXQg c2FtZSB0aW1lLg0KPiANCj4gU28gdG8gc3BlYWsgY291bGQgeW91IG1vcmUgdGhyb3VnaCBkZWJ1 ZyB5b3VyIGNhc2U/DQoNCkkgZGlkLiBBbmQgSSBoYXZlIG11Y2ggYmV0dGVyIHJlc3VsdHMgbm93 LiBMZXQgbWUgZXhwbGFpbjoNCjEpIFRoZSBkZXZpY2UgdHJlZSB3YXMgc2V0dGluZyB1cCB0aGUg U1BJIGNvbnRyb2xsZXIgdXNpbmcgdGhlIGNvbnRyb2xsZXINCmludGVybmFsIGNoaXAgc2VsZWN0 LCBub3QgYSBHUElPLWJhc2VkIGNoaXAgc2VsZWN0LiBVbnRpbCBub3csIEkgY291bGQgbmV2ZXIN CmdldCB0aGUgR1BJTy1iYXNlZCBjaGlwIHNlbGVjdCB0byB3b3JrLiBJIGZpbmFsbHkgZm91bmQg b3V0IHdoeTogSSBzaW1wbHkNCm5lZWRlZCB0byBhZGQgdGhlICJzcGktY3MtaGlnaCIgcHJvcGVy dHkgdG8gdGhlIG1tYy1zbG90IG5vZGUuIFdpdGggdGhhdCwgdGhlDQpDUyBncGlvIGlzIGNvcnJl Y3RseSBkcml2ZW4gYWN0aXZlLWhpZ2ggaW5zdGVhZCBvZiB0aGUgZGVmYXVsdCBhY3RpdmUtbG93 IGFuZA0KdGhlIFNEIGNhcmQgd29ya3MuDQoyKSBXaXRoIHRoaXMgY2hhbmdlIHVzaW5nIHRoZSBH UElPLWJhc2VkIENTLCB0aGUgcGF0Y2ggInNwaTogZHc6IEZpeCBkcml2aW5nDQpNT1NJIGxvdyB3 aGlsZSByZWNlaXZpbmciIGJlY2FtZSBjb21wbGV0ZWx5IHVubmVjZXNzYXJ5LiBUaGUgU0QgY2Fy ZCB3b3Jrcw0Kd2l0aG91dCBpdC4NCg0KTm93IGZvciB0ZXN0aW5nLCBJIGFsc28gcmVtb3ZlZCB0 aGlzIHBvbGxpbmcgY2hhbmdlLiBSZXN1bHRzIGFyZSB0aGVzZToNCjEpIFdpdGggdGhlIHNhbWUg U1BJIGZyZXF1ZW5jeSBhcyBiZWZvcmUgKDRNSHopLCBJIGNhbiBydW4gdGhlIFNEIGNhcmQgYXQg YWJvdXQNCjMwMCBLQi9zIChyZWFkKSBidXQgSSBhbSBzdGlsbCBzZWVpbmcgc29tZSBSWCBGSUZP IG92ZXJmbG93IGVycm9ycy4gTm90IGEgbG90LA0KYnV0IGVub3VnaCB0byBiZSBhbm5veWluZywg ZXNwZWNpYWxseSBvbiBib290IGFzIHRoZSBwYXJ0aXRpb24gc2NhbiBzb21ldGltZXMNCmZhaWxz IGJlY2F1c2Ugb2YgdGhlc2UgZXJyb3JzLiBJbiBtb3N0IGNhc2VzLCB0aGUgYmxvY2sgbGF5ZXIg cmV0cnkgb2YgZmFpbGVkDQpyZWFkL3dyaXRlcyBjb3ZlciBhbmQgbm8gYmFkIGVycm9ycyBoYXBw ZW4sIGJ1dCB0aGUgUlggRklGTyBvdmVyZmxvdyBlcnJvcg0KbWVzc2FnZXMgc3RpbGwgcG9wIHVw Lg0KMikgTG9va2luZyBpbnRvIHRoZSBjb2RlIGZ1cnRoZXIsIEkgcmVhbGl6ZWQgdGhhdCBSWEZM VFIgaXMgc2V0IHRvIGhhbGYgdGhlDQpmaWZvIHNpemUgbWludXMgMS4gVGhhdCBzb3VuZCByZWFz b25hYmxlLCBidXQgYXMgdGhhdCBkZWxheXMgaW50ZXJydXB0DQpnZW5lcmF0aW9uIHVudGlsIHRo ZSBSWCBmaWZvIGlzIGFsbW9zdCBmdWxsLCBJIGRlY2lkZWQgdG8gdHJ5IGEgdmFsdWUgb2YgMCB0 bw0KZ2V0IHRoZSBpbnRlcnJ1cHQgYXMgc29vbiBhcyBkYXRhIGlzIGF2YWlsYWJsZSByYXRoZXIg dGhhbiB3YWl0aW5nIGZvciBhIGNodW5rLg0KV2l0aCB0aGF0LCBhbGwgUlggRklGTyBvdmVyZmxv dyBlcnJvcnMgZ28gYXdheSwgYW5kIEkgY291bGQgZXZlbiBkb3VibGUgdGhlIFNQSQ0KZnJlcXVl bmN5IHRvIDhNSHosIGdldHRpbmcgYSBzb2xpZCA2NTBLQi9zIGZyb20gdGhlIFNEIGNhcmQgd2l0 aG91dCBhbnkgZXJyb3INCmF0IGFsbC4NCg0KTXkgdGFrZToNCiogVGhpcyBjb250cm9sbGVyIGlu dGVybmFsIENTIHNlZW1zIHRvIGJlIHRvdGFsbHkgYnJva2VuLg0KKiBUaGlzIFNvQyBoYXMgcmVh bGx5IHNsb3cgaW50ZXJydXB0cywgc28gZ2VuZXJhdGluZyB0aGVzZSBlYXJsaWVyIHJhdGhlciB0 aGFuDQpsYXRlciBnaXZlcyB0aW1lIHRvIHRoZSBJUlEgaGFuZGxlciB0byBraWNrIGluIGJlZm9y ZSB0aGUgRklGTyBvdmVyZmxvd3MuDQoNCkluIHRoZSBWMiBzZXJpZXMgZm9yIFNQSSBEVywgSSBh ZGRlZCBhIERXX1NQSV9DQVBfUlhGTFRSX0NMRUFSIGNhcGFiaWxpdHkgZmxhZw0KdG8gc2V0IFJY RkxUUiB0byAwLCBhbHdheXMuIFRoYXQgd29ya3Mgd2VsbCwgYnV0IHRoaXMgaXMgbWF5IGJlIHN0 aWxsIHNpbWlsYXINCnRvIHRoZSAicG9sbGluZyIgaGFjayBpbiB0aGUgc2Vuc2UgdGhhdCBpdCBp cyB0dW5pbmcgZm9yIHRoaXMgU29DIHJhdGhlciB0aGFuIGENCnByb3BlcnR5IG9mIHRoZSBjb250 cm9sbGVyLiBCdXQgSSBkbyBub3Qgc2VlIGFueSBvdGhlciBzaW1wbGUgd2F5IG9mIHJlbW92aW5n DQp0aGVzZSBhbm5veWluZyBSWCBGSUZPIG92ZXJmbG93IGVycm9ycy4NCg0KPiBPbiB0aGUgb3Ro ZXIgaGFuZCB0aGUgZXJyb3JzIChidXQgbm90IHRoZSBSeCBGSUZPIG92ZXJmbG93KSBtaWdodCBi ZQ0KPiBjYXVzZWQgYnkgdGhlIERXIEFQQiBTU0kgbmFzdHkgZmVhdHVyZSBvZiB0aGUgbmF0aXZl IGNoaXAtc2VsZWN0DQo+IGF1dG9tYXRpYyBhc3NlcnRpb24vZGUtYXNzZXJ0aW9uLiBTbyBpZiB5 b3VyIE1NQy1zcGkgcG9ydCBpcyBoYW5kbGVkDQo+IGJ5IHRoZSBuYXRpdmUgRFcgQVBCIFNTSSBD UyBsYW5lLCB0aGVuIGl0IHdvbid0IHdvcmsgd2VsbCBmb3Igc3VyZS4NCj4gTm8gbWF0dGVyIHdo ZXRoZXIgeW91IHVzZSB0aGUgcG9sbC0gb3IgSVJRLWJhc2VkIHRyYW5zZmVycy4NCg0KSW5kZWVk LiBUaGUgR1BJTy1iYXNlZCBDUyBkb2VzIGJlaGF2ZSBtdWNoIG1vcmUgbmljZWx5LCBhbmQgaXQg ZG9lcyBub3QgcmVxdWlyZQ0KdGhhdCAiZHJpdmUgTU9TSSBsaW5lIGhpZ2giIGhhY2suIEJ1dCBm b3IgcmVhc29ucyB0aGF0IEkgc3RpbGwgZG8gbm90IGNsZWFybHkNCnVuZGVyc3RhbmQsIG9jY2Fz aW9uYWwgUlggRklGTyBvdmVyZmxvdyBlcnJvcnMgc3RpbGwgc2hvdyB1cC4NCg0KDQpUaGFua3Mg Zm9yIGFsbCB0aGUgdXNlZnVsIGNvbW1lbnRzICENCg0KLS0gDQpEYW1pZW4gTGUgTW9hbA0KV2Vz dGVybiBEaWdpdGFsDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45E6CC56202 for ; Fri, 13 Nov 2020 09:23:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83CA522244 for ; Fri, 13 Nov 2020 09:23:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="f+Z3Em+B"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=wdc.com header.i=@wdc.com header.b="k79jc4iW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="GgpkyfWc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83CA522244 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NWr8BCixR6JsYSznF3f51spAbuAWVkQn9WpAiA73ZBA=; b=f+Z3Em+BZs9XvqkJHuw3uady3 qmM62DU8AC9QMnVR843a2NlMotpvAS6ghu7B9Tj0UhGiYBcj+e/r1Vb5NyxoK1LXZxocwffExA554 e2HICZVRUh7fZjtNC3tp72deX4/9khDbh32kWBeq4lycRL1915IxufWLo7DkDo9agB9kS0jPnFedY eKRENmEzPQuOpid77mppqroWaFDGgQUuYrPSIL+nOQbjY7TLM9qWsKnz1GWkFA9wmrQpZga7drwxz cy7bpfUgnEV4OoEsq/AVwY8r9fCtRUZpGuNwHgxDMVvM2j1ZZTIc0oMSEuNS6UDY+AGT8QDNUFmCn bCP+vYdAA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdVIL-0000nx-I9; Fri, 13 Nov 2020 09:23:01 +0000 Received: from esa6.hgst.iphmx.com ([216.71.154.45]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdVIJ-0000nE-3f for linux-riscv@lists.infradead.org; Fri, 13 Nov 2020 09:23:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1605259379; x=1636795379; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=vhGPTPVvs/GLZ1bKVr+gHsQslM5YUkDznIdkuBcpxtc=; b=k79jc4iWWXNid8GCqrZQJbQc7K+u3kxFDgrgKXWmgI1B1lBV1DKnRfr1 7lYiYNsbBh9MUfOh5W71tEI96wlqoXMmVR/ud+Lpv4o6Povyp9KGIESnu JH7WEsLX6mK++kOImua9kFMwMqZFVhIQQBeW6QZwO6G6QFMjuNyvWXh2e dssKkUK3pk5Cz+IfyYOF6yLKbYefeCDO+a7Fgaz/vOZkPZqGBGuoX//gG omx0Pof6ra7QKF4cZy3fAkNOE0BKWv+RGa4yzu5wvr3+3XsKVba2CMzuj Mm0jWYMBHgynC2EOvzeXn0Llr8QTV2KoOleIYtpJ3AcfeY2ENzgxQC7GI w==; IronPort-SDR: ElwMMwfYKt4favxwrpLC/WejHDJrF8Np7EtjX4RZAmg5AtoHtgvCH4NtfeN1o7WUHlzp6DvPdS 0+/8SfNn9nSRkuTcUK0tq91QOrvqa/PrIp3r/PZNNMaUh4uCfnZyaKNEVId3k+DmyEhKD45enX /2afucd5N3jZajveC0OPrmwPpe3RqVLzZTtHaMTJr5fmenxcI0FBvrjCKzbOY/Z1IyNX7mw9qb EmP96LznoH/bJTjZRSg2FyA2vlwOYmD2bMscqBN+3QrnNts7iPpyabm9ZgtyEZ6BFTuol0FWm6 PMw= X-IronPort-AV: E=Sophos;i="5.77,475,1596470400"; d="scan'208";a="153755605" Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44]) by ob1.hgst.iphmx.com with ESMTP; 13 Nov 2020 17:22:57 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L+EMzhyt/NHwJatoy7AGoUNqC5aNoQMFLOtaIeYovuAZ0f/ADB4eiLRWYZBYNvvpnqTVz8nNz7ojyWTii1d7fPrpnmEd7JcNoagHDaTlgAkzOqbMxmLitkjHMX8RTG3glN5UelQ0WycQYPAsdiovc8SUwyD23PYCTSOxEUdwVc/mj8KTqsFfyGYtsoTngWXjtMAsAIRaYMs0cmIV7VmiEO5PH+JvgaVyhFYIoc89LqYzqZ2I1JMNHjbzHU4HgEUvdJntUiyCJIBrxysWPoYKMxzXKqq0ijxzj4ASVhhp8BtXH1eicRbMu7oHdfbgH7OpdhfBzX34t897XmB5GClKyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vhGPTPVvs/GLZ1bKVr+gHsQslM5YUkDznIdkuBcpxtc=; b=d7MV5Jeep/0xiKrWWaCFZS+WdYEpUuguYUdf/KpOpkTNZ/HoWsDVzhOKdBxIjs/z+1CuaB2k7Vi7rmJf4yTFCNdLrq1Xp/XEmCx2iLKm+iXgNKa5xg5Q5BNIvAhvyqDZZCyuLvUqjKK8ujIxkCFMKytEmbjmWoASeJFUMBXrt36Rmh4qCc5BMMdGQcnLcU8R1EBipdj0EtIUSYC7NeRkOyhvtoa8DnxBjUr6hqiTDsGansJQd/584vJKbG+s8NH31TrZ5mrYlZyXAJCmCPpSYQNDQkWkuyZpR5tcKV7dydcy8N3uNSenbH5zWcEQkiRj2/nJh8eAs0/MVtqsiYCraQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vhGPTPVvs/GLZ1bKVr+gHsQslM5YUkDznIdkuBcpxtc=; b=GgpkyfWcOErWTXW6hSO2YC+YegpQyidTEUAisw+9MAnNJmI72I7/zO59cWQqwBcVRbVAO9gTcrIkuFf51qXJgeC6k9U4+05eDa4bh6JnqCqsnS/rNNeXfwkxpnvgeGvwsJGSZY97Q2AQFTAfOVHvA2rGllNO+P8fH0JPqq9i0jk= Received: from BL0PR04MB6514.namprd04.prod.outlook.com (2603:10b6:208:1ca::23) by BL0PR04MB6595.namprd04.prod.outlook.com (2603:10b6:208:1c5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Fri, 13 Nov 2020 09:22:54 +0000 Received: from BL0PR04MB6514.namprd04.prod.outlook.com ([fe80::4c3e:2b29:1dc5:1a85]) by BL0PR04MB6514.namprd04.prod.outlook.com ([fe80::4c3e:2b29:1dc5:1a85%7]) with mapi id 15.20.3499.032; Fri, 13 Nov 2020 09:22:54 +0000 From: Damien Le Moal To: "fancer.lancer@gmail.com" Subject: Re: [PATCH 04/32] spi: dw: Introduce polling device tree property Thread-Topic: [PATCH 04/32] spi: dw: Introduce polling device tree property Thread-Index: AQHWtN4Jq5yxP9fdykKNjBOI754ZyqnAO9uAgAWXiAA= Date: Fri, 13 Nov 2020 09:22:54 +0000 Message-ID: <58943f7988706497040cac6f6108336286e9d15f.camel@wdc.com> References: <20201107081420.60325-1-damien.lemoal@wdc.com> <20201107081420.60325-5-damien.lemoal@wdc.com> <20201109195913.itgfj2ga5y7sr6zx@mobilestation> In-Reply-To: <20201109195913.itgfj2ga5y7sr6zx@mobilestation> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.38.1 (3.38.1-1.fc33) authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=wdc.com; x-originating-ip: [2400:2411:43c0:6000:8d3e:27aa:85c2:44b5] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 91bc297d-efe6-487b-ca16-08d887b5b3a8 x-ms-traffictypediagnostic: BL0PR04MB6595: x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0JpO55x7+SlY9NIpI10WB13VmycVDTQEUJHX8fqivHJ0nmvus8pZOMLDtMAOB3rLZkPiQurAAolfA/gDZDFEy5qa9qDUO1HyBy11HlHucVBWJIWK0wetmidtPsgf0t/Ri+0s02hGufs3UIHl9lLy66iLx2i7HZ9RQ00IFRLlyucTkugo+hsa8IwvUAajjr2ZFFWIrxX7J/FlWTEdWf/BDsXvfI/FwQP2ZnUYOszFptaTaPj1O1X28/1560f+1Lj2eIpbKvvK/uZpquWHcwzV6u+CUy79d5pP3MgGF9GTlVGCHz4wyaw/iy1dgVLx9rtHs3LqnghxmcrGLvsGSgm8yA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR04MB6514.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(39860400002)(366004)(136003)(396003)(36756003)(6512007)(2906002)(478600001)(66946007)(6506007)(4326008)(86362001)(316002)(83380400001)(6486002)(5660300002)(8676002)(66556008)(66476007)(54906003)(64756008)(76116006)(6916009)(8936002)(91956017)(2616005)(71200400001)(66446008)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: BXzjWKrmB1KLdMYqnRTBD8HXCg5WLgAoiU+uvkcBsY4o+NTNB1sGDbXtUwYcVp5SEQKMGu5dMOTfSzB9r8VUxefiHfrA6a2N/zoVzNTwv9zwyfqP2Znpcs/RT4P8B1X3ZIXjJxw8DIabvWtffNmA4jYZZflpInRe6T+mcvM6P2z6W5K8f+HHr5imAgJO1coM9adGbVSyb3mkeSTWCdHsBNptifgU95jTou1dbXjboOuy154IDeF9Rj1GXODkdd8hgVwhoju+ZR/w0Vqidjrf6vBbtbOK1TCrAs32eXxK8KVjJ5YL2f9mXe8yirCQqxfez7wXCxsnBvQnYR0t4urfL97cI1XyIVANlOrQfTY59Vlp8aY9JVxfE6Nz6YKzb2aMNDy3xC7OJr8c4yyCXd55w/wJwJ/2fcN2o+4PQ4hCr5nmV15g2iEeWUg+/jo8/qfYF42gVjR5Eh+KPAxqwnkH5qFU9r3S++ppESO5YugGMXifR/1lMx9pfx8dsfzSrseUUOtns43/JKTOC6R9/93qGpdQKtuLDhYkmS8/ER2rjpueRslSyy3xpStVIyD2tUKWYqU9qXWEzo0gLoIjDxLDJNHd7Q5cEzmmKfBNi1NtRlG5FMmnOPoAF/Viz2deuye3lqKip5olMAs5nUnnI9ITUcWji2hals4RYn7sJYd23ZUl+qLih2uvq42icOkMd1LSoWmWEBnYM/9AcXfftAPgRw== x-ms-exchange-transport-forked: True Content-ID: MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR04MB6514.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91bc297d-efe6-487b-ca16-08d887b5b3a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2020 09:22:54.4395 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: v9bcGwCY6kIij6wcZ15uLQuhrJ37x1wINqwOJB1fJ5koXxl9ehs39oCMMceEkNtK2UvCiTMf8yuS9ith7ahcHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR04MB6595 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201113_042259_468297_12C8E346 X-CRM114-Status: GOOD ( 31.40 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-riscv@lists.infradead.org" , "broonie@kernel.org" , "palmer@dabbelt.com" , "seanga2@gmail.com" , "linux-spi@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, 2020-11-09 at 22:59 +0300, Serge Semin wrote: > On Sat, Nov 07, 2020 at 05:13:52PM +0900, Damien Le Moal wrote: > > With boards that have slow interrupts context switch, and a fast device > > connected to a spi master, e.g. an SD card through mmc-spi, > > > using > > dw_spi_poll_transfer() intead of the regular interrupt based > > dw_spi_transfer_handler() function is more efficient and > > I can believe in that. But the next part seems questionable: > > > can avoid a lot > > of RX FIFO overflow errors while keeping the device SPI frequency > > reasonnably high (for speed). > > No matter whether it's an IRQ-based or poll-based transfer, as long as a > client SPI-device is connected with a GPIO-based chip-select (or the > DW APB SSI-controller feature of the automatic chip-select toggling is > fixed), the Rx FIFO should never overrun. It's ensured by the transfer > algorithm design by calculating the rxtx_gap in the dw_writer() > method. If the error still happens then there must be some bug in > the code. > > It's also strange to hear that the polling-based transfer helps > to avoid the Rx FIFO overflow errors, while the IRQ-based transfer > causes them. Both of those methods are based on the same dw_writer() > and dw_reader() methods. So basically they both should either work > well or cause the errors at same time. > > So to speak could you more through debug your case? I did. And I have much better results now. Let me explain: 1) The device tree was setting up the SPI controller using the controller internal chip select, not a GPIO-based chip select. Until now, I could never get the GPIO-based chip select to work. I finally found out why: I simply needed to add the "spi-cs-high" property to the mmc-slot node. With that, the CS gpio is correctly driven active-high instead of the default active-low and the SD card works. 2) With this change using the GPIO-based CS, the patch "spi: dw: Fix driving MOSI low while receiving" became completely unnecessary. The SD card works without it. Now for testing, I also removed this polling change. Results are these: 1) With the same SPI frequency as before (4MHz), I can run the SD card at about 300 KB/s (read) but I am still seeing some RX FIFO overflow errors. Not a lot, but enough to be annoying, especially on boot as the partition scan sometimes fails because of these errors. In most cases, the block layer retry of failed read/writes cover and no bad errors happen, but the RX FIFO overflow error messages still pop up. 2) Looking into the code further, I realized that RXFLTR is set to half the fifo size minus 1. That sound reasonable, but as that delays interrupt generation until the RX fifo is almost full, I decided to try a value of 0 to get the interrupt as soon as data is available rather than waiting for a chunk. With that, all RX FIFO overflow errors go away, and I could even double the SPI frequency to 8MHz, getting a solid 650KB/s from the SD card without any error at all. My take: * This controller internal CS seems to be totally broken. * This SoC has really slow interrupts, so generating these earlier rather than later gives time to the IRQ handler to kick in before the FIFO overflows. In the V2 series for SPI DW, I added a DW_SPI_CAP_RXFLTR_CLEAR capability flag to set RXFLTR to 0, always. That works well, but this is may be still similar to the "polling" hack in the sense that it is tuning for this SoC rather than a property of the controller. But I do not see any other simple way of removing these annoying RX FIFO overflow errors. > On the other hand the errors (but not the Rx FIFO overflow) might be > caused by the DW APB SSI nasty feature of the native chip-select > automatic assertion/de-assertion. So if your MMC-spi port is handled > by the native DW APB SSI CS lane, then it won't work well for sure. > No matter whether you use the poll- or IRQ-based transfers. Indeed. The GPIO-based CS does behave much more nicely, and it does not require that "drive MOSI line high" hack. But for reasons that I still do not clearly understand, occasional RX FIFO overflow errors still show up. Thanks for all the useful comments ! -- Damien Le Moal Western Digital _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv