From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7732BC433EF for ; Fri, 17 Sep 2021 14:24:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8A7961130 for ; Fri, 17 Sep 2021 14:24:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D8A7961130 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:48672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mREnE-0001Zi-UT for qemu-devel@archiver.kernel.org; Fri, 17 Sep 2021 10:24:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mREmH-0000mr-3b for qemu-devel@nongnu.org; Fri, 17 Sep 2021 10:23:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:40842) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mREmC-0002C0-FO for qemu-devel@nongnu.org; Fri, 17 Sep 2021 10:23:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631888618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q1u/TMeoM1KouwUHSsb4ePtvOgIVe/SP1DHW3hsrYj8=; b=drKL44HPhqdYPp5pqOPgqHh+h6FNpMfREXbUuPKYg5vKeRXip/tJf0yllsfZ71eA+w5UB6 galW2nflIc/a+crQ1+4IUli7M7dQeR3B8nb6fyHW5VPMkb3ZNh7SNGi3vWQRgZD5ajmhti P+n19j3DEtabVeHpOYm6SA0q41xjks0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-287-2d02yLf0O8WQE_0Lnf2fzQ-1; Fri, 17 Sep 2021 10:23:36 -0400 X-MC-Unique: 2d02yLf0O8WQE_0Lnf2fzQ-1 Received: by mail-wm1-f70.google.com with SMTP id y23-20020a05600c365700b003015b277f98so1789702wmq.2 for ; Fri, 17 Sep 2021 07:23:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=q1u/TMeoM1KouwUHSsb4ePtvOgIVe/SP1DHW3hsrYj8=; b=sMg78AqZl/u608uQMyvYsaohYn9+itPD4dCgE51snS5RW0HGK4AfKWSgn/iWvnjZQB XeQLY/94iOtBwkollQOdem1b3htvzcamw1D7H/NYKhctERYn+cDXeFjcyGB2Do1T+6A6 34UYfmh6k9TviXBZLywlvZgm7sqPJgSLaDg8W12wXDzLpX4oaZY9K+sf+Xu5azjIXs2a 2rgzjLi4zcvow03husbYQfTS52RmOBa4gBGjPWXDayC77jdjPmvkV/tL+33VU61mY0z+ NfBu6V+M6GTQMZ0FvLV90pf5XbYe/CEcajKZstK/VYbCKUrQp0/Dyd87VcPfwBXV/b3p vFaA== X-Gm-Message-State: AOAM533wzZfwfQibbAejZnEx1DO5etEVtS3flwLElcq0aoJM/T1fXiez 5ooREN86qEz19bOqAzkOBzsoUqGpmfhBYqMbBFZQe7bMQhzIaWsA65X2XXHXNRfvJrm36gChNGV AzPpDvVe2Fxznw4I= X-Received: by 2002:adf:e603:: with SMTP id p3mr12553195wrm.357.1631888615837; Fri, 17 Sep 2021 07:23:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNWKFMLBvyQn3pvaNopJ00nUXRaFTzoAEoHo1QW0QE6AxoSgT6uf6Wo0kvPgF1LMiMEJ6nJw== X-Received: by 2002:adf:e603:: with SMTP id p3mr12553160wrm.357.1631888615607; Fri, 17 Sep 2021 07:23:35 -0700 (PDT) Received: from dresden.str.redhat.com ([2a02:908:1e48:3780:4451:9a65:d4e9:9bb6]) by smtp.gmail.com with ESMTPSA id u25sm10802696wmj.10.2021.09.17.07.23.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Sep 2021 07:23:35 -0700 (PDT) Subject: Re: [PATCH 11/15] python/aqmp: Create sync QMP wrapper for iotests To: John Snow , qemu-devel@nongnu.org References: <20210917054047.2042843-1-jsnow@redhat.com> <20210917054047.2042843-12-jsnow@redhat.com> From: Hanna Reitz Message-ID: <5896598a-ebd3-daf4-aff2-0bee44ea8d5e@redhat.com> Date: Fri, 17 Sep 2021 16:23:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210917054047.2042843-12-jsnow@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=hreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) DKIMWL_WL_HIGH=-0.392, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.488, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , Eduardo Habkost , qemu-block@nongnu.org, Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 17.09.21 07:40, John Snow wrote: > This is a wrapper around the async QMPClient that mimics the old, > synchronous QEMUMonitorProtocol class. It is designed to be > interchangeable with the old implementation. > > It does not, however, attempt to mimic Exception compatibility. > > Signed-off-by: John Snow > --- > python/qemu/aqmp/legacy.py | 131 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 131 insertions(+) > create mode 100644 python/qemu/aqmp/legacy.py Looks reasonable to me, although I can’t give an R-b in good conscience.  I’m tempted to give a neo-tag (“Looks-okay-to:”), but let’s just be boring and do an Acked-by: Hanna Reitz