From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932310AbdBJTuQ (ORCPT ); Fri, 10 Feb 2017 14:50:16 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34185 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932249AbdBJTuO (ORCPT ); Fri, 10 Feb 2017 14:50:14 -0500 Subject: Re: [PATCH 2/5] drm: of: introduce drm_of_find_panel_or_bridge To: Rob Herring , David Airlie , Daniel Vetter , Sean Paul References: <20170204033635.10250-1-robh@kernel.org> <20170204033635.10250-3-robh@kernel.org> Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Boris Brezillon , Archit Taneja , Jingoo Han , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Stefan Agner , Alison Wang , Xinliang Liu , Rongrong Zou , Xinwei Kong , Chen Feng , Philipp Zabel , CK Hu , Matthias Brugger , Marek Vasut , Mark Yao , Heiko Stuebner , Maxime Ripard , Chen-Yu Tsai , Liviu Dudau , Mali DP Maintainers , Neil Armstrong , Carlo Caione , Kevin Hilman , Rob Clark , Jyri Sarha , Tomi Valkeinen , Eric Anholt , Russell King From: Frank Rowand Message-ID: <589E17BF.1060106@gmail.com> Date: Fri, 10 Feb 2017 11:42:55 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20170204033635.10250-3-robh@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/03/17 19:36, Rob Herring wrote: > Many drivers have a common pattern of searching the OF graph for either an > attached panel or bridge and then finding the DRM struct for the panel > or bridge. Also, most drivers need to handle deferred probing when the > DRM device is not yet instantiated. Create a common function, > drm_of_find_panel_or_bridge, to find the connected node and the > associated DRM panel or bridge device. > > Signed-off-by: Rob Herring > --- > drivers/gpu/drm/drm_of.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++ > include/drm/drm_of.h | 13 +++++++++++++ > 2 files changed, 63 insertions(+) > > diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c > index 47848ed8ca48..b29ce2f52113 100644 > --- a/drivers/gpu/drm/drm_of.c > +++ b/drivers/gpu/drm/drm_of.c > @@ -3,7 +3,9 @@ > #include > #include > #include > +#include > #include > +#include > #include > > static void drm_release_of(struct device *dev, void *data) > @@ -207,3 +209,51 @@ int drm_of_encoder_active_endpoint(struct device_node *node, > return -EINVAL; > } > EXPORT_SYMBOL_GPL(drm_of_encoder_active_endpoint); > + > +/* > + * drm_of_find_panel_or_bridge - return connected panel or bridge device > + * @np: device tree node containing encoder input ports @port: .... @endpoint: .... > + * @panel: pointer to hold returned drm_panel > + * @bridge: pointer to hold returned drm_bridge > + * > + * Given a DT node's port and endpoint number, find the connected node and > + * return either the associated struct drm_panel or drm_bridge device. > + * > + * Returns zero if successful, or one of the standard error codes if it fails. > + */ > +int drm_of_find_panel_or_bridge(const struct device_node *np, > + int port, int endpoint, > + struct drm_panel **panel, > + struct drm_bridge **bridge) > +{ < snip > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank Rowand Subject: Re: [PATCH 2/5] drm: of: introduce drm_of_find_panel_or_bridge Date: Fri, 10 Feb 2017 11:42:55 -0800 Message-ID: <589E17BF.1060106@gmail.com> References: <20170204033635.10250-1-robh@kernel.org> <20170204033635.10250-3-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170204033635.10250-3-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring , David Airlie , Daniel Vetter , Sean Paul Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Boris Brezillon , Archit Taneja , Jingoo Han , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Stefan Agner , Alison Wang , Xinliang Liu , Rongrong Zou , Xinwei Kong , Chen Feng Philipp Zabel

List-Id: devicetree@vger.kernel.org On 02/03/17 19:36, Rob Herring wrote: > Many drivers have a common pattern of searching the OF graph for either an > attached panel or bridge and then finding the DRM struct for the panel > or bridge. Also, most drivers need to handle deferred probing when the > DRM device is not yet instantiated. Create a common function, > drm_of_find_panel_or_bridge, to find the connected node and the > associated DRM panel or bridge device. > > Signed-off-by: Rob Herring > --- > drivers/gpu/drm/drm_of.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++ > include/drm/drm_of.h | 13 +++++++++++++ > 2 files changed, 63 insertions(+) > > diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c > index 47848ed8ca48..b29ce2f52113 100644 > --- a/drivers/gpu/drm/drm_of.c > +++ b/drivers/gpu/drm/drm_of.c > @@ -3,7 +3,9 @@ > #include > #include > #include > +#include > #include > +#include > #include > > static void drm_release_of(struct device *dev, void *data) > @@ -207,3 +209,51 @@ int drm_of_encoder_active_endpoint(struct device_node *node, > return -EINVAL; > } > EXPORT_SYMBOL_GPL(drm_of_encoder_active_endpoint); > + > +/* > + * drm_of_find_panel_or_bridge - return connected panel or bridge device > + * @np: device tree node containing encoder input ports @port: .... @endpoint: .... > + * @panel: pointer to hold returned drm_panel > + * @bridge: pointer to hold returned drm_bridge > + * > + * Given a DT node's port and endpoint number, find the connected node and > + * return either the associated struct drm_panel or drm_bridge device. > + * > + * Returns zero if successful, or one of the standard error codes if it fails. > + */ > +int drm_of_find_panel_or_bridge(const struct device_node *np, > + int port, int endpoint, > + struct drm_panel **panel, > + struct drm_bridge **bridge) > +{ < snip > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html