From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA43EC43219 for ; Fri, 19 Nov 2021 08:57:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C68CF61AED for ; Fri, 19 Nov 2021 08:57:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234505AbhKSJA4 (ORCPT ); Fri, 19 Nov 2021 04:00:56 -0500 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:39242 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229667AbhKSJAz (ORCPT ); Fri, 19 Nov 2021 04:00:55 -0500 Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 469223F197 for ; Fri, 19 Nov 2021 08:57:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1637312273; bh=Q2Xq+lz5R/zlPr5E9PhfPrpqfALjDZ550sxUN46fIkA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ajczkAhxmtPh01kCJPAg7qWo/V+5zbsy0HXo0+lZmgSKJPrseWPkwPLft6cimDQwt 2EGFtKgBfQZ08IhH6eHcjsDZawbjNzM/l9O9Y1rWvlZLiCkbaxorvFDyQ+cD6ehf78 4QRi8S8ZcCv9WwVtqfXUo0ucF2MigUYroCI49/WENNXL+2TuSLOLfpV16deUOGJloE iwBXclxVS71tib6sj/LNxoLEiPuhnYwWW7jFCufH3ZFS5M2nv0jKrwJ2maREwfgf9j 33LQEmE6SoQK3IccHb9tmPStRcGXE6q9IuDbcX7nO7YS+QFBEJVdcIqESYvsrIqUEj MHsjpz5LgclnA== Received: by mail-lf1-f71.google.com with SMTP id bq29-20020a056512151d00b003ffce2467adso6114828lfb.3 for ; Fri, 19 Nov 2021 00:57:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Q2Xq+lz5R/zlPr5E9PhfPrpqfALjDZ550sxUN46fIkA=; b=pkjxSUOsYCSU2R8Njq56tSNfBizgZGWvvW4V9PqWzMAOnTdlYr3HapBwoEI9j/Fif5 amxuGhT/ptXKpwjOQAeN4z4IZnHfveqn5f2Jc9c1ONRRsU3PyWP6MDDrriTa79tmvfJn qn//a5DkNXQ5+SSXVVtu5yS//14L/31GXPbU8d6Un9nXDGd1fKoG/IUCfCDBYLRUTrFf TTHK+NfLU9KTOpowcLxjzYXA7AVSpNW6EXMbHbRsYFIXSQhSQXos1mac2APJGz1Ggt04 yRpDxxXU1eiEZqPApu3TgreBFILfEsi6Xg54xWNwav6CWsPp84/eudh04RXy0pFWjQKM 8eXA== X-Gm-Message-State: AOAM531zY5goHThxVHYyxt5uE+EsGm0Q7koNyhqEPZQIYCo0m+BdHUwy 5rHeGSV6OTxHxVwFx55L7Te9By8bUIahAl6ZSO5znKiPmvOmKnC8uisfxr2mZjWhmzYPYLQ9cKz snXuQz8iD8Spn7iT0yZyiHOHAKj4XqqFdlPwi2p1iWg== X-Received: by 2002:a2e:9a09:: with SMTP id o9mr24529355lji.21.1637312272751; Fri, 19 Nov 2021 00:57:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJxlLab4GnUpev9rIdVitfS5kqSKRDOwtirMnZsL11xiqoH898mmLHs7m3hFj0tATN8s62/2+A== X-Received: by 2002:a2e:9a09:: with SMTP id o9mr24529318lji.21.1637312272447; Fri, 19 Nov 2021 00:57:52 -0800 (PST) Received: from [192.168.3.67] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id t7sm300122lfg.115.2021.11.19.00.57.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Nov 2021 00:57:51 -0800 (PST) Message-ID: <589dbb7f-4f7c-0ae0-e899-04107accf23c@canonical.com> Date: Fri, 19 Nov 2021 09:57:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH v3 1/2] dt-bindings: i2c: exynos5: add exynosautov9-hsi2c compatible Content-Language: en-US To: Jaewon Kim , Wolfram Sang , Rob Herring Cc: linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, chanho61.park@samsung.com, linux-arm-kernel@lists.infradead.org, Sam Protsenko References: <20211112010137.149174-1-jaewon02.kim@samsung.com> <20211112010137.149174-2-jaewon02.kim@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20211112010137.149174-2-jaewon02.kim@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/11/2021 02:01, Jaewon Kim wrote: > This patch adds new "samsung,exynosautov9-hsi2c" compatible. > It is for i2c compatible with HSI2C available on Exynos SoC with USI. > > Signed-off-by: Jaewon Kim > Reviewed-by: Krzysztof Kozlowski Thanks Jaewon for your patch. After more discussions and remarks from David, I think we should go with dedicated USI driver instead of using sysreg/syscon in every I2C/UART/SPI. Therefore I want to remove my reviewed-by and instead ask to work on dedicated USI driver (option 1 from Chanho's email). It's not that this solution is anything bad, just it won't be flexible to support USIv1. It will also lead to duplicated - and possibly conflicting - USI configuration in each of drivers (I2C/UART/SPI). > --- > Documentation/devicetree/bindings/i2c/i2c-exynos5.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-exynos5.txt b/Documentation/devicetree/bindings/i2c/i2c-exynos5.txt > index 2dbc0b62daa6..39f4067d9d1f 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-exynos5.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-exynos5.txt > @@ -14,6 +14,8 @@ Required properties: > on Exynos5260 SoCs. > -> "samsung,exynos7-hsi2c", for i2c compatible with HSI2C available > on Exynos7 SoCs. > + -> "samsung,exynosautov9-hsi2c", for i2c compatible with HSI2C available > + on ExynosAutov9 SoCs. > > - reg: physical base address of the controller and length of memory mapped > region. > @@ -31,6 +33,11 @@ Optional properties: > at 100khz. > -> If specified, the bus operates in high-speed mode only if the > clock-frequency is >= 1Mhz. > + - samsung,sysreg : system registers controller phandle to control USI. > + -> If I2C integrated to USI(Universal Serial Interface), this property > + is required. When using Exynos USI block, it needs to select which type > + of Serial IPs(UART, SPI, I2C) to use with system register. So, it > + requires samsung,sysreg phandle and offset value of system register. > > Example: > > Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6D6BC433F5 for ; Fri, 19 Nov 2021 09:00:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9EAA761401 for ; Fri, 19 Nov 2021 09:00:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9EAA761401 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FVi5VQ1+rrU/w+QpX2y9dsGv/EGZ/dFf+gLuFsFOIys=; b=adatrKlZk1OiNt 7kTdVpEjjujTaa+HWxCGt0z8v/bgxfmi9HjW37/aLKa6JtxZO0FUXyCoVeJYezD24ujQb2MrSw+TH yal4ZgXRLt6N3ZBQAV31IWeRr/13zCYUcWSi16avvze2g+cT3SyJv5knNof/HbCV9E6R44c+awASv BLbynu3XzEhVSJH8QkMdT5K2o+H1bQgAkkDAtA+ZhlicWMF0oWywmDv3ztgSt8/BoPUhJDHQ8c+jh XouweXN5FeFojRGJqg7UqdlLBPLnbwnvY8ZtdMEqJjE3sR29MqwNcMLSFVZhpBvxVAr24JNVAJjQZ 02th0n/E+Nvb8Uzviu6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnzjB-009s8m-S8; Fri, 19 Nov 2021 08:58:38 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnziU-009rsI-IC for linux-arm-kernel@lists.infradead.org; Fri, 19 Nov 2021 08:57:56 +0000 Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 47B2B3F1D2 for ; Fri, 19 Nov 2021 08:57:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1637312273; bh=Q2Xq+lz5R/zlPr5E9PhfPrpqfALjDZ550sxUN46fIkA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ajczkAhxmtPh01kCJPAg7qWo/V+5zbsy0HXo0+lZmgSKJPrseWPkwPLft6cimDQwt 2EGFtKgBfQZ08IhH6eHcjsDZawbjNzM/l9O9Y1rWvlZLiCkbaxorvFDyQ+cD6ehf78 4QRi8S8ZcCv9WwVtqfXUo0ucF2MigUYroCI49/WENNXL+2TuSLOLfpV16deUOGJloE iwBXclxVS71tib6sj/LNxoLEiPuhnYwWW7jFCufH3ZFS5M2nv0jKrwJ2maREwfgf9j 33LQEmE6SoQK3IccHb9tmPStRcGXE6q9IuDbcX7nO7YS+QFBEJVdcIqESYvsrIqUEj MHsjpz5LgclnA== Received: by mail-lf1-f72.google.com with SMTP id n18-20020a0565120ad200b004036c43a0ddso6106090lfu.2 for ; Fri, 19 Nov 2021 00:57:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Q2Xq+lz5R/zlPr5E9PhfPrpqfALjDZ550sxUN46fIkA=; b=zdHJaR7f+Usem6tvCHfMDSJyiHQ1ktRhRBDBfm40FAJ6H2hEx58NgnJTIyBxC3Q8I5 YjNdx5hDVcIEB2vIWNmd+zadvc4V3i8E8mfk+hSTBA0XyKG+U8P6WGaeQes2D1FQeCoD iShDtpL/mEe9XKe5incCYGGVOFtMQk3QD39eBa79skI0tF/ieUjvChgtpjn4t7s+L9E8 84j2oHJ2HEK0a5Z4/Q6BdKJPMgq1hwASkQzaYhFHWElwRbEo1Q+3z5xDLX2wx6aAujYa KPjDW7xfZeuuK1VyGVxu5Ezwgn7cAnJv+vADw9yVURx6dLK9bX+L/3RoTxNQGmkXSt3+ LJVA== X-Gm-Message-State: AOAM533RIPhfer3FitAt+3BBMUnfadaZPsyMXYGD+qPu8d1dWfgO4JXn Ev5aYZFSBQxkh9SbieJI/o5L6yhhgNj8s281gUYfhfAik3S+ikJnnLJR7ZfbRQK2loJfxcCAPnt C3uzgSVICj+jFHWtxP9yxrButowS7RP9NwyXj652oHAMsIddi5Xng X-Received: by 2002:a2e:9a09:: with SMTP id o9mr24529336lji.21.1637312272619; Fri, 19 Nov 2021 00:57:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJxlLab4GnUpev9rIdVitfS5kqSKRDOwtirMnZsL11xiqoH898mmLHs7m3hFj0tATN8s62/2+A== X-Received: by 2002:a2e:9a09:: with SMTP id o9mr24529318lji.21.1637312272447; Fri, 19 Nov 2021 00:57:52 -0800 (PST) Received: from [192.168.3.67] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id t7sm300122lfg.115.2021.11.19.00.57.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Nov 2021 00:57:51 -0800 (PST) Message-ID: <589dbb7f-4f7c-0ae0-e899-04107accf23c@canonical.com> Date: Fri, 19 Nov 2021 09:57:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH v3 1/2] dt-bindings: i2c: exynos5: add exynosautov9-hsi2c compatible Content-Language: en-US To: Jaewon Kim , Wolfram Sang , Rob Herring Cc: linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, chanho61.park@samsung.com, linux-arm-kernel@lists.infradead.org, Sam Protsenko References: <20211112010137.149174-1-jaewon02.kim@samsung.com> <20211112010137.149174-2-jaewon02.kim@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20211112010137.149174-2-jaewon02.kim@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211119_005754_786584_B8A37D87 X-CRM114-Status: GOOD ( 24.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/11/2021 02:01, Jaewon Kim wrote: > This patch adds new "samsung,exynosautov9-hsi2c" compatible. > It is for i2c compatible with HSI2C available on Exynos SoC with USI. > > Signed-off-by: Jaewon Kim > Reviewed-by: Krzysztof Kozlowski Thanks Jaewon for your patch. After more discussions and remarks from David, I think we should go with dedicated USI driver instead of using sysreg/syscon in every I2C/UART/SPI. Therefore I want to remove my reviewed-by and instead ask to work on dedicated USI driver (option 1 from Chanho's email). It's not that this solution is anything bad, just it won't be flexible to support USIv1. It will also lead to duplicated - and possibly conflicting - USI configuration in each of drivers (I2C/UART/SPI). > --- > Documentation/devicetree/bindings/i2c/i2c-exynos5.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-exynos5.txt b/Documentation/devicetree/bindings/i2c/i2c-exynos5.txt > index 2dbc0b62daa6..39f4067d9d1f 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-exynos5.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-exynos5.txt > @@ -14,6 +14,8 @@ Required properties: > on Exynos5260 SoCs. > -> "samsung,exynos7-hsi2c", for i2c compatible with HSI2C available > on Exynos7 SoCs. > + -> "samsung,exynosautov9-hsi2c", for i2c compatible with HSI2C available > + on ExynosAutov9 SoCs. > > - reg: physical base address of the controller and length of memory mapped > region. > @@ -31,6 +33,11 @@ Optional properties: > at 100khz. > -> If specified, the bus operates in high-speed mode only if the > clock-frequency is >= 1Mhz. > + - samsung,sysreg : system registers controller phandle to control USI. > + -> If I2C integrated to USI(Universal Serial Interface), this property > + is required. When using Exynos USI block, it needs to select which type > + of Serial IPs(UART, SPI, I2C) to use with system register. So, it > + requires samsung,sysreg phandle and offset value of system register. > > Example: > > Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel