From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH 1/2] VMX: fix VMCS race on context-switch paths Date: Wed, 15 Feb 2017 07:44:54 -0700 Message-ID: <58A47776020000780013A3FA@prv-mh.provo.novell.com> References: <58A2E8B70200007800139946@prv-mh.provo.novell.com> <58A2E9F9020000780013995D@prv-mh.provo.novell.com> <1487154433.3588.1.camel@citrix.com> <58A44BE8020000780013A2E2@prv-mh.provo.novell.com> <1487159333.3588.5.camel@citrix.com> <58A44FC5020000780013A316@prv-mh.provo.novell.com> <58A45FB9020000780013A36C@prv-mh.provo.novell.com> <1487166014.3588.7.camel@citrix.com> <58A473CF020000780013A3E6@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ce0pI-0002mR-SJ for xen-devel@lists.xenproject.org; Wed, 15 Feb 2017 14:45:00 +0000 In-Reply-To: <58A473CF020000780013A3E6@prv-mh.provo.novell.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Sergey Dyasli Cc: Kevin Tian , "Kevin.Mayer@gdata.de" , Andrew Cooper , Anshul Makkar , "jun.nakajima@intel.com" , "xen-devel@lists.xenproject.org" List-Id: xen-devel@lists.xenproject.org Pj4+IE9uIDE1LjAyLjE3IGF0IDE1OjI5LCA8SkJldWxpY2hAc3VzZS5jb20+IHdyb3RlOgo+Pj4+ IE9uIDE1LjAyLjE3IGF0IDE0OjQwLCA8c2VyZ2V5LmR5YXNsaUBjaXRyaXguY29tPiB3cm90ZToK Pj4gT24gV2VkLCAyMDE3LTAyLTE1IGF0IDA2OjAzIC0wNzAwLCBKYW4gQmV1bGljaCB3cm90ZToK Pj4+ID4gPiA+IE9uIDE1LjAyLjE3IGF0IDEyOjU1LCA8SkJldWxpY2hAc3VzZS5jb20+IHdyb3Rl Ogo+Pj4gPiA+ID4gPiBPbiAxNS4wMi4xNyBhdCAxMjo0OCwgPHNlcmdleS5keWFzbGlAY2l0cml4 LmNvbT4gd3JvdGU6Cj4+PiA+ID4gCj4+PiA+ID4gT24gV2VkLCAyMDE3LTAyLTE1IGF0IDA0OjM5 IC0wNzAwLCBKYW4gQmV1bGljaCB3cm90ZToKPj4+ID4gPiA+ID4gPiA+IE9uIDE1LjAyLjE3IGF0 IDExOjI3LCA8c2VyZ2V5LmR5YXNsaUBjaXRyaXguY29tPiB3cm90ZToKPj4+ID4gPiA+ID4gCj4+ PiA+ID4gPiA+IChYRU4pIFsgMTQwOC4wNzU2MzhdIFhlbiBjYWxsIHRyYWNlOgo+Pj4gPiA+ID4g PiAoWEVOKSBbIDE0MDguMDc5MzIyXSAgICBbPGZmZmY4MmQwODAxZWEyYTI+XSB2bXhfdm1jc19y ZWxvYWQrMHgzMi8weDUwCj4+PiA+ID4gPiA+IChYRU4pIFsgMTQwOC4wODYzMDNdICAgIFs8ZmZm ZjgyZDA4MDE2YzU4ZD5dIGNvbnRleHRfc3dpdGNoKzB4ODVkLzB4ZWIwCj4+PiA+ID4gPiA+IChY RU4pIFsgMTQwOC4wOTMzODBdICAgIFs8ZmZmZjgyZDA4MDEyZmI4ZT5dIAo+PiBzY2hlZHVsZS5j I3NjaGVkdWxlKzB4NDZlLzB4N2QwCj4+PiA+ID4gPiA+IChYRU4pIFsgMTQwOC4xMDA5NDJdICAg IFs8ZmZmZjgyZDA4MDE2NDMwNT5dIHJlcHJvZ3JhbV90aW1lcisweDc1LzB4ZTAKPj4+ID4gPiA+ ID4gKFhFTikgWyAxNDA4LjEwNzkyNV0gICAgWzxmZmZmODJkMDgwMTM2NDAwPl0gCj4+PiA+IAo+ Pj4gPiB0aW1lci5jI3RpbWVyX3NvZnRpcnFfYWN0aW9uKzB4OTAvMHgyMTAKPj4+ID4gPiA+ID4g KFhFTikgWyAxNDA4LjExNjI2M10gICAgWzxmZmZmODJkMDgwMTMzMTFjPl0gCj4+IHNvZnRpcnEu YyNfX2RvX3NvZnRpcnErMHg1Yy8weDkwCj4+PiA+ID4gPiA+IChYRU4pIFsgMTQwOC4xMjM5MjFd ICAgIFs8ZmZmZjgyZDA4MDE2N2QzNT5dIGRvbWFpbi5jI2lkbGVfbG9vcCsweDI1LzB4NjAKPj4+ ID4gPiA+IAo+Pj4gPiA+ID4gVGFraW5nIHlvdXIgbGF0ZXIgcmVwbHkgaW50byBhY2NvdW50IC0g d2VyZSB5b3UgYWJsZSB0byBmaWd1cmUgb3V0Cj4+PiA+ID4gPiB3aGF0IG90aGVyIHBhcnR5IGhl bGQgb250byB0aGUgVk1DUyBiZWluZyB3YWl0ZWQgZm9yIGhlcmU/Cj4+PiA+ID4gCj4+PiA+ID4g VW5mb3J0dW5hdGVseSwgbm8uIEl0IHdhcyB1bmNsZWFyIGZyb20gZGVidWcgbG9ncy4gQnV0IGp1 ZGdpbmcgZnJvbQo+Pj4gPiA+IHRoZSBmb2xsb3dpbmcgdm14X2RvX3Jlc3VtZSgpIGNvZGU6Cj4+ PiA+ID4gCj4+PiA+ID4gICAgIGlmICggdi0+YXJjaC5odm1fdm14LmFjdGl2ZV9jcHUgPT0gc21w X3Byb2Nlc3Nvcl9pZCgpICkKPj4+ID4gPiAgICAgewo+Pj4gPiA+ICAgICAgICAgaWYgKCB2LT5h cmNoLmh2bV92bXgudm1jc19wYSAhPSB0aGlzX2NwdShjdXJyZW50X3ZtY3MpICkKPj4+ID4gPiAg ICAgICAgICAgICB2bXhfbG9hZF92bWNzKHYpOwo+Pj4gPiA+ICAgICB9Cj4+PiA+ID4gCj4+PiA+ ID4gSWYgYm90aCBvZiB0aGUgYWJvdmUgY29uZGl0aW9ucyBhcmUgdHJ1ZSB0aGVuIHZteF92bWNz X3JlbG9hZCgpIHdpbGwKPj4+ID4gPiBwcm9iYWJseSBoYW5nLgo+Pj4gPiAKPj4+ID4gSSBkb24n dCBmb2xsb3cgKHJlbG9hZCBzaG91bGQgcnVuIGJlZm9yZSB0aGlzLCBub3QgYWZ0ZXIpLCBidXQg SSBtdXN0Cj4+PiA+IGJlIG1pc3Npbmcgc29tZXRoaW5nIG1vcmUgZ2VuZXJhbCBhbnl3YXksIGFz IEknbSBzZWVpbmcgdGhlIGNvZGUKPj4+ID4gYWJvdmUgYmVpbmcgbmVlZGVkIGRlc3BpdGUgdGhl IHJlbG9hZCBhZGRpdGlvbnMuCj4+PiAKPj4+IEkgdGhpbmsgSSd2ZSB1bmRlcnN0b29kIHBhcnQg b2YgaXQgb3ZlciBsdW5jaDogU3VycHJpc2luZ2x5IGVub3VnaAo+Pj4gdm14X2N0eHRfc3dpdGNo X3RvKCkgZG9lc24ndCByZS1lc3RhYmxpc2ggdGhlIFZNQ1MsIHNvIGl0IG5lZWRzCj4+PiB0byBi ZSBkb25lIGhlcmUuIFdoaWNoIEkgdGhpbmsgbWVhbnMgd2UgZG9uJ3QgbmVlZCB0aGUgbmV3Cj4+ PiBob29rIGF0IGFsbCwgYXMgdGhhdCB3YXkgdGhlIHN0YXRlIGlzIG5vIGRpZmZlcmVudCBiZXR3 ZWVuIGdvaW5nCj4+PiB0aHJvdWdoIC0+dG8oKSBvciBieXBhc3NpbmcgaXQuCj4+PiAKPj4+IFdo YXQgSSBjb250aW51ZSB0byBub3QgdW5kZXJzdGFuZCBpcyB3aHkgdm1jc19wYSB3b3VsZCBldmVy Cj4+PiBub3QgbWF0Y2ggY3VycmVudF92bWNzIHdoZW4gYWN0aXZlX2NwdSBpcyBzbXBfcHJvY2Vz c29yX2lkKCkuCj4+PiBTbyBmYXIgSSB0aG91Z2h0IGJvdGggYXJlIGFsd2F5cyB1cGRhdGVkIHRv Z2V0aGVyLiBMb29raW5nCj4+PiBmdXJ0aGVyIC4uLgo+PiAKPj4gVGhpcyBpcyBleGFjdGx5IHdo YXQgd2lsbCBoYXBwZW4gc2hvdWxkIHRoZSAzLjEgb2NjdXI6Cj4+IAo+PiAgICAgMS4gSFZNIHZD UFUjMSAtLT4gaWRsZSB2Q1BVIGNvbnRleHRfc3dpdGNoCj4+IAo+PiAgICAgMi4gc29mdGlycSAt LT4gdm14X3ZtY3NfZW50ZXIoKSArIHZteF92bWNzX2V4aXQoKSBmb3IgYSByZW1vdGUgdkNQVQo+ PiAgICAgICAgW3NjZW5hcmlvIHdpdGggUE1MXQo+PiAgICAgICAgVGhpcyB3aWxsIHN3aXRjaCBj dXJyZW50X3ZtY3MgdG8gYSByZW1vdGUgb25lLgo+PiAgICAgICAgaGFzX2h2bV9jb250YWluZXJf dmNwdShjdXJyZW50KSB3aWxsIGJlIGZhbHNlIGFuZCB2bWNzIHdpbGwgbm90Cj4+ICAgICAgICBi ZSByZWxvYWRlZC4KPiAKPiBPaCwgcmlnaHQgLSB0aGlzIHVwZGF0ZXMgdidzIGFjdGl2ZV9jcHUs IGJ1dCBkb2Vzbid0IHVwZGF0ZSB0aGUKPiBmaWVsZCBmb3IgdGhlIHZDUFUgdGhlIFZNQ1MgaXMg YmVpbmcgdGFrZW4gYXdheSBmcm9tLgoKV2hpY2ggdGhlbiBhbHNvIGluZGljYXRlcyBhIGxpa2Vs eSByZWFzb24gZm9yIHRoZSBlbmRsZXNzIGxvb3AgeW91CnNhdyB3aXRoIG15IHBhdGNoIC0gdGhl IHNwaW4gbG9vcCAod2hpY2ggSSdtIG5vIGxvbmdlciBjb252aW5jZWQgaXMKbmVlZGVkIGF0IGFs bCkgd291bGQgbmVlZCB0byBiZSBza2lwcGVkIGlmIHRoZSBjdXJyZW50IENQVSBpcyB0aGUKYWN0 aXZlIG9uZToKCnZvaWQgdm14X3ZtY3NfcmVsb2FkKHN0cnVjdCB2Y3B1ICp2KQp7CiAgICAvKgog ICAgICogQXMgd2UncmUgcnVubmluZyB3aXRoIGludGVycnVwdHMgZGlzYWJsZWQsIHdlIGNhbid0 IGFjcXVpcmUKICAgICAqIHYtPmFyY2guaHZtX3ZteC52bWNzX2xvY2sgaGVyZS4gSG93ZXZlciwg d2l0aCBpbnRlcnJ1cHRzIGRpc2FibGVkCiAgICAgKiB0aGUgVk1DUyBjYW4ndCBiZSB0YWtlbiBh d2F5IGZyb20gdXMgYW55bW9yZSBpZiB3ZSBzdGlsbCBvd24gaXQuCiAgICAgKi8KICAgIEFTU0VS VCghbG9jYWxfaXJxX2lzX2VuYWJsZWQoKSk7CiAgICBpZiAoIHYtPmFyY2guaHZtX3ZteC52bWNz X3BhID09IHRoaXNfY3B1KGN1cnJlbnRfdm1jcykgKQogICAgICAgIHJldHVybjsKICAgIEFTU0VS VCghdGhpc19jcHUoY3VycmVudF92bWNzKSk7CgogICAgaWYgKCB2LT5hcmNoLmh2bV92bXguYWN0 aXZlX2NwdSAhPSBzbXBfcHJvY2Vzc29yX2lkKCkgKQogICAgewogICAgICAgIC8qCiAgICAgICAg ICogV2FpdCBmb3IgdGhlIHJlbW90ZSBzaWRlIHRvIGJlIGRvbmUgd2l0aCB0aGUgVk1DUyBiZWZv cmUKICAgICAgICAgKiBsb2FkaW5nIGl0IGhlcmUuCiAgICAgICAgICovCiAgICAgICAgd2hpbGUg KCB2LT5hcmNoLmh2bV92bXguYWN0aXZlX2NwdSAhPSAtMSApCiAgICAgICAgICAgIGNwdV9yZWxh eCgpOwogICAgfQogICAgdm14X2xvYWRfdm1jcyh2KTsKfQoKQXMgdG8gdGhlIHNwaW5uaW5nIG5v dCBiZWluZyBuZWVkZWQgaW4gdGhlIGZpcnN0IHBsYWNlIC0gdGhlIHJlbW90ZQpDUFUgdXNpbmcg dGhlIFZNQ1Mgd29uJ3QgdW5wYXVzZSB1cyBiZWZvcmUgYmVpbmcgZG9uZSB3aXRoIHRoZQpWTUNT IGFueXdheS4gVGhvdWdodHM/CgpKYW4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhl bi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=