From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ceC4C-0007uc-2Y for qemu-devel@nongnu.org; Wed, 15 Feb 2017 21:45:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ceC49-0003Ix-1c for qemu-devel@nongnu.org; Wed, 15 Feb 2017 21:45:08 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:4099) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1ceC48-0003ID-9m for qemu-devel@nongnu.org; Wed, 15 Feb 2017 21:45:04 -0500 References: <1487147657-166092-1-git-send-email-zhang.zhanghailiang@huawei.com> <1487147657-166092-4-git-send-email-zhang.zhanghailiang@huawei.com> <09a2bc10-d8dd-a2c0-f545-6b08a871d91a@redhat.com> From: Hailiang Zhang Message-ID: <58A511D2.6020102@huawei.com> Date: Thu, 16 Feb 2017 10:43:30 +0800 MIME-Version: 1.0 In-Reply-To: <09a2bc10-d8dd-a2c0-f545-6b08a871d91a@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 3/5] colo-compare: release all unhandled packets in finalize function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang , zhangchen.fnst@cn.fujitsu.com, lizhijian@cn.fujitsu.com Cc: xuquan8@huawei.com, qemu-devel@nongnu.org, pss.wulizhen@huawei.com On 2017/2/16 10:34, Jason Wang wrote: > > > On 2017年02月15日 16:34, zhanghailiang wrote: >> We should release all unhandled packets before finalize colo compare. >> Besides, we need to free connection_track_table, or there will be >> a memory leak bug. >> >> Signed-off-by: zhanghailiang >> --- >> net/colo-compare.c | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/net/colo-compare.c b/net/colo-compare.c >> index a16e2d5..809bad3 100644 >> --- a/net/colo-compare.c >> +++ b/net/colo-compare.c >> @@ -676,6 +676,23 @@ static void colo_compare_complete(UserCreatable *uc, Error **errp) >> return; >> } >> >> +static void colo_release_packets(void *opaque, void *user_data) >> +{ >> + CompareState *s = user_data; >> + Connection *conn = opaque; >> + Packet *pkt = NULL; >> + >> + while (!g_queue_is_empty(&conn->primary_list)) { >> + pkt = g_queue_pop_head(&conn->primary_list); >> + compare_chr_send(&s->chr_out, pkt->data, pkt->size); > > Any reason to send packets here? > Yes, considering the usage case which we shut COLO for the VM to make it as a normal VM without FT. We need to remove all the filter objects. In this case, IMHO, it is necessary to release the unhandled packets. Thanks. > Thanks > >> + packet_destroy(pkt, NULL); >> + } >> + while (!g_queue_is_empty(&conn->secondary_list)) { >> + pkt = g_queue_pop_head(&conn->secondary_list); >> + packet_destroy(pkt, NULL); >> + } >> +} >> + >> static void colo_compare_class_init(ObjectClass *oc, void *data) >> { >> UserCreatableClass *ucc = USER_CREATABLE_CLASS(oc); >> @@ -707,9 +724,12 @@ static void colo_compare_finalize(Object *obj) >> g_main_loop_quit(s->compare_loop); >> qemu_thread_join(&s->thread); >> >> + /* Release all unhandled packets after compare thead exited */ >> + g_queue_foreach(&s->conn_list, colo_release_packets, s); >> >> g_queue_free(&s->conn_list); >> >> + g_hash_table_destroy(s->connection_track_table); >> g_free(s->pri_indev); >> g_free(s->sec_indev); >> g_free(s->outdev); > > > . >