All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>,
	mathias.nyman@intel.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	anirudh@xilinx.com, punnaia@xilinx.com,
	Anurag Kumar Vulisha <anuragku@xilinx.com>
Subject: Re: [RFC PATCH] xhci: Use Cached ring during endpoint ring allocation
Date: Thu, 23 Feb 2017 18:15:01 +0200	[thread overview]
Message-ID: <58AF0A85.3080503@linux.intel.com> (raw)
In-Reply-To: <1487775954-16258-1-git-send-email-anuragku@xilinx.com>

On 22.02.2017 17:05, Anurag Kumar Vulisha wrote:
> Currently during endpoint initialization, a new endpoint ring is alloacte
> using xhci_ring_alloc(), if this function fails to allocate ring a cached
> ring(if available) is assigned to endpoint ring.
> This patch modifies the code that during endpoint initialization, if cached
> ring is available it is assigned to the endpoint ring. If cached rings are
> not available then xhci_ring_alloc() is called to allocate a new ring.
> Doing so will avoid unncessary memory allocations if cached ring is already
> available for use. This also fixes endpoint "Ring expansion failed" error
> which occurs due to insufficient memory during ring expansion.
>
> Signed-off-by: Anurag Kumar Vulisha <anuragku@xilinx.com>

Thanks for bringing this to my attention.
Your approach certainly makes more sense than the current way.

I need to check history why this type of ring cache was created in the first place.
It's possible that the whole ring cache is not really useful anymore

-Mathias  

      reply	other threads:[~2017-02-23 16:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-22 15:05 [RFC PATCH] xhci: Use Cached ring during endpoint ring allocation Anurag Kumar Vulisha
2017-02-23 16:15 ` Mathias Nyman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58AF0A85.3080503@linux.intel.com \
    --to=mathias.nyman@linux.intel.com \
    --cc=anirudh@xilinx.com \
    --cc=anurag.kumar.vulisha@xilinx.com \
    --cc=anuragku@xilinx.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=punnaia@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.