From: "Jan Beulich" <JBeulich@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/5] x86/vioapic: move domain out of hvm_vioapic struct
Date: Mon, 06 Mar 2017 09:43:43 -0700 [thread overview]
Message-ID: <58BD9FCF0200007800140A2B@prv-mh.provo.novell.com> (raw)
In-Reply-To: <20170223115217.32764-2-roger.pau@citrix.com>
>>> On 23.02.17 at 12:52, <roger.pau@citrix.com> wrote:
> And then remove hvm_vioapic (since it just contains a hvm_hw_ioapic struct
> now). This is a preparatory change for introducing support for multiple vIO
> APICs per domain.
Having gone through the rest of this series, I think the replacing of
vioapic pointers by domain ones goes too far here. Especially the
low level functions really ought to be dealing with individual IO-APICs
instead of their entire set. Hence where a domain pointer is needed,
I think it should be added without removing the vioapic one.
In the end - what's the fundamental need you try to address with
the patch here? I.e. with multiple IO-APICs, what's wrong with still
having a "back pointer" to the domain in each of the structures?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-06 16:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 11:52 [PATCH 0/5] x86/vioapic: introduce support for multiple vIO APICs Roger Pau Monne
2017-02-23 11:52 ` [PATCH 1/5] x86/vioapic: move domain out of hvm_vioapic struct Roger Pau Monne
2017-03-03 11:31 ` Jan Beulich
2017-03-06 16:43 ` Jan Beulich [this message]
2017-03-06 16:49 ` Roger Pau Monne
2017-02-23 11:52 ` [PATCH 2/5] x86/vioapic: allow the vIO APIC to have a variable number of pins Roger Pau Monne
2017-03-03 11:56 ` Jan Beulich
2017-03-03 12:53 ` Roger Pau Monne
2017-03-03 13:02 ` Jan Beulich
2017-03-03 15:30 ` Roger Pau Monne
2017-03-03 15:58 ` Jan Beulich
2017-02-23 11:52 ` [PATCH 3/5] x86/vioapic: introduce support for multiple vIO APICS Roger Pau Monne
2017-03-03 17:06 ` Jan Beulich
2017-03-20 18:27 ` Roger Pau Monne
2017-03-21 7:56 ` Jan Beulich
2017-03-21 10:52 ` Roger Pau Monne
2017-03-21 13:45 ` Jan Beulich
2017-03-21 13:59 ` Roger Pau Monne
2017-03-21 14:07 ` Jan Beulich
2017-02-23 11:52 ` [PATCH 4/5] x86/ioapic: add prototype for apic_gsi_base to io_apic.h Roger Pau Monne
2017-03-06 13:25 ` Jan Beulich
2017-02-23 11:52 ` [PATCH 5/5] x86/vioapic: allow PVHv2 Dom0 to have more than one IO APIC Roger Pau Monne
2017-03-06 16:00 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58BD9FCF0200007800140A2B@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.