From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kever Yang <kever.yang@rock-chips.com>
Date: Tue, 07 Mar 2017 14:56:26 +0800
Subject: [U-Boot] rockchip breakage with "spl: Remove overwrite of
 relocated malloc limit"
In-Reply-To: <5416401.pcIAmeSpSx@diego>
References: <5416401.pcIAmeSpSx@diego>
Message-ID: <58BE599A.3040409@rock-chips.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
To: u-boot@lists.denx.de

Hi Heiko,

That patch break all the Rockchip SoCs SPL which using spl_init().

Eddie send one patch for rk3288 by add a spl_early_init(), which is
under review, I also look forward for better solution.

Thanks,
- Kever
On 03/07/2017 08:42 AM, Heiko St=C3=BCbner wrote:
> Hi,
>
> I just realized patch b3d2861eb20a ("spl: Remove overwrite of relocated m=
alloc
> limit") introduces breakage in my rk3188 uboot code (and should most like=
ly
> also affect the very similar other rockchip spl boards).
>
> The boards call spl_init in their board_init_f functions because they nee=
d the
> spl infrastructure to find and bringup the devicetree stuff and things li=
ke
> pinctrl and ram.
>
> With the recent change mentioned above, spl_init fails with
> 	spl_init() failed: -12
> because
> 	dm_init_and_scan() returned error -12
> because
> 	dm_init() failed: -12
> ...
> because
> 	Missing uclass for driver root_driver
> because
> 	uclass_add calls calloc, which fails with the -ENOMEM (-12)
>
> I still lack uboot experience to see the correct way forward. Reverting t=
hat
> patch of course makes my board start uboot again [and most likely the oth=
er
> Rockchip SPLs as well], but there is possibly some better solution
> [Or there is simply something very wrong with my rk3188 stuff :-) ].
>
>
> Heiko
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot