* [PATCH 1/1] usb: host: xhci-dbg: HCIVERSION should be a binary number
@ 2017-03-07 3:04 Peter Chen
2017-03-07 14:20 ` Mathias Nyman
0 siblings, 1 reply; 2+ messages in thread
From: Peter Chen @ 2017-03-07 3:04 UTC (permalink / raw)
To: mathias.nyman; +Cc: linux-usb, gregkh, Peter Chen, Lu Baolu, stable
According to xHCI spec, HCIVERSION containing a BCD encoding
of the xHCI specification revision number, 0100h corresponds
to xHCI version 1.0. Change "100" as "0x100".
Cc: Lu Baolu <baolu.lu@linux.intel.com>
Cc: stable <stable@vger.kernel.org>
Fixes: 04abb6de2825 ("xhci: Read and parse new xhci
1.1 capability register")
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
drivers/usb/host/xhci-dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-dbg.c b/drivers/usb/host/xhci-dbg.c
index 363d125..2b4a00f 100644
--- a/drivers/usb/host/xhci-dbg.c
+++ b/drivers/usb/host/xhci-dbg.c
@@ -109,7 +109,7 @@ static void xhci_print_cap_regs(struct xhci_hcd *xhci)
xhci_dbg(xhci, "RTSOFF 0x%x:\n", temp & RTSOFF_MASK);
/* xhci 1.1 controllers have the HCCPARAMS2 register */
- if (hci_version > 100) {
+ if (hci_version > 0x100) {
temp = readl(&xhci->cap_regs->hcc_params2);
xhci_dbg(xhci, "HCC PARAMS2 0x%x:\n", (unsigned int) temp);
xhci_dbg(xhci, " HC %s Force save context capability",
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] usb: host: xhci-dbg: HCIVERSION should be a binary number
2017-03-07 3:04 [PATCH 1/1] usb: host: xhci-dbg: HCIVERSION should be a binary number Peter Chen
@ 2017-03-07 14:20 ` Mathias Nyman
0 siblings, 0 replies; 2+ messages in thread
From: Mathias Nyman @ 2017-03-07 14:20 UTC (permalink / raw)
To: Peter Chen; +Cc: linux-usb, gregkh, Lu Baolu, stable
On 07.03.2017 05:04, Peter Chen wrote:
> According to xHCI spec, HCIVERSION containing a BCD encoding
> of the xHCI specification revision number, 0100h corresponds
> to xHCI version 1.0. Change "100" as "0x100".
>
> Cc: Lu Baolu <baolu.lu@linux.intel.com>
> Cc: stable <stable@vger.kernel.org>
> Fixes: 04abb6de2825 ("xhci: Read and parse new xhci
> 1.1 capability register")
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> drivers/usb/host/xhci-dbg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-dbg.c b/drivers/usb/host/xhci-dbg.c
> index 363d125..2b4a00f 100644
> --- a/drivers/usb/host/xhci-dbg.c
> +++ b/drivers/usb/host/xhci-dbg.c
> @@ -109,7 +109,7 @@ static void xhci_print_cap_regs(struct xhci_hcd *xhci)
> xhci_dbg(xhci, "RTSOFF 0x%x:\n", temp & RTSOFF_MASK);
>
> /* xhci 1.1 controllers have the HCCPARAMS2 register */
> - if (hci_version > 100) {
> + if (hci_version > 0x100) {
> temp = readl(&xhci->cap_regs->hcc_params2);
> xhci_dbg(xhci, "HCC PARAMS2 0x%x:\n", (unsigned int) temp);
> xhci_dbg(xhci, " HC %s Force save context capability",
>
Thanks, queuing this
-Mathias
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-07 20:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-07 3:04 [PATCH 1/1] usb: host: xhci-dbg: HCIVERSION should be a binary number Peter Chen
2017-03-07 14:20 ` Mathias Nyman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.