From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-10-git-send-email-wangyijing@huawei.com> <540993B3.1000701@cogentembedded.com> Mime-Version: 1.0 (1.0) In-Reply-To: <540993B3.1000701@cogentembedded.com> Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 Message-ID: <58C2E84C-7080-4FDA-8684-5D0B2DAD7C20@gmail.com> From: wangyijing Subject: Re: [PATCH v1 09/21] Irq_remapping/MSI: Use MSI chip framework to configure MSI/MSI-X irq Date: Fri, 5 Sep 2014 19:30:01 +0800 Sender: linux-arch-owner@vger.kernel.org Message-ID: <20140905113001.Tc_GzNVyAzEjvsL38Rmq6EOPmx3xjWxT4E36fM7EqxI@z> List-Archive: List-Post: To: Sergei Shtylyov Cc: Yijing Wang , Bjorn Helgaas , Xinwei Hu , Wuyun , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Russell King , "linux-arch@vger.kernel.org" , "arnab.basu@freescale.com" , "Bharat.Bhushan@freescale.com" , "x86@kernel.org" , Arnd Bergmann , Thomas Gleixner , Konrad Rzeszutek Wilk , "xen-devel@lists.xenproject.org" , Joerg Roedel , "iommu@lists.linux-foundation.org" , "linux-mips@linux-mips.org" , Benjamin Herrenschmidt , "linuxppc-dev@lists.ozlabs.org" , "linux-s390@vger.kernel.org" , Sebastian Ott , Tony Luck , "linux-ia64@vger.kernel.org" , "David S. Miller" , "sparclinux@vger.kernel.org" , Chris Metcalf , Ralf Baechle List-ID: Cj4g1NogMjAxNMTqOdTCNcjVo6wxODo0MqOsU2VyZ2VpIFNodHlseW92IDxzZXJnZWkuc2h0eWx5 b3ZAY29nZW50ZW1iZWRkZWQuY29tPiDQtLXAo7oKPiAKPiBIZWxsby4KPiAKPj4gT24gOS81LzIw MTQgMjowOSBQTSwgWWlqaW5nIFdhbmcgd3JvdGU6Cj4+IAo+PiBVc2UgTVNJIGNoaXAgZnJhbWV3 b3JrIGluc3RlYWQgb2YgYXJjaCBNU0kgZnVuY3Rpb25zIHRvIGNvbmZpZ3VyZQo+PiBNU0kvTVNJ LVggaXJxLiBTbyB3ZSBjYW4gbWFuYWdlIE1TSS9NU0ktWCBpcnEgaW4gYSB1bmlmaWVkIGZyYW1l d29yay4KPiAKPj4gU2lnbmVkLW9mZi1ieTogWWlqaW5nIFdhbmcgPHdhbmd5aWppbmdAaHVhd2Vp LmNvbT4KPj4gLS0tCj4+ICBkcml2ZXJzL2lvbW11L2lycV9yZW1hcHBpbmcuYyB8ICAgIDggKysr KysrKy0KPj4gIDEgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygt KQo+IAo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pb21tdS9pcnFfcmVtYXBwaW5nLmMgYi9kcml2 ZXJzL2lvbW11L2lycV9yZW1hcHBpbmcuYwo+PiBpbmRleCAzM2M0Mzk1Li5lNzUwMjZlIDEwMDY0 NAo+PiAtLS0gYS9kcml2ZXJzL2lvbW11L2lycV9yZW1hcHBpbmcuYwo+PiArKysgYi9kcml2ZXJz L2lvbW11L2lycV9yZW1hcHBpbmcuYwo+IFsuLi5dCj4+IEBAIC0xNjUsOSArMTcwLDEwIEBAIHN0 YXRpYyB2b2lkIF9faW5pdCBpcnFfcmVtYXBwaW5nX21vZGlmeV94ODZfb3BzKHZvaWQpCj4+ICAg ICAgeDg2X2lvX2FwaWNfb3BzLnNldF9hZmZpbml0eSAgICA9IHNldF9yZW1hcHBlZF9pcnFfYWZm aW5pdHk7Cj4+ICAgICAgeDg2X2lvX2FwaWNfb3BzLnNldHVwX2VudHJ5ICAgID0gc2V0dXBfaW9h cGljX3JlbWFwcGVkX2VudHJ5Owo+PiAgICAgIHg4Nl9pb19hcGljX29wcy5lb2lfaW9hcGljX3Bp biAgICA9IGVvaV9pb2FwaWNfcGluX3JlbWFwcGVkOwo+PiAtICAgIHg4Nl9tc2kuc2V0dXBfbXNp X2lycXMgICAgICAgID0gaXJxX3JlbWFwcGluZ19zZXR1cF9tc2lfaXJxczsKPj4gKyAgICB4ODZf bXNpLnNldHVwX21zaV9pcnFzICAgICAgICAgID0gaXJxX3JlbWFwcGluZ19zZXR1cF9tc2lfaXJx czsKPiAKPiAgIEFGQUlDUywgdGhpcyBjaGFuZ2Ugb25seSBjb252ZXJ0cyB0YWJzIHRvIHNwYWNl cywgc28gbm90IG5lZWRlZCBhdCBhbGwuCgpXaWxsIHVwZGF0ZSwgIHRoYW5rcy4KCj4gCj4+ICAg ICAgeDg2X21zaS5zZXR1cF9ocGV0X21zaSAgICAgICAgPSBzZXR1cF9ocGV0X21zaV9yZW1hcHBl ZDsKPj4gICAgICB4ODZfbXNpLmNvbXBvc2VfbXNpX21zZyAgICAgICAgPSBjb21wb3NlX3JlbWFw cGVkX21zaV9tc2c7Cj4+ICsgICAgeDg2X21zaV9jaGlwID0gJnJlbWFwX21zaV9jaGlwOwo+IAo+ ICAgUGxlYXNlIGFsaWduID0gd2l0aCB0aGUgcmVzdCBvZiBhc3NpZ25tZW50cy4KCk9rLgoKVGhh bmtzIQpZaWppbmcuCgo+IAo+IFdCUiwgU2VyZ2VpCj4gCj4gLS0KPiBUbyB1bnN1YnNjcmliZSBm cm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtcGNpIiBpbgo+ IHRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCj4gTW9y ZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5m by5odG1sCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangyijing Subject: Re: [PATCH v1 09/21] Irq_remapping/MSI: Use MSI chip framework to configure MSI/MSI-X irq Date: Fri, 5 Sep 2014 19:30:01 +0800 Message-ID: <58C2E84C-7080-4FDA-8684-5D0B2DAD7C20@gmail.com> References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-10-git-send-email-wangyijing@huawei.com> <540993B3.1000701@cogentembedded.com> Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=gb2312 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <540993B3.1000701@cogentembedded.com> Sender: linux-ia64-owner@vger.kernel.org To: Sergei Shtylyov Cc: Yijing Wang , Bjorn Helgaas , Xinwei Hu , Wuyun , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Russell King , "linux-arch@vger.kernel.org" , "arnab.basu@freescale.com" , "Bharat.Bhushan@freescale.com" , "x86@kernel.org" , Arnd Bergmann , Thomas Gleixner , Konrad Rzeszutek Wilk , "xen-devel@lists.xenproject.org" , Joerg Roedel , "iommu@lists.linux-foundation.org" , "linux-mips@linux-mips.org" , Benjamin List-Id: linux-arch.vger.kernel.org > =D4=DA 2014=C4=EA9=D4=C25=C8=D5=A3=AC18:42=A3=ACSergei Shtylyov =D0=B4=B5=C0=A3=BA >=20 > Hello. >=20 >> On 9/5/2014 2:09 PM, Yijing Wang wrote: >>=20 >> Use MSI chip framework instead of arch MSI functions to configure >> MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework= =2E >=20 >> Signed-off-by: Yijing Wang >> --- >> drivers/iommu/irq_remapping.c | 8 +++++++- >> 1 files changed, 7 insertions(+), 1 deletions(-) >=20 >> diff --git a/drivers/iommu/irq_remapping.c b/drivers/iommu/irq_remap= ping.c >> index 33c4395..e75026e 100644 >> --- a/drivers/iommu/irq_remapping.c >> +++ b/drivers/iommu/irq_remapping.c > [...] >> @@ -165,9 +170,10 @@ static void __init irq_remapping_modify_x86_ops= (void) >> x86_io_apic_ops.set_affinity =3D set_remapped_irq_affinity; >> x86_io_apic_ops.setup_entry =3D setup_ioapic_remapped_entry; >> x86_io_apic_ops.eoi_ioapic_pin =3D eoi_ioapic_pin_remapped; >> - x86_msi.setup_msi_irqs =3D irq_remapping_setup_msi_irqs; >> + x86_msi.setup_msi_irqs =3D irq_remapping_setup_msi_irq= s; >=20 > AFAICS, this change only converts tabs to spaces, so not needed at = all. Will update, thanks. >=20 >> x86_msi.setup_hpet_msi =3D setup_hpet_msi_remapped; >> x86_msi.compose_msi_msg =3D compose_remapped_msi_msg; >> + x86_msi_chip =3D &remap_msi_chip; >=20 > Please align =3D with the rest of assignments. Ok. Thanks! Yijing. >=20 > WBR, Sergei >=20 > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" = in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ia64" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 05 Sep 2014 13:30:13 +0200 (CEST) Received: from mail-pa0-f48.google.com ([209.85.220.48]:59608 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27007043AbaIELaMLfOsJ convert rfc822-to-8bit (ORCPT ); Fri, 5 Sep 2014 13:30:12 +0200 Received: by mail-pa0-f48.google.com with SMTP id hz1so969877pad.7 for ; Fri, 05 Sep 2014 04:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:mime-version:in-reply-to:content-type :content-transfer-encoding:message-id:cc:from:subject:date:to; bh=TufQeAlfqp5e3AwvJ4CWSF5ND+pG8+q9vbcvEXWTRYc=; b=laHpRN+yUsVBxHypfwh5Iah8z5IuFNe7r+fInsIdsdqjNPOCXBMzi9x6FSvRlBhw0b errs+wT3yZlCzx+OWEDHfSeodooSpq/dU8sMjPhSvGHGvqZN1nnbCBapcXv7aToseKn2 aafGgg74NxYwzOJGk0mOD89eYIGkRyA534fz57kKYlQ7c00TdF9P9b84vJt+oebK+nU6 xFOcBbrhK+Afb1cqEz9/e+PCphXzuC9FidYvCrj1/tao4cMETsTfLFs2gfnHW7vr4LvQ tfY+RZQRmQD8OBJsUrdKmkiexaw8HG/BY6VPShXYpQETD8+zE/U29j/piTnoKcyp18ro P5kg== X-Received: by 10.66.141.142 with SMTP id ro14mr20474420pab.104.1409916602625; Fri, 05 Sep 2014 04:30:02 -0700 (PDT) Received: from [192.168.1.102] ([111.140.71.79]) by mx.google.com with ESMTPSA id yx1sm1651315pab.5.2014.09.05.04.30.01 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 05 Sep 2014 04:30:01 -0700 (PDT) References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-10-git-send-email-wangyijing@huawei.com> <540993B3.1000701@cogentembedded.com> Mime-Version: 1.0 (1.0) In-Reply-To: <540993B3.1000701@cogentembedded.com> Content-Type: text/plain; charset=gb2312 Content-Transfer-Encoding: 8BIT Message-Id: <58C2E84C-7080-4FDA-8684-5D0B2DAD7C20@gmail.com> Cc: Yijing Wang , Bjorn Helgaas , Xinwei Hu , Wuyun , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Russell King , "linux-arch@vger.kernel.org" , "arnab.basu@freescale.com" , "Bharat.Bhushan@freescale.com" , "x86@kernel.org" , Arnd Bergmann , Thomas Gleixner , Konrad Rzeszutek Wilk , "xen-devel@lists.xenproject.org" , Joerg Roedel , "iommu@lists.linux-foundation.org" , "linux-mips@linux-mips.org" , Benjamin Herrenschmidt , "linuxppc-dev@lists.ozlabs.org" , "linux-s390@vger.kernel.org" , Sebastian Ott , Tony Luck , "linux-ia64@vger.kernel.org" , "David S. Miller" , "sparclinux@vger.kernel.org" , Chris Metcalf , Ralf Baechle X-Mailer: iPad Mail (11D201) From: wangyijing Subject: Re: [PATCH v1 09/21] Irq_remapping/MSI: Use MSI chip framework to configure MSI/MSI-X irq Date: Fri, 5 Sep 2014 19:30:01 +0800 To: Sergei Shtylyov Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 42425 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: wangyijing0307@gmail.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips > 在 2014年9月5日，18:42，Sergei Shtylyov 写道： > > Hello. > >> On 9/5/2014 2:09 PM, Yijing Wang wrote: >> >> Use MSI chip framework instead of arch MSI functions to configure >> MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. > >> Signed-off-by: Yijing Wang >> --- >> drivers/iommu/irq_remapping.c | 8 +++++++- >> 1 files changed, 7 insertions(+), 1 deletions(-) > >> diff --git a/drivers/iommu/irq_remapping.c b/drivers/iommu/irq_remapping.c >> index 33c4395..e75026e 100644 >> --- a/drivers/iommu/irq_remapping.c >> +++ b/drivers/iommu/irq_remapping.c > [...] >> @@ -165,9 +170,10 @@ static void __init irq_remapping_modify_x86_ops(void) >> x86_io_apic_ops.set_affinity = set_remapped_irq_affinity; >> x86_io_apic_ops.setup_entry = setup_ioapic_remapped_entry; >> x86_io_apic_ops.eoi_ioapic_pin = eoi_ioapic_pin_remapped; >> - x86_msi.setup_msi_irqs = irq_remapping_setup_msi_irqs; >> + x86_msi.setup_msi_irqs = irq_remapping_setup_msi_irqs; > > AFAICS, this change only converts tabs to spaces, so not needed at all. Will update, thanks. > >> x86_msi.setup_hpet_msi = setup_hpet_msi_remapped; >> x86_msi.compose_msi_msg = compose_remapped_msi_msg; >> + x86_msi_chip = &remap_msi_chip; > > Please align = with the rest of assignments. Ok. Thanks! Yijing. > > WBR, Sergei > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangyijing Date: Fri, 05 Sep 2014 11:30:01 +0000 Subject: Re: [PATCH v1 09/21] Irq_remapping/MSI: Use MSI chip framework to configure MSI/MSI-X irq Message-Id: <58C2E84C-7080-4FDA-8684-5D0B2DAD7C20@gmail.com> List-Id: References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-10-git-send-email-wangyijing@huawei.com> <540993B3.1000701@cogentembedded.com> In-Reply-To: <540993B3.1000701@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 To: Sergei Shtylyov Cc: Yijing Wang , Bjorn Helgaas , Xinwei Hu , Wuyun , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Russell King , "linux-arch@vger.kernel.org" , "arnab.basu@freescale.com" , "Bharat.Bhushan@freescale.com" , "x86@kernel.org" , Arnd Bergmann , Thomas Gleixner , Konrad Rzeszutek Wilk , "xen-devel@lists.xenproject.org" , Joerg Roedel , "iommu@lists.linux-foundation.org" , "linux-mips@linux-mips.org" , Benjamin Cj4g1NogMjAxNMTqOdTCNcjVo6wxODo0MqOsU2VyZ2VpIFNodHlseW92IDxzZXJnZWkuc2h0eWx5 b3ZAY29nZW50ZW1iZWRkZWQuY29tPiDQtLXAo7oKPiAKPiBIZWxsby4KPiAKPj4gT24gOS81LzIw MTQgMjowOSBQTSwgWWlqaW5nIFdhbmcgd3JvdGU6Cj4+IAo+PiBVc2UgTVNJIGNoaXAgZnJhbWV3 b3JrIGluc3RlYWQgb2YgYXJjaCBNU0kgZnVuY3Rpb25zIHRvIGNvbmZpZ3VyZQo+PiBNU0kvTVNJ LVggaXJxLiBTbyB3ZSBjYW4gbWFuYWdlIE1TSS9NU0ktWCBpcnEgaW4gYSB1bmlmaWVkIGZyYW1l d29yay4KPiAKPj4gU2lnbmVkLW9mZi1ieTogWWlqaW5nIFdhbmcgPHdhbmd5aWppbmdAaHVhd2Vp LmNvbT4KPj4gLS0tCj4+ICBkcml2ZXJzL2lvbW11L2lycV9yZW1hcHBpbmcuYyB8ICAgIDggKysr KysrKy0KPj4gIDEgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygt KQo+IAo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pb21tdS9pcnFfcmVtYXBwaW5nLmMgYi9kcml2 ZXJzL2lvbW11L2lycV9yZW1hcHBpbmcuYwo+PiBpbmRleCAzM2M0Mzk1Li5lNzUwMjZlIDEwMDY0 NAo+PiAtLS0gYS9kcml2ZXJzL2lvbW11L2lycV9yZW1hcHBpbmcuYwo+PiArKysgYi9kcml2ZXJz L2lvbW11L2lycV9yZW1hcHBpbmcuYwo+IFsuLi5dCj4+IEBAIC0xNjUsOSArMTcwLDEwIEBAIHN0 YXRpYyB2b2lkIF9faW5pdCBpcnFfcmVtYXBwaW5nX21vZGlmeV94ODZfb3BzKHZvaWQpCj4+ICAg ICAgeDg2X2lvX2FwaWNfb3BzLnNldF9hZmZpbml0eSAgICA9IHNldF9yZW1hcHBlZF9pcnFfYWZm aW5pdHk7Cj4+ICAgICAgeDg2X2lvX2FwaWNfb3BzLnNldHVwX2VudHJ5ICAgID0gc2V0dXBfaW9h cGljX3JlbWFwcGVkX2VudHJ5Owo+PiAgICAgIHg4Nl9pb19hcGljX29wcy5lb2lfaW9hcGljX3Bp biAgICA9IGVvaV9pb2FwaWNfcGluX3JlbWFwcGVkOwo+PiAtICAgIHg4Nl9tc2kuc2V0dXBfbXNp X2lycXMgICAgICAgID0gaXJxX3JlbWFwcGluZ19zZXR1cF9tc2lfaXJxczsKPj4gKyAgICB4ODZf bXNpLnNldHVwX21zaV9pcnFzICAgICAgICAgID0gaXJxX3JlbWFwcGluZ19zZXR1cF9tc2lfaXJx czsKPiAKPiAgIEFGQUlDUywgdGhpcyBjaGFuZ2Ugb25seSBjb252ZXJ0cyB0YWJzIHRvIHNwYWNl cywgc28gbm90IG5lZWRlZCBhdCBhbGwuCgpXaWxsIHVwZGF0ZSwgIHRoYW5rcy4KCj4gCj4+ICAg ICAgeDg2X21zaS5zZXR1cF9ocGV0X21zaSAgICAgICAgPSBzZXR1cF9ocGV0X21zaV9yZW1hcHBl ZDsKPj4gICAgICB4ODZfbXNpLmNvbXBvc2VfbXNpX21zZyAgICAgICAgPSBjb21wb3NlX3JlbWFw cGVkX21zaV9tc2c7Cj4+ICsgICAgeDg2X21zaV9jaGlwID0gJnJlbWFwX21zaV9jaGlwOwo+IAo+ ICAgUGxlYXNlIGFsaWduID0gd2l0aCB0aGUgcmVzdCBvZiBhc3NpZ25tZW50cy4KCk9rLgoKVGhh bmtzIQpZaWppbmcuCgo+IAo+IFdCUiwgU2VyZ2VpCj4gCj4gLS0KPiBUbyB1bnN1YnNjcmliZSBm cm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtcGNpIiBpbgo+ IHRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCj4gTW9y ZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5m by5odG1sCi0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1 bnN1YnNjcmliZSBzcGFyY2xpbnV4IiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jk b21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5r ZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-x230.google.com (mail-pd0-x230.google.com [IPv6:2607:f8b0:400e:c02::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4D5201A012C for ; Fri, 5 Sep 2014 21:30:07 +1000 (EST) Received: by mail-pd0-f176.google.com with SMTP id w10so6221360pde.21 for ; Fri, 05 Sep 2014 04:30:02 -0700 (PDT) References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-10-git-send-email-wangyijing@huawei.com> <540993B3.1000701@cogentembedded.com> Mime-Version: 1.0 (1.0) In-Reply-To: <540993B3.1000701@cogentembedded.com> Content-Type: text/plain; charset=gb2312 Message-Id: <58C2E84C-7080-4FDA-8684-5D0B2DAD7C20@gmail.com> From: wangyijing Subject: Re: [PATCH v1 09/21] Irq_remapping/MSI: Use MSI chip framework to configure MSI/MSI-X irq Date: Fri, 5 Sep 2014 19:30:01 +0800 To: Sergei Shtylyov Cc: "linux-mips@linux-mips.org" , "linux-ia64@vger.kernel.org" , "linux-pci@vger.kernel.org" , "Bharat.Bhushan@freescale.com" , "sparclinux@vger.kernel.org" , Yijing Wang , "linux-arch@vger.kernel.org" , "linux-s390@vger.kernel.org" , Russell King , Joerg Roedel , "x86@kernel.org" , Sebastian Ott , "xen-devel@lists.xenproject.org" , "arnab.basu@freescale.com" , Arnd Bergmann , Konrad Rzeszutek Wilk , Chris Metcalf , Bjorn Helgaas , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , Xinwei Hu , Tony Luck , Ralf Baechle , "iommu@lists.linux-foundation.org" , Wuyun , "linuxppc-dev@lists.ozlabs.org" , "David S. Miller" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > =D4=DA 2014=C4=EA9=D4=C25=C8=D5=A3=AC18:42=A3=ACSergei Shtylyov =D0=B4=B5=C0=A3=BA >=20 > Hello. >=20 >> On 9/5/2014 2:09 PM, Yijing Wang wrote: >>=20 >> Use MSI chip framework instead of arch MSI functions to configure >> MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. >=20 >> Signed-off-by: Yijing Wang >> --- >> drivers/iommu/irq_remapping.c | 8 +++++++- >> 1 files changed, 7 insertions(+), 1 deletions(-) >=20 >> diff --git a/drivers/iommu/irq_remapping.c b/drivers/iommu/irq_remapping.= c >> index 33c4395..e75026e 100644 >> --- a/drivers/iommu/irq_remapping.c >> +++ b/drivers/iommu/irq_remapping.c > [...] >> @@ -165,9 +170,10 @@ static void __init irq_remapping_modify_x86_ops(void= ) >> x86_io_apic_ops.set_affinity =3D set_remapped_irq_affinity; >> x86_io_apic_ops.setup_entry =3D setup_ioapic_remapped_entry; >> x86_io_apic_ops.eoi_ioapic_pin =3D eoi_ioapic_pin_remapped; >> - x86_msi.setup_msi_irqs =3D irq_remapping_setup_msi_irqs; >> + x86_msi.setup_msi_irqs =3D irq_remapping_setup_msi_irqs; >=20 > AFAICS, this change only converts tabs to spaces, so not needed at all. Will update, thanks. >=20 >> x86_msi.setup_hpet_msi =3D setup_hpet_msi_remapped; >> x86_msi.compose_msi_msg =3D compose_remapped_msi_msg; >> + x86_msi_chip =3D &remap_msi_chip; >=20 > Please align =3D with the rest of assignments. Ok. Thanks! Yijing. >=20 > WBR, Sergei >=20 > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangyijing0307@gmail.com (wangyijing) Date: Fri, 5 Sep 2014 19:30:01 +0800 Subject: [PATCH v1 09/21] Irq_remapping/MSI: Use MSI chip framework to configure MSI/MSI-X irq In-Reply-To: <540993B3.1000701@cogentembedded.com> References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-10-git-send-email-wangyijing@huawei.com> <540993B3.1000701@cogentembedded.com> Message-ID: <58C2E84C-7080-4FDA-8684-5D0B2DAD7C20@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > ? 2014?9?5??18:42?Sergei Shtylyov ??? > > Hello. > >> On 9/5/2014 2:09 PM, Yijing Wang wrote: >> >> Use MSI chip framework instead of arch MSI functions to configure >> MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. > >> Signed-off-by: Yijing Wang >> --- >> drivers/iommu/irq_remapping.c | 8 +++++++- >> 1 files changed, 7 insertions(+), 1 deletions(-) > >> diff --git a/drivers/iommu/irq_remapping.c b/drivers/iommu/irq_remapping.c >> index 33c4395..e75026e 100644 >> --- a/drivers/iommu/irq_remapping.c >> +++ b/drivers/iommu/irq_remapping.c > [...] >> @@ -165,9 +170,10 @@ static void __init irq_remapping_modify_x86_ops(void) >> x86_io_apic_ops.set_affinity = set_remapped_irq_affinity; >> x86_io_apic_ops.setup_entry = setup_ioapic_remapped_entry; >> x86_io_apic_ops.eoi_ioapic_pin = eoi_ioapic_pin_remapped; >> - x86_msi.setup_msi_irqs = irq_remapping_setup_msi_irqs; >> + x86_msi.setup_msi_irqs = irq_remapping_setup_msi_irqs; > > AFAICS, this change only converts tabs to spaces, so not needed at all. Will update, thanks. > >> x86_msi.setup_hpet_msi = setup_hpet_msi_remapped; >> x86_msi.compose_msi_msg = compose_remapped_msi_msg; >> + x86_msi_chip = &remap_msi_chip; > > Please align = with the rest of assignments. Ok. Thanks! Yijing. > > WBR, Sergei > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangyijing Date: Fri, 05 Sep 2014 11:30:01 +0000 Subject: Re: [PATCH v1 09/21] Irq_remapping/MSI: Use MSI chip framework to configure MSI/MSI-X irq Message-Id: <58C2E84C-7080-4FDA-8684-5D0B2DAD7C20@gmail.com> List-Id: References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-10-git-send-email-wangyijing@huawei.com> <540993B3.1000701@cogentembedded.com> In-Reply-To: <540993B3.1000701@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 To: Sergei Shtylyov Cc: Yijing Wang , Bjorn Helgaas , Xinwei Hu , Wuyun , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Russell King , "linux-arch@vger.kernel.org" , "arnab.basu@freescale.com" , "Bharat.Bhushan@freescale.com" , "x86@kernel.org" , Arnd Bergmann , Thomas Gleixner , Konrad Rzeszutek Wilk , "xen-devel@lists.xenproject.org" , Joerg Roedel , "iommu@lists.linux-foundation.org" , "linux-mips@linux-mips.org" , Benjamin Herrenschmidt , "linuxppc-dev@lists.ozlabs.org" , "linux-s390@vger.kernel.org" , Sebastian Ott , Tony Luck , "linux-ia64@vger.kernel.org" , "David S. Miller" , "sparclinux@vger.kernel.org" , Chris Metcalf , Ralf Baechle Cj4g1NogMjAxNMTqOdTCNcjVo6wxODo0MqOsU2VyZ2VpIFNodHlseW92IDxzZXJnZWkuc2h0eWx5 b3ZAY29nZW50ZW1iZWRkZWQuY29tPiDQtLXAo7oKPiAKPiBIZWxsby4KPiAKPj4gT24gOS81LzIw MTQgMjowOSBQTSwgWWlqaW5nIFdhbmcgd3JvdGU6Cj4+IAo+PiBVc2UgTVNJIGNoaXAgZnJhbWV3 b3JrIGluc3RlYWQgb2YgYXJjaCBNU0kgZnVuY3Rpb25zIHRvIGNvbmZpZ3VyZQo+PiBNU0kvTVNJ LVggaXJxLiBTbyB3ZSBjYW4gbWFuYWdlIE1TSS9NU0ktWCBpcnEgaW4gYSB1bmlmaWVkIGZyYW1l d29yay4KPiAKPj4gU2lnbmVkLW9mZi1ieTogWWlqaW5nIFdhbmcgPHdhbmd5aWppbmdAaHVhd2Vp LmNvbT4KPj4gLS0tCj4+ICBkcml2ZXJzL2lvbW11L2lycV9yZW1hcHBpbmcuYyB8ICAgIDggKysr KysrKy0KPj4gIDEgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygt KQo+IAo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pb21tdS9pcnFfcmVtYXBwaW5nLmMgYi9kcml2 ZXJzL2lvbW11L2lycV9yZW1hcHBpbmcuYwo+PiBpbmRleCAzM2M0Mzk1Li5lNzUwMjZlIDEwMDY0 NAo+PiAtLS0gYS9kcml2ZXJzL2lvbW11L2lycV9yZW1hcHBpbmcuYwo+PiArKysgYi9kcml2ZXJz L2lvbW11L2lycV9yZW1hcHBpbmcuYwo+IFsuLi5dCj4+IEBAIC0xNjUsOSArMTcwLDEwIEBAIHN0 YXRpYyB2b2lkIF9faW5pdCBpcnFfcmVtYXBwaW5nX21vZGlmeV94ODZfb3BzKHZvaWQpCj4+ICAg ICAgeDg2X2lvX2FwaWNfb3BzLnNldF9hZmZpbml0eSAgICA9IHNldF9yZW1hcHBlZF9pcnFfYWZm aW5pdHk7Cj4+ICAgICAgeDg2X2lvX2FwaWNfb3BzLnNldHVwX2VudHJ5ICAgID0gc2V0dXBfaW9h cGljX3JlbWFwcGVkX2VudHJ5Owo+PiAgICAgIHg4Nl9pb19hcGljX29wcy5lb2lfaW9hcGljX3Bp biAgICA9IGVvaV9pb2FwaWNfcGluX3JlbWFwcGVkOwo+PiAtICAgIHg4Nl9tc2kuc2V0dXBfbXNp X2lycXMgICAgICAgID0gaXJxX3JlbWFwcGluZ19zZXR1cF9tc2lfaXJxczsKPj4gKyAgICB4ODZf bXNpLnNldHVwX21zaV9pcnFzICAgICAgICAgID0gaXJxX3JlbWFwcGluZ19zZXR1cF9tc2lfaXJx czsKPiAKPiAgIEFGQUlDUywgdGhpcyBjaGFuZ2Ugb25seSBjb252ZXJ0cyB0YWJzIHRvIHNwYWNl cywgc28gbm90IG5lZWRlZCBhdCBhbGwuCgpXaWxsIHVwZGF0ZSwgIHRoYW5rcy4KCj4gCj4+ICAg ICAgeDg2X21zaS5zZXR1cF9ocGV0X21zaSAgICAgICAgPSBzZXR1cF9ocGV0X21zaV9yZW1hcHBl ZDsKPj4gICAgICB4ODZfbXNpLmNvbXBvc2VfbXNpX21zZyAgICAgICAgPSBjb21wb3NlX3JlbWFw cGVkX21zaV9tc2c7Cj4+ICsgICAgeDg2X21zaV9jaGlwID0gJnJlbWFwX21zaV9jaGlwOwo+IAo+ ICAgUGxlYXNlIGFsaWduID0gd2l0aCB0aGUgcmVzdCBvZiBhc3NpZ25tZW50cy4KCk9rLgoKVGhh bmtzIQpZaWppbmcuCgo+IAo+IFdCUiwgU2VyZ2VpCj4gCj4gLS0KPiBUbyB1bnN1YnNjcmliZSBm cm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtcGNpIiBpbgo+ IHRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCj4gTW9y ZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5m by5odG1sCi0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1 bnN1YnNjcmliZSBsaW51eC1pYTY0IiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jk b21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5r ZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWw=