From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiandi An Subject: Re: [PATCH 3/3] tpm/tpm_crb: Enable TPM CRB interface for ARM64 Date: Fri, 10 Mar 2017 18:45:25 -0600 Message-ID: <58C348A5.2090900@codeaurora.org> References: <1489139889-14376-1-git-send-email-anjiandi@codeaurora.org> <1489139889-14376-4-git-send-email-anjiandi@codeaurora.org> <20170310170113.GC22960@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170310170113.GC22960-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jason Gunthorpe Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, robert.moore-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lv.zheng-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On 03/10/17 11:01, Jason Gunthorpe wrote: > On Fri, Mar 10, 2017 at 03:58:09AM -0600, Jiandi An wrote: > >> + if (sm == ACPI_TPM2_COMMAND_BUFFER_WITH_SMC) { >> + if ((buf->header.length - default_len) != >> + sizeof(struct tpm2_crb_smc)) { >> + dev_err(dev, "TPM2 ACPI table has wrong size %u > for start method type %d\n", >> + buf->header.length, > > This should be: > > dev_err(dev, FW_BUG "TPM2 ACPI table has wrong size %u for start > method type %d\n", > > Jason I will fix this in next version. Waiting to see if there are more comments from others. Thanks - Jiandi > > -------------------------------------------------------------------------- > ---- > Announcing the Oxford Dictionaries API! The API offers world-renowned > dictionary content that is easy and intuitive to access. Sign up for an > account today to start using our lexical data to power your apps and > projects. Get started today and enter our developer competition. > http://sdm.link/oxford > _______________________________________________ > tpmdd-devel mailing list > tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org > https://lists.sourceforge.net/lists/listinfo/tpmdd-devel > -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. ------------------------------------------------------------------------------ Announcing the Oxford Dictionaries API! The API offers world-renowned dictionary content that is easy and intuitive to access. Sign up for an account today to start using our lexical data to power your apps and projects. Get started today and enter our developer competition. http://sdm.link/oxford